Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp2142004pxb; Fri, 17 Sep 2021 03:16:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDYkGR9UJQ12w9UCzJSo+Ai3+CmIIgZD4VCjOv1smF3pfz6qH3UgqIH8JVYuycyN0h1J3a X-Received: by 2002:a5e:c802:: with SMTP id y2mr8006839iol.162.1631873774030; Fri, 17 Sep 2021 03:16:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631873774; cv=none; d=google.com; s=arc-20160816; b=EXxpLaK943h5r6PEYQfn1pgjHXgv2c/QrkmXtqeGOsgM6RPFg2lIZPFqlaUgF4J94o mZbpeI6BmOSI5WhTvhiQMJEYTQkt7pP8MToQ31gAW0+umzkIG6ARB6K9wnpkNaswPwbJ IKFnRIocMu6Dd7jxahtkcR5All+OunBhk7QuhHdnWQ/mGOs03769WfN+TpUf+8KLFC6n Jbvu98nHgyCEriE9G4vKDeAyYV7axbrvKX2YOxlHEI5XeGqSzNcC+gmHQLgWK2WjlihI 8YT73DenMLNWLbC3wsYiSfXE6IkVg21fgJDmeekL6ZvzJM9I/RGd7b7rJaUYvpzAksnN yXNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=EnK0iPbbDGvlVAAAEZXGOso9jEI9bxAFwmv27esInqk=; b=f9OiepAh9zzdGA3eEKOeP26vVxlpTWxICIvEdm6j9vtzYnD3OF2IPoRJPteJqV21nm gINXdlcEigFENdKQBSVgyOOCoI4IrK+FCUHeZ+zp5fPbKZW0L+p3omhXCH06ZgQmJP8a quUuXwS1A+uoZEf9xGP5Phu7siUTD5zIYyz+zVVzT24Pw66U7zKzbnsjVLU8CHOoIe4i 6Z+EpSM9jP3i/0Ydx+3e07iuBqTRX3oM2956djTFK7thOKYKWwW8uBtWMPp/aGANu6jr Il2W1nc+hPjZ0vFABWEX54vZK8kFMZo35kHHrZs935PUF/5yBh2SMcbvMe9FC5bsnnj3 XFMg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v13si6193445ilu.168.2021.09.17.03.16.02; Fri, 17 Sep 2021 03:16:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242732AbhIQCaj (ORCPT + 99 others); Thu, 16 Sep 2021 22:30:39 -0400 Received: from mx24.baidu.com ([111.206.215.185]:32822 "EHLO baidu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235118AbhIQCai (ORCPT ); Thu, 16 Sep 2021 22:30:38 -0400 Received: from Bc-Mail-Ex13.internal.baidu.com (unknown [172.31.51.53]) by Forcepoint Email with ESMTPS id E47576738562BF827643; Fri, 17 Sep 2021 10:29:10 +0800 (CST) Received: from BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) by Bc-Mail-Ex13.internal.baidu.com (172.31.51.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2242.12; Fri, 17 Sep 2021 10:29:10 +0800 Received: from localhost (172.31.63.8) by BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Fri, 17 Sep 2021 10:29:10 +0800 Date: Fri, 17 Sep 2021 10:29:10 +0800 From: Cai Huoqing To: Krzysztof Kozlowski CC: Dmitry Torokhov , , Subject: Re: [PATCH] Input: ads7846 - Make use of the helper function dev_err_probe() Message-ID: <20210917022910.GA17584@LAPTOP-UKSR4ENP.internal.baidu.com> References: <20210916153104.13727-1-caihuoqing@baidu.com> <922265b2-bed7-8daa-3132-8cfc3b5e50fd@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <922265b2-bed7-8daa-3132-8cfc3b5e50fd@canonical.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [172.31.63.8] X-ClientProxiedBy: BJHW-Mail-Ex05.internal.baidu.com (10.127.64.15) To BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16 9月 21 21:34:26, Krzysztof Kozlowski wrote: > On 16/09/2021 17:31, Cai Huoqing wrote: > > When possible use dev_err_probe help to properly deal with the > > PROBE_DEFER error, the benefit is that DEFER issue will be logged > > in the devices_deferred debugfs file. > > Using dev_err_probe() can reduce code size, and the error value > > gets printed. > > > > Signed-off-by: Cai Huoqing > > --- > > drivers/input/touchscreen/ads7846.c | 7 ++----- > > 1 file changed, 2 insertions(+), 5 deletions(-) > > You sent 32 independent patches. Do you expect us to copy-paste similar > feedback on each of them? This would not make any sense. Please organize > all your submissions in a series with: > > git format-patch -32 > git send-email ..... 00* Ok, I'll try. but there are different owners for touchscreen/xxx, is it ok to send them the whole series? > > The patches you sent were already sent before: > https://lore.kernel.org/lkml/20200827185829.30096-1-krzk@kernel.org/ > > Best regards, > Krzysztof