Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 16 Sep 2021 20:03:28 -0400
From:   Peter Xu <peterx@redhat.com>
To:     John Hubbard <jhubbard@nvidia.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Mike Kravetz <mike.kravetz@oracle.com>
Subject: Re: [PATCH] mm/hugetlb: Drop __unmap_hugepage_range definition from
 hugetlb.h
Message-ID: <YUPbUEjhvPL/VArw@t490s>
References: <20210916212816.86838-1-peterx@redhat.com>
 <b99f88db-edeb-fab1-803e-5e083594bec8@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <b99f88db-edeb-fab1-803e-5e083594bec8@nvidia.com>
Precedence: bulk

On Thu, Sep 16, 2021 at 03:57:38PM -0700, John Hubbard wrote:
> On 9/16/21 14:28, Peter Xu wrote:
> > Drop it in the header since it's only used in hugetlb.c.
> 
> Hi Peter,

Hi, John,

> 
> Tiny documentation tweak: could the above line please be changed to
> something approximately like this:
> 
> "Remove __unmap_hugepage_range() from the header file, because it is
> only used in the .c file."
> 
> ?

Sure thing.

> 
> Because: "drop it in" is so close to "drop it into" (which means, "add
> it to"), that it's actually reading a lot like the opposite of what you
> intend to say.
> 
> > 
> > Suggested-by: Mike Kravetz <mike.kravetz@oracle.com>
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> >   include/linux/hugetlb.h | 10 ----------
> >   mm/hugetlb.c            |  6 +++---
> >   2 files changed, 3 insertions(+), 13 deletions(-)
> 
> 
> The change itself looks accurate for the current top of tree, so:
> 
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>

Thanks!

-- 
Peter Xu