Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] xen/x86: drop redundant zeroing from
 cpu_initialize_context()
To:     Jan Beulich <jbeulich@suse.com>, Juergen Gross <jgross@suse.com>
Cc:     Stefano Stabellini <sstabellini@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <14881835-a48e-29fa-0870-e177b10fcf65@suse.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <3ea71751-1de9-2da8-9a90-b4d22277c6c9@oracle.com>
Date:   Thu, 16 Sep 2021 21:35:44 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <14881835-a48e-29fa-0870-e177b10fcf65@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2JKVHNtRlAxcS9IczYyWFVPeit4eXRyMFREdmllT3VMcXlNaGtHcmlWTW9p?=
 =?utf-8?B?TmtiYjJJYXFGMVVzdGxPckhoRm5raHpNWjVWbnNvTDBheXdoZklTaDNtVHZp?=
 =?utf-8?B?c2l2QkpXaS9NZE03bmpKN1AyTDI1UzdsYkx1bUZvZzJBK1o5T3drZVJBUnpC?=
 =?utf-8?B?eEdZVk9Fa3NERmFwNXdRY2RaTUsxQmVMbU44TGlXanFwTFptVHNjL2JLcDlp?=
 =?utf-8?B?WDVZYllVcERxTmFFZk9sUkhFMEk0WXRwU3p6OWlQTlVqeThST09uZU9VaFpQ?=
 =?utf-8?B?cEhYV3llUHBlVTZjMmhRSk42YWVBRmRENFc0UTdiM2k2cWI0Q21PWUtGdUx0?=
 =?utf-8?B?SUF1UzVTdC9CM3plMXdSWVZacG1ONlR0STU5ZlZ0TW5iT3pGa2dNeUhkcVVC?=
 =?utf-8?B?b3NCSzFWZmpXUmVwdHJiRDhzR1pTSXRmNkpUeS9iZTFNbnE2V3k1M3VrTzkv?=
 =?utf-8?B?YnZmZzk0M2VaYjFrTWtBdUdhWlBma05DZ0tWSFR1d3EyTllyOW9HS1BRL2xo?=
 =?utf-8?B?aS9nYUc5Nk4vQmVZQ29EN0kzenM2b09zdnF4dGs4SUZNSmJ6VlNIY25lbVRn?=
 =?utf-8?B?ZllyaUZDRmwvVCs0SzZoNDJna1lZQWgwdDNQUzVqYk5FOTY3VGY4RTRxbXJz?=
 =?utf-8?B?b1c0U2REdG8xZ1lDRXR3UEY1ZnVHSWNBOVVpSW9Oa1JiQWhMUC9GQmp3S1VY?=
 =?utf-8?B?Tks2VkJNczROTythUDdxWVQ2cTAzRFZTSHl5dHVqOGRkaTh0SUlXK2JWL01h?=
 =?utf-8?B?YzZRZGM1OXgxb2tKRUkweHRZeVBQckZIOEt0YW1WQjQ0Zi82R2EwMGFxNnMz?=
 =?utf-8?B?WDl3c0cxV0RkWE5KMkx4cGpnV1RuVWN1Zlp1OGU1bUc0dW1mNkxyOWpyL294?=
 =?utf-8?B?cjgxNWIxSitZY2hVY3gxRVcvdys0UTRiRUIwOEplOTVCUDhkQmhsb0Y1Vi9K?=
 =?utf-8?B?OWFUcFZTbDhaK1V2QkkrZ0dQR2VqdnFvOWRLcXdoN280NzFnSDN4dFhoUzY1?=
 =?utf-8?B?dHhpWDFJVTV4TUhCdzdTYi9BNUtqM2Nyb29Pb3N3UzhEMm4vMDBQWmZvaVk5?=
 =?utf-8?B?NDlrNHFHNTBqMWlhSDFmZ3ozNTVVbHp6dDlnUXk4MGVvVDRGQmpIWkVOMHJN?=
 =?utf-8?B?Y0tIa1Z3YVFBajJsRWVVUnNyUTB1VXE1d09Kb2pKczZjd1Y4UHIyTU1reUlI?=
 =?utf-8?B?b0NKbW52STkrOWhnSHpGcTBMRzZmMm56ODZGNkErSVRmSlNKMVRrV2UxM3FV?=
 =?utf-8?B?VURUOU01M1ZmUVFuaDVtb0ZMaHNkZnBOVzlWOW0wamhxQXBVa1g4dDNpajYy?=
 =?utf-8?B?ZXFSY2huVTZhUHp0WnJZcWl0RTVLYlJXb0dISmFFbU5kUGladHAxOWRSeHBh?=
 =?utf-8?B?U2dYVFJSV3dVUmJsaG9SZkYySkxaOFBWRlR5YWZlLzVZOC8xcWhoVWI3cW5Q?=
 =?utf-8?B?VUljVForSisyd2FkK2s0Q2NlL1FUMnowclU0d0tDNkRkbGtRSzQrSlFXVkJh?=
 =?utf-8?B?ZmNQNlFxQ0I0b1BsR2R6VStEZTlEbEhWMlNFalZlby8rNElBSGhkaVZuY2NG?=
 =?utf-8?B?UXVUS3hlUjdqaUg0SE1PRUc0VlBYU1FkNy9sVi9haDN1TVRVejRtTm4zOEVa?=
 =?utf-8?B?azRsOTRwQmpvQXowU2JVWkZGNFVOYXIvR09KVkIxNGtNZkl1VU9IYm9uUTY2?=
 =?utf-8?B?UzRYU0gydGpQVVFROGRibEl4ZVhTNTZCVTIxWE1VQ25QaXN3aC9rbzNMeVc3?=
 =?utf-8?Q?TaxMLWYtwtdJHNK73Hc2LBJUYLJFaLAsLi+1h6w?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18620748-a5b3-4779-1eb7-08d9797b7949
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2021 01:35:48.0424
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z9rxFLvIJx5ESFJBd0WdGwb8laajDXY5wrxrHvmtyL7MyegTCBC3PeNiG93L+hK/ODZFzv1iRgZF0ycPK8Ho61tzVTbZMcYcB8yOrLG7ZiA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4192
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10109 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 suspectscore=0
 phishscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001
 definitions=main-2109170007
X-Proofpoint-GUID: 8Lvy2NR6RkG2NNG8CW1GBnXtIdCjCt7d
X-Proofpoint-ORIG-GUID: 8Lvy2NR6RkG2NNG8CW1GBnXtIdCjCt7d
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/16/21 11:05 AM, Jan Beulich wrote:
> Just after having obtained the pointer from kzalloc() there's no reason
> at all to set part of the area to all zero yet another time. Similarly
> there's no point explicitly clearing "ldt_ents".
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>


Reviewed-by: Boris Ostrovsky <boris.ostrvsky@oracle.com>