Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 17 Sep 2021 09:35:25 +0800
From:   Cai Huoqing <caihuoqing@baidu.com>
To:     Linus Walleij <linus.walleij@linaro.org>
CC:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Linux Input <linux-input@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Input: cyttsp - Make use of the helper function
 dev_err_probe()
Message-ID: <20210917013525.GA17348@LAPTOP-UKSR4ENP.internal.baidu.com>
References: <20210916153156.14098-1-caihuoqing@baidu.com>
 <CACRpkdau6wCjmeQeFuadsyhi_XZQ6AATYw1okSBMOYbCoGkmCA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CACRpkdau6wCjmeQeFuadsyhi_XZQ6AATYw1okSBMOYbCoGkmCA@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

Hi
thanks for your feedback.

On 17 9月 21 00:30:32, Linus Walleij wrote:
> Hi Cai,
> 
> On Thu, Sep 16, 2021 at 5:32 PM Cai Huoqing <caihuoqing@baidu.com> wrote:
> 
> >         if (IS_ERR(ts->reset_gpio)) {
> >                 error = PTR_ERR(ts->reset_gpio);
> > -               dev_err(dev, "Failed to request reset gpio, error %d\n", error);
> > +               dev_err_probe(dev, error, "Failed to request reset gpio\n");
> >                 return ERR_PTR(error);
> 
> In this case you're supposed to do
> 
> return dev_err_probe(dev, error, "Failed to request reset gpio\n");
the probe function is defined:
"struct cyttsp *cyttsp_probe("

so it is required to return a PTR:cyttsp *.
Thanks
Cai

> 
> Yours,
> Linus Walleij