Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 16 Sep 2021 20:38:02 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Joakim Zhang <qiangqing.zhang@nxp.com>
Cc:     Vladimir Oltean <vladimir.oltean@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 net] net: mscc: ocelot: remove buggy and useless write
 to ANA_PFC_PFC_CFG
Message-ID: <20210917033802.GA681448@euler>
References: <20210916010938.517698-1-colin.foster@in-advantage.com>
 <20210916114917.aielkefz5gg7flto@skbuf>
 <DB8PR04MB67954EE02059714DD9A72435E6DD9@DB8PR04MB6795.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <DB8PR04MB67954EE02059714DD9A72435E6DD9@DB8PR04MB6795.eurprd04.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTZ5TDdLc0JMa2hqQXhXVmtIQjA5cXVKVXMxKzRhVk16WUZDRVBVMWo1NWRh?=
 =?utf-8?B?NmhyVDZrYkdTWG1Pb0w2RGZ0cU83bytKL2xNR1JOb2Z0aTR4Q25UY3dnanhM?=
 =?utf-8?B?cEQvaWdXQXlvSDNVVFE5Qm5WNW95ZEFCUWs4U1RKRTdSZkllVWlZdHZSM2li?=
 =?utf-8?B?ZDRVWTRtcFJwblpHYUd3c3hJNHowK2poeTNldjBBVmVNdlFwK1VkQ0NPd0hz?=
 =?utf-8?B?YnFRNTNsZS93SDFoUktyYThlclVsdlE3Z3E3WG1BeERGN0dBS2h3aWxIb3B2?=
 =?utf-8?B?empYTWF5K1FTR1NyaXF0bUZWcjFzdWpPWG01dXlERDQxK2ttN1ZTOWlVbHda?=
 =?utf-8?B?WkJQMnhBMm1DVlZZbkx2cHFJeXRzTzA3Q0NCc0hKeC9YWkN0a01VOXpzRHQ1?=
 =?utf-8?B?SDhSUTVEWG5PejFidnZZTmtKaUZmY29BeUFZcXBBNzRCbFA0VDVjbEJoQnJM?=
 =?utf-8?B?UGM0YWgwM0lWR0VadU1CYTJibjRUWUo5bkZWaHduSFhyWldCMDh5VWhYUWp2?=
 =?utf-8?B?OHBYTEtodlQyUTlXZ2lrM1l5MENoTUJ4bDlmbWZBVllqK0xpNStLWjgzY0dm?=
 =?utf-8?B?MUg3VTJvUExEQzRwWFp6WEYrRmY3dXNDdk5IQW1ITTBrekk4bzB3cVAyOHVP?=
 =?utf-8?B?Z2lBQUlheWZRSDVxTU9acVVFcEFkZ3dJOGVneUh0T0lTMHNrMi81K1dqRUV4?=
 =?utf-8?B?TEw5Qk00M09mVTc4RlBuZmRNbHZ6Qm1WeTZIVEVHQmpYa1Q4MC9uaXBnUkRM?=
 =?utf-8?B?ZUg1ditMdUtHNFdKMkZNOGk5MFBYQjBqRGxlV3JScXNSOFlxaTc3MDVKU3B4?=
 =?utf-8?B?d1Q0MHJPVk5aVjlEKzV6VmxZd2tkbUc0aUhkUGZWeVgxOW1TT25nd09HdHBu?=
 =?utf-8?B?NjdVajdXSmdub1ZVaEhJcHdSMVBBM1UrVk1OZ2J2ckJlTklsVUx4dmNyREZC?=
 =?utf-8?B?U2U3ajJkcDRSQ1J3Y1k3SWs4WWdVc2RxdU9pRE5Rb1k2WUVpMHBBMGtwTWd2?=
 =?utf-8?B?VjJUM1pLOWtvYWwyZnAvaXFLS3lOY3dHMGRsM01tQXphTFVMSTZ1NlhvQjQ3?=
 =?utf-8?B?cUV1SlRjMHVuYnp1QXlZcVlFczVNUGw0OVd0WVYvdWMyTWYvcXQ5QjczYUMy?=
 =?utf-8?B?ZGdsQmRzKzEzdGQ1VFNxM3ZhbUVjTkRBUnNZanhDVFROSEdQQjVtUCtEeFVk?=
 =?utf-8?B?MU5uSThibDZjSDVlUUtLQXUwMEtjL2l5MGRIeUJnWFRuMmhXaHZwVkthOEhP?=
 =?utf-8?B?YktiQ1loUWlRaVdCYXF1NzRJMU5UMjQxeEVRdzJrWGpaNXlPZjRZWlRqd2Zu?=
 =?utf-8?B?MmFZUkQ4aTNLdlk5SVhhM09HUzRSTVdrQmhJdVJzeGRtenZsN29Pcmh5cjRO?=
 =?utf-8?B?SW4ycU1teEhVZysrU1FvV1FsNmZnc0lsUDZkV0xLdlNNRUYwK3R6SzNXeFRJ?=
 =?utf-8?B?eUEwUUwzdE1jcXRRanY3ckg4RHRDYzFSZUlqNHJqK3J6ZHNjN2lRMUQ3c1hL?=
 =?utf-8?B?azhSbU9zZU0vczZCMUlTTkxqTWovdC9lZ2ErYUhtbncwNldQU0VtNzFuVi91?=
 =?utf-8?B?SXArSmV0NzNlU0MyU09NUGdIZ2Mzb2RlSXo4YTNicmdmcXd6Q29Vc2UwdStK?=
 =?utf-8?B?eURNRGY2SDNZVkVwQXYvSWRDWjFxREZOUmR4ZS9QYnlOSWFiUnUvdEVGdGtj?=
 =?utf-8?B?dzJENFhVZWlEMVhpQXU5NUcvR0kxM0kvREJRRzdudTBTcUQzYStiVmNiYkxE?=
 =?utf-8?Q?+0RFmAVN4RTacuaaFuhQ1Hsz5j909Xec8mja7Kp?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 494754cd-7582-4b4c-5fc1-08d9798c9375
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2021 03:38:12.9439
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GDXNmN+Zi+G8+bJS326je6296dgt+S+epvhjbuNsyJCKbDc/2Rr3wwpw5XxvUGHJaAwBGVzghu0E/TWQGVHbF6GIGCyA+cNOVpovG4WbJVI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1342
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 17, 2021 at 02:34:37AM +0000, Joakim Zhang wrote:
> 
> Hi Vladimir,
> 
> > -----Original Message-----
> > From: Vladimir Oltean <vladimir.oltean@nxp.com>
> > Sent: 2021年9月16日 19:49
> > To: Colin Foster <colin.foster@in-advantage.com>
> > Cc: Claudiu Manoil <claudiu.manoil@nxp.com>; Alexandre Belloni
> > <alexandre.belloni@bootlin.com>; UNGLinuxDriver@microchip.com; David S.
> > Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>;
> > netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH v1 net] net: mscc: ocelot: remove buggy and useless write
> > to ANA_PFC_PFC_CFG
> > 
> > On Wed, Sep 15, 2021 at 06:09:37PM -0700, Colin Foster wrote:
> > > A useless write to ANA_PFC_PFC_CFG was left in while refactoring
> > > ocelot to phylink. Since priority flow control is disabled, writing
> > > the speed has no effect.
> > >
> > > Further, it was using ethtool.h SPEED_ instead of OCELOT_SPEED_
> > > macros, which are incorrectly offset for GENMASK.
> > >
> > > Lastly, for priority flow control to properly function, some scenarios
> > > would rely on the rate adaptation from the PCS while the MAC speed
> > > would be fixed. So it isn't used, and even if it was, neither "speed"
> > > nor "mac_speed" are necessarily the correct values to be used.
> > >
> > > Fixes: e6e12df625f2 ("net: mscc: ocelot: convert to phylink")
> > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > > ---
> > >  drivers/net/ethernet/mscc/ocelot.c | 4 ----
> > >  1 file changed, 4 deletions(-)
> > >
> > > diff --git a/drivers/net/ethernet/mscc/ocelot.c
> > > b/drivers/net/ethernet/mscc/ocelot.c
> > > index c581b955efb3..08be0440af28 100644
> > > --- a/drivers/net/ethernet/mscc/ocelot.c
> > > +++ b/drivers/net/ethernet/mscc/ocelot.c
> > > @@ -569,10 +569,6 @@ void ocelot_phylink_mac_link_up(struct ocelot
> > *ocelot, int port,
> > >  	ocelot_port_writel(ocelot_port, DEV_CLOCK_CFG_LINK_SPEED(speed),
> > >  			   DEV_CLOCK_CFG);
> > >
> > > -	/* No PFC */
> > > -	ocelot_write_gix(ocelot, ANA_PFC_PFC_CFG_FC_LINK_SPEED(speed),
> > > -			 ANA_PFC_PFC_CFG, port);
> > > -
> > 
> > This will conflict with the other patch.... why didn't you send both as part of a
> > series? By not doing that, you are telling patchwork to build-test them in
> > parallel, which of course does not work:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchw
> > ork.kernel.org%2Fproject%2Fnetdevbpf%2Fpatch%2F20210916012341.518512-
> > 1-colin.foster%40in-advantage.com%2F&amp;data=04%7C01%7Cqiangqing.zh
> > ang%40nxp.com%7C546aa03ab17b45f0891a08d97908095f%7C686ea1d3bc2b
> > 4c6fa92cd99c5c301635%7C0%7C0%7C637673897688805938%7CUnknown%7
> > CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> > CJXVCI6Mn0%3D%7C1000&amp;sdata=fmGI6K2dS36tm5xuuKLKdVF1pEj9umv
> > FLA8kyfXWD3A%3D&amp;reserved=0
> > 
> > Also, why didn't you bump the version counter of the patch, and we're still at v1
> > despite the earlier attempt?
> > 
> > git format-patch -2 --cover-letter --subject-prefix="PATCH v3 net" -o
> > /opt/patches/linux/ocelot-phylink-fixes/v3/
> > ./scripts/get_maintainer.pl /opt/patches/linux/ocelot-phylink-fixes/v3/*.patch
> > ./scripts/checkpatch.pl --strict
> > /opt/patches/linux/ocelot-phylink-fixes/v3/*.patch
> > # Go through patches, write change log compared to v2 using vimdiff, meld, git
> > range-diff, whatever # Write cover letter summarizing what changes and why.
> > If fixing bugs explain the impact.
> > git send-email \
> > 	--to='netdev@vger.kernel.org' \
> > 	--to='linux-kernel@vger.kernel.org' \
> > 	--cc='Vladimir Oltean <vladimir.oltean@nxp.com>' \
> > 	--cc='Claudiu Manoil <claudiu.manoil@nxp.com>' \
> > 	--cc='Alexandre Belloni <alexandre.belloni@bootlin.com>' \
> > 	--cc='UNGLinuxDriver@microchip.com' \
> > 	--cc='"David S. Miller" <davem@davemloft.net>' \
> > 	--cc='Jakub Kicinski <kuba@kernel.org>' \
> > 	/opt/patches/linux/ocelot-phylink-fixes/v3/*.patch
> > 
> > Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> > 
> > Please keep this tag but resend a new version. You can download the patch
> > with the review tags automatically using:
> > git b4 20210916010938.517698-1-colin.foster@in-advantage.com
> > git b4 20210916012341.518512-1-colin.foster@in-advantage.com
> > 
> > where "git b4" is an alias configured like this in ~/.gitconfig:
> > 
> > [b4]
> > 	midmask =
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.ker
> > nel.org%2Fr%2F%2525s&amp;data=04%7C01%7Cqiangqing.zhang%40nxp.co
> > m%7C546aa03ab17b45f0891a08d97908095f%7C686ea1d3bc2b4c6fa92cd99c5
> > c301635%7C0%7C0%7C637673897688815892%7CUnknown%7CTWFpbGZsb3d
> > 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3
> > D%7C1000&amp;sdata=t8N%2F%2FAnLVLtoMDzNDL%2Fv7ixEkBeiIqB6Go%2F
> > zD19gisE%3D&amp;reserved=0
> > [alias]
> > 	b4 = "!f() { b4 am -t -o - $@ | git am -3; }; f"
> 
> I came across this detailed suggestions, sometime we need download the patch from the patchwork,
> so I have a try with above method(adding these two symbol in my .gitconfig), but I met below error,
> could you please tell me what I am missing? Thanks.

One that I can answer.

b4 is a Python command.
"pip install b4" should install it, then export
/home/username/.local/bin into PATH
"export PATH=/home/colin/.local/bin:$PATH"

You can add this path to ~/.profile if you want it to persist.

> 
> $ git b4 20210916010938.517698-1-colin.foster@in-advantage.com
> f() { b4 am -t -o - $@ | git am -3; }; f: 1: f() { b4 am -t -o - $@ | git am -3; }; f: b4: not found
> 
> Best Regards,
> Joakim Zhang