Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
References: <20210917021852.2037-1-wcheng@codeaurora.org>
User-agent: mu4e 1.6.5; emacs 27.2
From:   Felipe Balbi <balbi@kernel.org>
To:     Wesley Cheng <wcheng@codeaurora.org>
Cc:     gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: gadget: Avoid starting DWC3 gadget during
 UDC unbind
Date:   Fri, 17 Sep 2021 08:17:03 +0300
In-reply-to: <20210917021852.2037-1-wcheng@codeaurora.org>
Message-ID: <87y27vai3p.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Hi,

Wesley Cheng <wcheng@codeaurora.org> writes:

> There is a race present where the DWC3 runtime resume runs in parallel
> to the UDC unbind sequence.  This will eventually lead to a possible
> scenario where we are enabling the run/stop bit, without a valid
> composition defined.
>
> Thread#1 (handling UDC unbind):
> usb_gadget_remove_driver()
> -->usb_gadget_disconnect()
>   -->dwc3_gadget_pullup(0)
> --> continue UDC unbind sequence
> -->Thread#2 is running in parallel here
>
> Thread#2 (handing next cable connect)
> __dwc3_set_mode()
>   -->pm_runtime_get_sync()
>     -->dwc3_gadget_resume()
>       -->dwc->gadget_driver is NOT NULL yet
>       -->dwc3_gadget_run_stop(1)
>       --> _dwc3gadget_start()
> ...
>
> Fix this by tracking the pullup disable routine, and avoiding resuming
> of the DWC3 gadget.  Once the UDC is re-binded, that will trigger the
> pullup enable routine, which would handle enabling the DWC3 gadget.
>
> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>

This looks okay to me, but needs to be tested by a few folks ;-)

Acked-by: Felipe Balbi <balbi@kernel.org>

-- 
balbi