Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: wcheng=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org B7A75C4338F
Subject: Re: [PATCH] usb: dwc3: gadget: Avoid starting DWC3 gadget during UDC
 unbind
To:     Felipe Balbi <balbi@kernel.org>
Cc:     gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210917021852.2037-1-wcheng@codeaurora.org>
 <87y27vai3p.fsf@kernel.org>
From:   Wesley Cheng <wcheng@codeaurora.org>
Message-ID: <474148e5-37e2-ea0c-7d78-9e71155314d9@codeaurora.org>
Date:   Thu, 16 Sep 2021 23:28:09 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <87y27vai3p.fsf@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 9/16/2021 10:17 PM, Felipe Balbi wrote:
> 
> Hi,
> 
> Wesley Cheng <wcheng@codeaurora.org> writes:
> 
>> There is a race present where the DWC3 runtime resume runs in parallel
>> to the UDC unbind sequence.  This will eventually lead to a possible
>> scenario where we are enabling the run/stop bit, without a valid
>> composition defined.
>>
>> Thread#1 (handling UDC unbind):
>> usb_gadget_remove_driver()
>> -->usb_gadget_disconnect()
>>   -->dwc3_gadget_pullup(0)
>> --> continue UDC unbind sequence
>> -->Thread#2 is running in parallel here
>>
>> Thread#2 (handing next cable connect)
>> __dwc3_set_mode()
>>   -->pm_runtime_get_sync()
>>     -->dwc3_gadget_resume()
>>       -->dwc->gadget_driver is NOT NULL yet
>>       -->dwc3_gadget_run_stop(1)
>>       --> _dwc3gadget_start()
>> ...
>>
>> Fix this by tracking the pullup disable routine, and avoiding resuming
>> of the DWC3 gadget.  Once the UDC is re-binded, that will trigger the
>> pullup enable routine, which would handle enabling the DWC3 gadget.
>>
>> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>

Thanks, Felipe!

> 
> This looks okay to me, but needs to be tested by a few folks ;-)
> 
> Acked-by: Felipe Balbi <balbi@kernel.org>
> 
Yes, would be good to get some functions using
usb_gadget_activate/deactivate().  It should be OK for those situations
as well, but just to make sure :)

Thanks
Wesley Cheng
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project