Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFT][PATCH] regulator: max14577: Revert
 "regulator: max14577: Add proper module aliases strings"
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>, linux-kernel@vger.kernel.org
From:   Marek Szyprowski <m.szyprowski@samsung.com>
Message-ID: <acb72aa2-4211-4c2f-1176-82d533ddf8b5@samsung.com>
Date:   Fri, 17 Sep 2021 09:30:34 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0)
        Gecko/20100101 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20210916144102.120980-1-krzysztof.kozlowski@canonical.com>
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <CGME20210916144119eucas1p1ef79e9742c3d37d0d896f152b4252a0b@eucas1p1.samsung.com>
        <20210916144102.120980-1-krzysztof.kozlowski@canonical.com>
Precedence: bulk

Hi Krzysztof,

On 16.09.2021 16:41, Krzysztof Kozlowski wrote:
> This reverts commit 0da6736ecd10b45e535b100acd58df2db4c099d8.
>
> The MODULE_DEVICE_TABLE already creates proper alias.  Having another
> MODULE_ALIAS causes the alias to be duplicated:
>
>    $ modinfo max14577-regulator.ko
>
>    alias:          platform:max77836-regulator
>    alias:          platform:max14577-regulator
>    description:    Maxim 14577/77836 regulator driver
>    alias:          platform:max77836-regulator
>    alias:          platform:max14577-regulator
>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Fixes: 0da6736ecd10 ("regulator: max14577: Add proper module aliases strings")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> ---
>
> Not tested. Please test/comment.  This is an RFT also because reverted
> commit said to fix autoloading issue which I even reviewed... but really
> it should not be needed - alias gets duplicated.
> ---

Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>

Indeed, that patch was useless and excessive. It must be some leftover 
from my initial modules tests, which for good reasons was not submitted 
in the initial series in Feb 2020. Sorry for the noise.

>   drivers/regulator/max14577-regulator.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/regulator/max14577-regulator.c b/drivers/regulator/max14577-regulator.c
> index 1d78b455cc48..e34face736f4 100644
> --- a/drivers/regulator/max14577-regulator.c
> +++ b/drivers/regulator/max14577-regulator.c
> @@ -269,5 +269,3 @@ module_exit(max14577_regulator_exit);
>   MODULE_AUTHOR("Krzysztof Kozlowski <krzk@kernel.org>");
>   MODULE_DESCRIPTION("Maxim 14577/77836 regulator driver");
>   MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:max14577-regulator");
> -MODULE_ALIAS("platform:max77836-regulator");

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland