Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp2268579pxb; Fri, 17 Sep 2021 06:12:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsNHwSWX9XygXsSAU33YIn907QV/YHUs3vjXiQ6YMlr5mDu8w7DrAwr+omdo4iS8ZM2iQ+ X-Received: by 2002:a5d:4b4f:: with SMTP id w15mr12074854wrs.175.1631884347478; Fri, 17 Sep 2021 06:12:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631884347; cv=none; d=google.com; s=arc-20160816; b=YIPfvMQrNT6gxjg9vUddA3ZEAzUObOyqh4WTlRTTF1YFMFVypc+lnLbIjZDOW1L23b KaKyWCpBbf2YwdbLqXcR4q3a7j4kgx59OPAKY5TDkKwCs6MpgPaHp0M05I/lcpgumo67 QQ7i2tvvussvtUVOeJJRfDK9ugdk0s5GI7H8GSTIwjDRAocEwVv+qSrqAwzf5/nHUMj/ j+60GlX0N9GIF0guCGZ0wHywlV0R8LtQJYTLhUeZaQZTNtsHWIYsubV3skSCnos5N48K dyr1iaCUf0gxLpL/aJZ1NksbcIQ6keTP+Bi2XAkRvZelz0lcnzf2jocbBTFSr/U+xIzW 7UuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=YDJr73yVgkekvJkt9rshETzgKC3pw7Vz16Ry4YYZbBs=; b=YuzddKCLdCRB2lFetxbAWfF9S9kiM/4oYv6kiV5qi4h8m89xk2hkE+GwkdSISJUTt6 KjQhJUvQ+RWvR/+LwqRUjcnEfmePznNFWXrs6GkK2FfvEB1VmMiSW72AbNmIUWku2cE6 Pe19ptMb1w+MhMW+GX/uvwXlXJw1wgjMLpf5F7nApmKohbDjeyrJzRSMCXhqCJECuZbg krHOJBgSlHNGTIw0B2fBW9p2OrgsqTu8mNVNLs7AJIjjt90Vsw+yClxP0nulioDB8QNE g+Qw+qleyw4tXbdRGxNIBUldtVH5MTRbIlMdm+SwsiPKT9Pswi4o3kluP/fHh9E8L30J KWOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=ZPp0s+c+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q14si6917217edb.568.2021.09.17.06.11.58; Fri, 17 Sep 2021 06:12:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=ZPp0s+c+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240595AbhIQIKu (ORCPT + 99 others); Fri, 17 Sep 2021 04:10:50 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:49824 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245596AbhIQIKk (ORCPT ); Fri, 17 Sep 2021 04:10:40 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 51D3F1FD5D; Fri, 17 Sep 2021 08:09:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1631866157; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YDJr73yVgkekvJkt9rshETzgKC3pw7Vz16Ry4YYZbBs=; b=ZPp0s+c+kU2WIdmH5VZIdC9hGdFR4TJoACC7/rZZPsJXF9Hr309Yto92B1EsTJX6r9fJ5C G9t1az9JzcVWXFR0nWQKYbRz0xpNDSmYFe2WuGzhI2Fjoyh0DC6EpWPPltSDeRFegnDC4q SjpweXDINhG1aTsH/P5mflYoPm7nCPs= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 322E113A86; Fri, 17 Sep 2021 08:09:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HPWFCy1NRGFxKwAAMHmgww (envelope-from ); Fri, 17 Sep 2021 08:09:17 +0000 Date: Fri, 17 Sep 2021 10:09:15 +0200 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: brookxu Cc: tj@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org, vipinsh@google.com, corbet@lwn.net, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v3 2/3] misc_cgroup: remove error log to avoid log flood Message-ID: <20210917080915.GB3827@blackbody.suse.cz> References: <3834f917d50a6f19402e179e917ef6a9dde5f64a.1631671936.git.brookxu@tencent.com> <20210916175711.GA12643@blackbody.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 17, 2021 at 09:56:26AM +0800, brookxu wrote: > Yeah, maybe we should make it more clearly, What do you think of > the commit below: > > In scenarios where containers are frequently created and deleted, > a large number of error logs maybe generated. The logs only show > which node is about to go over the max limit, not the node which > resource request failed. As misc.event has provided relevant > information, maybe we can remove this log. It is a good reasoning for the change. LGTM. Michal