Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp2280422pxb; Fri, 17 Sep 2021 06:25:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8wLt2276VM1RsO+sXXeA7zWrA00SBRoAdFE2AxKgBVFyj4QRUOUX/ia3hj7s1L2X0/539 X-Received: by 2002:a05:6402:697:: with SMTP id f23mr12128584edy.253.1631885130809; Fri, 17 Sep 2021 06:25:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631885130; cv=none; d=google.com; s=arc-20160816; b=DweJyTycwWHRAReT7uWP8XLGqaapXagmkNGLS2XtUNDsU/PTDsmZBQH/WnbkP0u9N/ bf5me7jATgA/TEofHj0o/JiIJLVjTU5v9n7yWmBhJFTIKG0wSBYtDLUG6yos3g8XVtzD 0mA3tL91d+OveLWqwa+cMwyYVWDxrM9Ci0BbO5idm5xor9Wws/Gt69i1N/+Apo30TrdZ RBRhq4IFPduA2b9AmPmIG2SJFOItnIYaaEomIo12yVAgBHBkr3Y0p/UsZuD63/L3g+A6 AKev5uVXH+btS0PtJDD3nA9w+gvM7jjAkMiTo0aqf61B8OC3MTE2Td5kuMZXCB2JxAd0 Pebw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=CeZGDq8ylzh0OWJzXB6+CtfSipSUr15SxgokLFW4ZVI=; b=MwA0n7K1XhZ0GcidM1ZXwpy+RCXTz8bJXSP/2C8D6c7YP4Q8x4c8TxP+SeGaXGIEYj OCvGZn4b2cUZFt5s7iDhe2ELaFxjU6+n2z5tMJl8/Oi1h9dUvkzz49B4bHAvWSW07qVA RHiT6/GSUfOmw/h17mEI3HRJpdAf3lEdXDLnvlv8vEnEFM0nQZyO/vzwz6u1lPfkl/Xy fCDOJ8O+ZW0gtICK3aZelf68paAsS87EHqmDg5s6UonSoS0MGbuvJYZwuUEZkJL9LwOS gbNArUSglpTreKlrP1gKKB0ofVSA93Ss0U3kRz23XE//7lAkJW8F04uvqaJ6jXmwNi9u 7DiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=WaymPEyR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i19si6842661ejw.660.2021.09.17.06.25.04; Fri, 17 Sep 2021 06:25:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=WaymPEyR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245208AbhIQImt (ORCPT + 99 others); Fri, 17 Sep 2021 04:42:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233688AbhIQIms (ORCPT ); Fri, 17 Sep 2021 04:42:48 -0400 Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AB26C061574; Fri, 17 Sep 2021 01:41:26 -0700 (PDT) Received: by mail-oi1-x231.google.com with SMTP id o66so10340053oib.11; Fri, 17 Sep 2021 01:41:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CeZGDq8ylzh0OWJzXB6+CtfSipSUr15SxgokLFW4ZVI=; b=WaymPEyRLqNpvKq6QKWcZQuFRxGbIlHlFC5742NkQMVBtfx60uoTSYM5jlUNRoD7oW q9amg37w+jLi3kcMqCyQyv+Kc49G5ljBNfEyWm9QPiSpEeS7EHAUBJoAz5zMRAeQ88CO 9qYON5/tbRVZcuU3DFs8MBdSWOt+XoMmtOU9VxwfOl3lVDdjPW00E0aOW0acpOxw7CeY Eny41KXEeNuwqzPk+bYvyWd3gvewUOuuv/FpLZ3rSslqJBejf+lBRLj3hSn/yrkxqQSz bMufkCWsZE3THwurq28MEqJI4KYNfzSQdnqVM5B4aHnXSkoZKZebJqcpV8s330Z8q4Kd l8Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CeZGDq8ylzh0OWJzXB6+CtfSipSUr15SxgokLFW4ZVI=; b=lde1zudQVN1rFj0d/B18LCvQDqFlzngOs9aFtSlRY3s6q/XRbK/Z0LnZy76TwNF8F8 VT07hJ/n8lEYm+X1yIqP1rCNs3DckvHVeemREo8blgggf6bXAwajvd9GlTI+1Im20/HC RrdhkYPPg83HQj33s8rfM3qpYAzw4kW9nU1THlw0oUGsEdL2wq7AYaVbIMmiTdhyvbsO ms66FUCtgS02+3HYpNC2wWMMVsczExWW3VE3rH2ALDlBrr7tMghkIRfA0jt67k3T2Te6 O2KV/WLGBXA3zth4uYcL96d+BgmlVlwNa8ju5bniRaIXwlVHT6Cl+Zf54Wjl1wzJ/Ox3 8oRA== X-Gm-Message-State: AOAM532AiRhdM1miwA36n3bXYIKcUM8fJwjKqQnsl8md0kfl6fXxLu+v bYynPqxvjiV9oiXGlCmIVCzl5rUThWZOBgGOODs= X-Received: by 2002:aca:1717:: with SMTP id j23mr3076167oii.43.1631868085306; Fri, 17 Sep 2021 01:41:25 -0700 (PDT) MIME-Version: 1.0 References: <20210916084714.311048-1-zhang.lyra@gmail.com> <20210916084714.311048-3-zhang.lyra@gmail.com> In-Reply-To: From: Chunyan Zhang Date: Fri, 17 Sep 2021 16:40:49 +0800 Message-ID: Subject: Re: [PATCH v2 2/4] dt-bindings: clk: sprd: Add bindings for ums512 clock controller To: Rob Herring Cc: Stephen Boyd , linux-clk , DTML , Baolin Wang , Orson Zhai , Chunyan Zhang , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Sept 2021 at 22:29, Rob Herring wrote: > > On Thu, Sep 16, 2021 at 04:47:12PM +0800, Chunyan Zhang wrote: > > From: Chunyan Zhang > > > > Add a new bindings to describe ums512 clock compatible strings. > > > > Signed-off-by: Chunyan Zhang > > --- > > .../bindings/clock/sprd,ums512-clk.yaml | 106 ++++++++++++++++++ > > 1 file changed, 106 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml > > > > diff --git a/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml b/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml > > new file mode 100644 > > index 000000000000..be3c37180279 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/sprd,ums512-clk.yaml > > @@ -0,0 +1,106 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +# Copyright 2019-2021 Unisoc Inc. > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/clock/sprd,ums512-clk.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: UMS512 Clock Control Unit Device Tree Bindings > > + > > +maintainers: > > + - Orson Zhai > > + - Baolin Wang > > + - Chunyan Zhang > > + > > +properties: > > + "#clock-cells": > > + const: 1 > > + > > + compatible: > > + enum: > > + - sprd,ums512-apahb-gate > > + - sprd,ums512-ap-clk > > + - sprd,ums512-aonapb-clk > > + - sprd,ums512-pmu-gate > > + - sprd,ums512-g0-pll > > + - sprd,ums512-g2-pll > > + - sprd,ums512-g3-pll > > + - sprd,ums512-gc-pll > > + - sprd,ums512-aon-gate > > + - sprd,ums512-audcpapb-gate > > + - sprd,ums512-audcpahb-gate > > + - sprd,ums512-gpu-clk > > + - sprd,ums512-mm-clk > > + - sprd,ums512-mm-gate-clk > > + - sprd,ums512-apapb-gate > > + > > + clocks: > > + minItems: 1 > > + maxItems: 4 > > + description: | > > + The input parent clock(s) phandle for this clock, only list fixed > > + clocks which are declared in devicetree. > > + > > + clock-names: > > + minItems: 1 > > + maxItems: 4 > > + items: > > + - const: ext-26m > > + - const: ext-32k > > + - const: ext-4m > > + - const: rco-100m > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - '#clock-cells' > > + > > +if: > > + properties: > > + compatible: > > + enum: > > + - sprd,ums512-ap-clk > > + - sprd,ums512-aonapb-clk > > + - sprd,ums512-mm-clk > > +then: > > + required: > > + - reg > > + > > +else: > > + description: | > > + Other UMS512 clock nodes should be the child of a syscon node in > > + which compatible string should be: > > + "sprd,ums512-glbregs", "syscon", "simple-mfd" > > + > > + The 'reg' property for the clock node is also required if there is a sub > > + range of registers for the clocks. > > In which cases is this not true? Seems not needed, I will remove 'reg' property for this kind of cases. > > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + ap_clk: clock-controller@20200000 { > > + compatible = "sprd,ums512-ap-clk"; > > + reg = <0x20200000 0x1000>; > > + clocks = <&ext_26m>; > > + clock-names = "ext-26m"; > > + #clock-cells = <1>; > > + }; > > + > > + - | > > + ap_apb_regs: syscon@71000000 { > > + compatible = "sprd,ums512-glbregs", "syscon", "simple-mfd"; > > + reg = <0x71000000 0x3000>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges = <0 0x71000000 0x3000>; > > + > > + apahb_gate: clock-controller@0 { > > + compatible = "sprd,ums512-apahb-gate"; > > + reg = <0x0 0x2000>; > > + #clock-cells = <1>; > > + }; > > We have this example in the MFD schema, so drop it here. Ok. Thanks for your review and comments, Chunyan