Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 17 Sep 2021 11:05:18 +0100
Message-ID: <87h7ejbjq9.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Alyssa Rosenzweig <alyssa@rosenzweig.io>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        Rob Herring <robh+dt@kernel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= <kw@linux.com>,
        Stan Skowronek <stan@corellium.com>,
        Mark Kettenis <kettenis@openbsd.org>,
        Sven Peter <sven@svenpeter.dev>,
        Hector Martin <marcan@marcan.st>,
        Robin Murphy <Robin.Murphy@arm.com>, kernel-team@android.com
Subject: Re: [PATCH v3 09/10] iommu/dart: Exclude MSI doorbell from PCIe device IOVA range
In-Reply-To: <YT+euTycu1hp75L8@sunset>
References: <20210913182550.264165-1-maz@kernel.org>
        <20210913182550.264165-10-maz@kernel.org>
        <YT+euTycu1hp75L8@sunset>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 13 Sep 2021 19:55:53 +0100,
Alyssa Rosenzweig <alyssa@rosenzweig.io> wrote:
> 
> > +config PCIE_APPLE_MSI_DOORBELL_ADDR
> > +	hex
> > +	default 0xfffff000
> > +	depends on PCIE_APPLE
> > +
> >  config PCIE_APPLE
> >  	tristate "Apple PCIe controller"
> >  	depends on ARCH_APPLE || COMPILE_TEST
> > diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c
> > index 1ed7b90f8360..76344223245d 100644
> > --- a/drivers/pci/controller/pcie-apple.c
> > +++ b/drivers/pci/controller/pcie-apple.c
> > @@ -120,8 +120,10 @@
> >   * The doorbell address is set to 0xfffff000, which by convention
> >   * matches what MacOS does, and it is possible to use any other
> >   * address (in the bottom 4GB, as the base register is only 32bit).
> > + * However, it has to be excluded from the the IOVA range, and the
> > + * DART driver has to know about it.
> >   */
> > -#define DOORBELL_ADDR			0xfffff000
> > +#define DOORBELL_ADDR		CONFIG_PCIE_APPLE_MSI_DOORBELL_ADDR
> 
> I'm unsure if Kconfig is the right place for this. But if it is, these
> hunks should be moved earlier in the series (so the deletion gets
> squashed away of the hardcoded-in-the-C.)

I'd rather not doing that. There is a progression in the series, and
moving the value over to Kconfig is part of that progression.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.