Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 17 Sep 2021 13:37:48 +0200
From:   Michal Kubecek <mkubecek@suse.cz>
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        linux-kernel@vger.kernel.org
Cc:     Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] nvmem: nintendo-otp: add dependency on CONFIG_HAS_IOMEM
Message-ID: <20210917113748.aula2xsiih5wsjdq@lion.mk-sys.cz>
References: <694766b15cfa3759e3686145417952d320029390.1631877302.git.mkubecek@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <694766b15cfa3759e3686145417952d320029390.1631877302.git.mkubecek@suse.cz>
Precedence: bulk

On Fri, Sep 17, 2021 at 01:20:18PM +0200, Michal Kubecek wrote:
> Function nintendo_otp_probe() calls devm_ioremap_resource() which is only
> available if CONFIG_HAS_IOMEM is enabled. Add a kconfig dependency like
> other similar drivers have.
> 
> Fixes: 3683b761fe3a ("nvmem: nintendo-otp: Add new driver for the Wii and Wii U OTP")
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>

A note: the build failure was already reported in

  https://lore.kernel.org/all/202108250657.h5CWR7Xf-lkp@intel.com/

Michal

> ---
>  drivers/nvmem/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
> index 39854d43758b..fb4005df86c0 100644
> --- a/drivers/nvmem/Kconfig
> +++ b/drivers/nvmem/Kconfig
> @@ -108,6 +108,7 @@ config MTK_EFUSE
>  	  will be called efuse-mtk.
>  
>  config NVMEM_NINTENDO_OTP
> +	depends on HAS_IOMEM
>  	tristate "Nintendo Wii and Wii U OTP Support"
>  	help
>  	  This is a driver exposing the OTP of a Nintendo Wii or Wii U console.
> -- 
> 2.33.0
>