Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210825082251.2484-1-caihuoqing@baidu.com>
In-Reply-To: <20210825082251.2484-1-caihuoqing@baidu.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Fri, 17 Sep 2021 08:50:55 -0300
Message-ID: <CAOMZO5DKGv1GQBpwr0ff0YC1yDmCH2A5Xpq7jzUA2h75bmN6eQ@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: freescale: Add helper dependency on COMPILE_TEST
To:     Cai Huoqing <caihuoqing@baidu.com>
Cc:     Dong Aisheng <aisheng.dong@nxp.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Stefan Agner <stefan@agner.ch>,
        Linus Walleij <linus.walleij@linaro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Cai,

On Wed, Aug 25, 2021 at 5:23 AM Cai Huoqing <caihuoqing@baidu.com> wrote:
>
> it's helpful for complie test in other platform(e.g.X86)
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
>  drivers/pinctrl/freescale/Kconfig | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
> index 21fa21c6547b..defc1f38efc7 100644
> --- a/drivers/pinctrl/freescale/Kconfig
> +++ b/drivers/pinctrl/freescale/Kconfig
> @@ -119,28 +119,28 @@ config PINCTRL_IMX7ULP
>
>  config PINCTRL_IMX8MM
>         tristate "IMX8MM pinctrl driver"
> -       depends on ARCH_MXC
> +       depends on ARCH_MXC || (COMPILE_TEST && OF)
>         select PINCTRL_IMX

I am not sure why you need the && OF, as we have a "select PINCTRL_IMX",
that already depends on OF.

Also, why was PINCTRL_IMX8DXL not updated?

Thanks