Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210830172627.267989-1-bigeasy@linutronix.de> <20210830172627.267989-3-bigeasy@linutronix.de>
In-Reply-To: <20210830172627.267989-3-bigeasy@linutronix.de>
From:   Dmitry Vyukov <dvyukov@google.com>
Date:   Fri, 17 Sep 2021 16:37:00 +0200
Message-ID: <CACT4Y+YsrcejyF-VZ5OGtk-diwHtVEJU0Yhipfomur5HTCc=Zg@mail.gmail.com>
Subject: Re: [PATCH 2/5] Documentation/kcov: Define `ip' in the example.
To:     Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc:     kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Steven Rostedt <rostedt@goodmis.org>,
        Marco Elver <elver@google.com>,
        Clark Williams <williams@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 30 Aug 2021 at 19:26, Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
>
> The example code uses the variable `ip' but never declares it.
>
> Declare `ip' as a 64bit variable which is the same type as the array
> from which it loads its value.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Acked-by: Dmitry Vyukov <dvyukov@google.com>

> ---
>  Documentation/dev-tools/kcov.rst | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/dev-tools/kcov.rst b/Documentation/dev-tools/kcov.rst
> index 347f3b6de8d40..d83c9ab494275 100644
> --- a/Documentation/dev-tools/kcov.rst
> +++ b/Documentation/dev-tools/kcov.rst
> @@ -178,6 +178,8 @@ Comparison operands collection
>         /* Read number of comparisons collected. */
>         n = __atomic_load_n(&cover[0], __ATOMIC_RELAXED);
>         for (i = 0; i < n; i++) {
> +               uint64_t ip;
> +
>                 type = cover[i * KCOV_WORDS_PER_CMP + 1];
>                 /* arg1 and arg2 - operands of the comparison. */
>                 arg1 = cover[i * KCOV_WORDS_PER_CMP + 2];
> --
> 2.33.0
>