Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210910130954.1392104-1-lucjan.lucjanov@gmail.com>
In-Reply-To: <20210910130954.1392104-1-lucjan.lucjanov@gmail.com>
From:   =?UTF-8?Q?Piotr_G=C3=B3rski?= <lucjan.lucjanov@gmail.com>
Date:   Fri, 17 Sep 2021 17:07:06 +0200
Message-ID: <CAL2Yj0QvoNZ3VeYfk63oMUTenP3eypJx+fB6f09rprV-fCphGw@mail.gmail.com>
Subject: Re: [PATCH] kbuild: use smaller dictionary size for zstd module compression
To:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc:     Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Michal Marek <michal.lkml@markovi.net>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Ping...

pt., 10 wrz 2021 o 15:10 Piotr Gorski <lucjan.lucjanov@gmail.com> napisa=C5=
=82(a):
>
> By default, zstd without parameters uses a dictionary size of 8 MB.
> However, most modules are much smaller than that.
> Use a dictionary size of 2 MB for module compression, resulting in
> slightly higher compression speed while still maintaining a good
> compression ratio.
> The --zstd=3Dwlog=3D21 option is equivalent to --lzma2=3Ddict=3D2MiB used=
 in XZ compression.
>
> Signed-off-by: Piotr Gorski <lucjan.lucjanov@gmail.com>
> ---
>  scripts/Makefile.modinst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst
> index ff9b09e4cfca..c3475e5aca7c 100644
> --- a/scripts/Makefile.modinst
> +++ b/scripts/Makefile.modinst
> @@ -97,7 +97,7 @@ quiet_cmd_gzip =3D GZIP    $@
>  quiet_cmd_xz =3D XZ      $@
>        cmd_xz =3D $(XZ) --lzma2=3Ddict=3D2MiB -f $<
>  quiet_cmd_zstd =3D ZSTD    $@
> -      cmd_zstd =3D $(ZSTD) -T0 --rm -f -q $<
> +      cmd_zstd =3D $(ZSTD) --zstd=3Dwlog=3D21 -T0 --rm -f -q $<
>
>  $(dst)/%.ko.gz: $(dst)/%.ko FORCE
>         $(call cmd,gzip)
> --
> 2.33.0.142.ge0a2f5cbc5
>