Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210917035736.3934017-1-chenhuacai@loongson.cn>
 <20210917035736.3934017-22-chenhuacai@loongson.cn> <YUQygKWFMU8zrkFi@infradead.org>
In-Reply-To: <YUQygKWFMU8zrkFi@infradead.org>
From:   Huacai Chen <chenhuacai@gmail.com>
Date:   Fri, 17 Sep 2021 14:40:38 +0800
Message-ID: <CAAhV-H65YPaDYTb4EyzezSHOXtdiVmhz6qMhc1HwSYHqjV6w6g@mail.gmail.com>
Subject: Re: [PATCH V3 21/22] LoongArch: Add Non-Uniform Memory Access (NUMA) support
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Huacai Chen <chenhuacai@loongson.cn>,
        Arnd Bergmann <arnd@arndb.de>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Airlie <airlied@linux.ie>,
        Jonathan Corbet <corbet@lwn.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-arch <linux-arch@vger.kernel.org>,
        linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Xuefeng Li <lixuefeng@loongson.cn>,
        Yanteng Si <siyanteng@loongson.cn>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi, Christoph,

On Fri, Sep 17, 2021 at 2:17 PM Christoph Hellwig <hch@infradead.org> wrote:
>
> > +/*
> > + * We extract 4bit node id (bit 44~47) from Loongson-3's
> > + * 48bit physical address space and embed it into 40bit.
> > + */
> > +
> > +static int node_id_offset;
> > +
> > +static dma_addr_t loongson_phys_to_dma(struct device *dev, phys_addr_t paddr)
> > +{
> > +     long nid = (paddr >> 44) & 0xf;
> > +
> > +     return ((nid << 44) ^ paddr) | (nid << node_id_offset);
> > +}
> > +
> > +static phys_addr_t loongson_dma_to_phys(struct device *dev, dma_addr_t daddr)
> > +{
> > +     long nid = (daddr >> node_id_offset) & 0xf;
> > +
> > +     return ((nid << node_id_offset) ^ daddr) | (nid << 44);
> > +}
> > +
> > +static struct loongson_addr_xlate_ops {
> > +     dma_addr_t (*phys_to_dma)(struct device *dev, phys_addr_t paddr);
> > +     phys_addr_t (*dma_to_phys)(struct device *dev, dma_addr_t daddr);
> > +} xlate_ops;
> > +
> > +dma_addr_t phys_to_dma(struct device *dev, phys_addr_t paddr)
> > +{
> > +     return xlate_ops.phys_to_dma(dev, paddr);
> > +}
> > +
> > +phys_addr_t dma_to_phys(struct device *dev, dma_addr_t daddr)
> > +{
> > +     return xlate_ops.dma_to_phys(dev, daddr);
> > +}
>
> Please don't add unused indirections.  Also please just use the generic
> translations
OK, I will simplify thi by removing indirections.

Huacai
>