Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] arm64: dts: ti: k3-am65: Relocate thermal-zones to SoC
 specific location
To:     Nishanth Menon <nm@ti.com>, Rob Herring <robh+dt@kernel.org>,
        Tero Kristo <kristo@kernel.org>,
        Vignesh Raghavendra <vigneshr@ti.com>
CC:     <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Amit Kucheria <amit.kucheria@linaro.org>
References: <20210916181801.32588-1-nm@ti.com>
From:   "J, KEERTHY" <j-keerthy@ti.com>
Message-ID: <2afceb2e-e076-1261-4db4-1afd1f00f78f@ti.com>
Date:   Fri, 17 Sep 2021 09:13:53 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20210916181801.32588-1-nm@ti.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/16/2021 11:48 PM, Nishanth Menon wrote:
> When commit 64f9147d914d ("arm64: dts: ti: am654: Add thermal
> zones") introduced thermal-zones for am654, it defined as under the
> common am65-wakeup bus segment, when it is am654 specific (other SoC
> spins can have slightly different thermal characteristics). Futher,
> thermal-zones is introduced under simple-bus node, when it has no
> actual register or base address.
> 
> So, move it to it's rightful place under am654 SoC dtsi under the base
> node.

Reviewed-by: Keerthy <j-keerthy@ti.com>

> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> 
> NOTE:
> 1. This is a cosmetic fixup, so skip the "Fixes" tag.
> 2. This fixes up noisy dtbs_check warning around thermal.
> 
>   arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 4 ----
>   arch/arm64/boot/dts/ti/k3-am654.dtsi       | 4 ++++
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> index 9d21cdf6fce8..9c69d0917f69 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> @@ -100,8 +100,4 @@ wkup_vtm0: temperature-sensor@42050000 {
>   		power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
>   		#thermal-sensor-cells = <1>;
>   	};
> -
> -	thermal_zones: thermal-zones {
> -		#include "k3-am654-industrial-thermal.dtsi"
> -	};
>   };
> diff --git a/arch/arm64/boot/dts/ti/k3-am654.dtsi b/arch/arm64/boot/dts/ti/k3-am654.dtsi
> index f0a6541b8042..a89257900047 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am654.dtsi
> @@ -112,4 +112,8 @@ msmc_l3: l3-cache0 {
>   		compatible = "cache";
>   		cache-level = <3>;
>   	};
> +
> +	thermal_zones: thermal-zones {
> +		#include "k3-am654-industrial-thermal.dtsi"
> +	};
>   };
>