Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp2476139pxb; Fri, 17 Sep 2021 10:33:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKSDoUwhVSeXT3+XIzRO07OpHpKTGzlSEik6KmhNNnVpkEsaLvjl2H2E50fZBqaQiE0tcq X-Received: by 2002:a50:8d5b:: with SMTP id t27mr13798112edt.316.1631900007602; Fri, 17 Sep 2021 10:33:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631900007; cv=none; d=google.com; s=arc-20160816; b=C780tvMPhNjdcebVJc8N+aO4JvLNGXjNeWkSj3HzJ5uHheLsRdOS1FJqrtJ7yMIRQ8 8KI+oRxCIa8kiwY4UyBMxYAIdii2QjpECbWfa7OymX7vxigiC1hYqmCwrXAk5VjXwXUB xZPwnY+yPwgKyzT+XakLqTogYIBo0BOcXOcDFD2/Gjdor+s8yLu62TUxSR0QxODxuJOb 0sbQl2l11AZQtUD+Kytpt3mgAdEEq3h56gBZY75zkSDKj2GFS+K+uXA3DX1aPImpVTVW STlrVrjxztW8FoYkzDDWVr/hrzrhjklzz8KbPCJjrx+UwtfMxAQ7NmuLX53tDf/FpU+M 3Mng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=ZKHhczD4ZPOnkjIr1F9uI5astUnlALC1U4GQ2QogJ4A=; b=mxjB/ABSjLxKjUWHMfzGaY9+90dLTf9g4RcGU3ltYM6JMSkbP13nrYpo06L3tqN3V9 cGiuUc9HIDfuLfFpePCHZmcZG7lloOXHUbabexYIHhl+Dyk/WrprCgpuPRuIO3kQpnsx YGCeP6fvXpWwlobiPE+DFRSaiVCsYqh7dTaWnXUV/o/lT8EoujE8Ks+CYdG9PzvbUlBy gGbVLW+ZwHMzmEoNU+yI72V6rpEFMOOxwJd3SHIqZ5imzQc6L8OBewtNQ+NfU24/doKm w+JTlEd14jp7/6UNUpfWJ5E2FL1+X+qL9v9yR8r5XjimaECcwK0Q2eReQUllaZDPxr5N +RdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b="Hduyuvy/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bf24si7336391edb.7.2021.09.17.10.33.00; Fri, 17 Sep 2021 10:33:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b="Hduyuvy/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241020AbhIQHhM (ORCPT + 99 others); Fri, 17 Sep 2021 03:37:12 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:60512 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238827AbhIQHhM (ORCPT ); Fri, 17 Sep 2021 03:37:12 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id ADB7D222B6; Fri, 17 Sep 2021 07:35:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1631864149; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZKHhczD4ZPOnkjIr1F9uI5astUnlALC1U4GQ2QogJ4A=; b=Hduyuvy/zqiHGyOIMu8VzzY/CaPM184syRBOs72yGbDPM1sUL/f7/NqXtk8f1LCSdG2VMC X54UG3PvLZHpHA5vdPbDHSq41Tn3SxeQLsA5lv9+RimiNVcWBW0CWXBZUoCYgvIxhAmOgp 7gl1wpkoktmjOkauvsCGjHIfTR5F+b0= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 877BF13A78; Fri, 17 Sep 2021 07:35:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dEy6H1VFRGGBGgAAMHmgww (envelope-from ); Fri, 17 Sep 2021 07:35:49 +0000 Subject: Re: [PATCH] Xen/gntdev: don't ignore kernel unmapping error To: Jan Beulich , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" References: From: Juergen Gross Message-ID: <6d5cc143-0436-a2da-c3f4-ee7a2cec840c@suse.com> Date: Fri, 17 Sep 2021 09:35:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="L2IepqGuXH9lYRXao45ZswOeYQCpW1c6r" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --L2IepqGuXH9lYRXao45ZswOeYQCpW1c6r Content-Type: multipart/mixed; boundary="HSlCyNwh3btw6jZ5G6b21xIga5DV9TQlY"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Message-ID: <6d5cc143-0436-a2da-c3f4-ee7a2cec840c@suse.com> Subject: Re: [PATCH] Xen/gntdev: don't ignore kernel unmapping error References: In-Reply-To: --HSlCyNwh3btw6jZ5G6b21xIga5DV9TQlY Content-Type: multipart/mixed; boundary="------------4F6AC4DCD1F519DE870AA7BC" Content-Language: en-US This is a multi-part message in MIME format. --------------4F6AC4DCD1F519DE870AA7BC Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 17.09.21 08:13, Jan Beulich wrote: > While working on XSA-361 and its follow-ups, I failed to spot another > place where the kernel mapping part of an operation was not treated the= > same as the user space part. Detect and propagate errors and add a 2nd > pr_debug(). >=20 > Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross Juergen --------------4F6AC4DCD1F519DE870AA7BC Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------4F6AC4DCD1F519DE870AA7BC-- --HSlCyNwh3btw6jZ5G6b21xIga5DV9TQlY-- --L2IepqGuXH9lYRXao45ZswOeYQCpW1c6r Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFERVQFAwAAAAAACgkQsN6d1ii/Ey8H Fwf+KrAQ9n9MPSoUb2ScP9E4CRU4amw9nl4bj1ssmF60xOsQOzr0rAwpkCDw3T2MToD4jkG8f798 UPYPCV3p3GGOkh+xfDNT2d/zU/YTKRAM5Rq4oV1GM06p+pA6hrGqoAoCod4+eNh0GBxsjbP9Y9ak Rb60PTugVjx1DKhxNLj5kKA95phc61OswV65iD73tBb9KgBBrXGj3S+mcePxWqc4z4LNEV+LNzVj lCUt72zEcRvGIq2Sl6qDV3wwUcEb5GXyx36M2ka75wHpr+Vv0iwZVvLU1uMq9Mdgd2crzhgwyQca t3KwSQwFx4fJNiOYORov75GGLrxxjGbbWRmWCWQrYA== =0RKF -----END PGP SIGNATURE----- --L2IepqGuXH9lYRXao45ZswOeYQCpW1c6r--