Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Qing Wang <wangqing@vivo.com>, Vinod Koul <vkoul@kernel.org>,
        dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1631863081-10231-1-git-send-email-wangqing@vivo.com>
From:   Logan Gunthorpe <logang@deltatee.com>
Message-ID: <eeaee4a8-12d4-fb1d-bd4d-9cb3a60a3432@deltatee.com>
Date:   Fri, 17 Sep 2021 09:20:24 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <1631863081-10231-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-CA
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] dma: plx_dma: switch from 'pci_' to 'dma_' API
Precedence: bulk


On 2021-09-17 1:18 a.m., Qing Wang wrote:
> The wrappers in include/linux/pci-dma-compat.h should go away.
> 
> The patch has been generated with the coccinelle script below.
> expression e1, e2;
> @@
> -    pci_set_dma_mask(e1, e2)
> +    dma_set_mask(&e1->dev, e2)
> 
> @@
> expression e1, e2;
> @@
> -    pci_set_consistent_dma_mask(e1, e2)
> +    dma_set_coherent_mask(&e1->dev, e2)
> 
> While at it, some 'dma_set_mask()/dma_set_coherent_mask()' have been
> updated to a much less verbose 'dma_set_mask_and_coherent()'.
> 
> This type of patches has been going on for a long time, I plan to 
> clean it up in the near future. If needed, see post from 
> Christoph Hellwig on the kernel-janitors ML:
> https://marc.info/?l=kernel-janitors&m=158745678307186&w=4
> 
> Signed-off-by: Qing Wang <wangqing@vivo.com>

Looks good to me. Thanks.

Reviweed-by: Logan Gunthorpe <logang@deltatee.com>