Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Colin Foster <colin.foster@in-advantage.com>
To:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Vladimir Oltean <vladimir.oltean@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH v3 net 0/2] ocelot phylink fixes
Date:   Fri, 17 Sep 2021 08:39:03 -0700
Message-Id: <20210917153905.1173010-1-colin.foster@in-advantage.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DcZ1WT7Q5iZBD1J1GZ4cAer+q1LUjXT33DR25Xp6GA1u//TzzrrqolUVFisF?=
 =?us-ascii?Q?3B3mV2EXGOsBzqon3p9iz2w7uxilRWQ3AZaso/8+eG2Z92bE6Y7uF543RmOD?=
 =?us-ascii?Q?BjHM6Wh3Fg6wFCirqIa3ST/KcLWCIdpRKK1//QwLrRk8FP5Eh7TGQRG2wtfR?=
 =?us-ascii?Q?jvFhuXblLNzooNIhCQ7A/Zp7uY6QDlnZTBJUterMHLQIG7PNWw7wmO6veoEo?=
 =?us-ascii?Q?NNve2C3tnege4XzQ8Wty/scMIX5JPCzmsMKtHxOO5/zfuJRA0dsezcjCzUAF?=
 =?us-ascii?Q?eablR74rHq5T8RCZ1e6pIpVsbqoywzaSz05MnKHIQyw8j55UzAS43qDPHXAL?=
 =?us-ascii?Q?R3ZPPs8ttE/X8fng6qsFLqAaIa8gu3FWbHRWt97pGJIjFKZsxMRkcO7xpIDI?=
 =?us-ascii?Q?HkKva5fpxutnx+mi/j05zsFtVO1uUi+XOgO+5Iq7DpG+MgYzbd+HWG1ZZ7OI?=
 =?us-ascii?Q?CbPOAR+IUebbJv1joJitMntW4yqHx2EWP+XxlqIVpdR+zqWhAo0QG97vKtcY?=
 =?us-ascii?Q?jGpBRLwxUsSpCkQPXLPkygjZLEDJCOILi5CgWZYOa7XJ4JYt49MaCc0hWjFo?=
 =?us-ascii?Q?TGnmq/3jjXcCAxv1cj/xKK1lN7aMyFazjO+7KqMH8mk4hTYnsPywUUe8FSuA?=
 =?us-ascii?Q?Iga1cxdcQSqa7+5qwPlWocYiCc8wad3RzjLnNEJfMasJFs17p0dkj/p5/Gtf?=
 =?us-ascii?Q?GCU+A85JISHwfADofNb7JNUEoecv6Z1kI0D3153ZYbgVeQTb8voXJO4KWAoe?=
 =?us-ascii?Q?aJddGFCfgez1HcUCpC1Y9G0merghg/RMXC+Y9ulHVHO7i/ydiBKWyaSKsSQN?=
 =?us-ascii?Q?ETFEAiKgzJ/r1OsW+Nti9QgcK57iDKJmfCY0LAZFJd9yRln8fCUypxKbw9yA?=
 =?us-ascii?Q?35rD3khJ/R1WTiQ76zW9AfYMe1TyAXqlY9mh9JhQL1CIfPgnAgaAT/Ih/PQq?=
 =?us-ascii?Q?6vJp9yOT0vPTZYi0ZcDT/oLcCMhoC2f4eYdq1RuoIP4XTV+F93o8vQjRQXTC?=
 =?us-ascii?Q?P2W31LSOBMqaSscAnKzohFnvjKVuCBq/fnaNShh9y6g1Ryl7RrhLoAgYHXTV?=
 =?us-ascii?Q?+b/ZhFzLIldCgahoWFJj5oEjIgM1QLxGpypeFiPI7qgKN8hLKafl3fT2IHTC?=
 =?us-ascii?Q?uWeEhknD45rChvTHeNV6v5AURqeusIg7lHo84PtPlG4N7X+5DhqVbWZ8uypY?=
 =?us-ascii?Q?aSw7SS9qtuMmcHnlKJYVBllMbZhwUAiVjFUb5AToszB6oFmLczM8WmiufLDd?=
 =?us-ascii?Q?UQLJWDnA8UZOXCMxjsLoUR/2phDWUUPgOyTxflVN+0wvxth9PdEXwBk3sNbl?=
 =?us-ascii?Q?ujH/KzvEtbWL0d7OnD50oqQ4?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b58a59a9-9f92-4d3c-a862-08d979f14fc5
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2021 15:39:18.4247
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IJJ8jXEBXIOFh3qBpMP4nVanudHw7TUCvUVBOadbztFz6ZpbF3LGIYFQIW9ud/+zgxGcRCB5IgwslG5B4HSZPmnpsxVco1eIhyfTB2c+b8Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1933
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When the ocelot driver was migrated to phylink, e6e12df625f2 ("net: 
mscc: ocelot: convert to phylink") there were two additional writes to
registers that became stale. One write was to DEV_CLOCK_CFG and one was
to ANA_PFC_PCF_CFG.

Both of these writes referenced the variable "speed" which originally
was set to OCELOT_SPEED_{10,100,1000,2500}. These macros expand to
values of 3, 2, 1, or 0, respectively. After the update, the variable
speed is set to SPEED_{10,100,1000,2500} which expand to 10, 100, 1000,
and 2500. So invalid values were getting written to the two registers,
which would lead to either a lack of functionality or undefined
funcationality.

Fixing these values was the intent of v1 of this patch set - submitted
as "[PATCH v1 net] net: ethernet: mscc: ocelot: bug fix when writing MAC
speed"

During that review it was determined that both writes were actually
unnecessary. DEV_CLOCK_CFG is a duplicate write, so can be removed
entirely. This was accidentally submitted as as a new, lone patch titled 
"[PATCH v1 net] net: mscc: ocelot: remove buggy duplicate write to 
DEV_CLOCK_CFG". This is part of what is considered v2 of this patch set.

Additionally, the write to ANA_PFC_PFC_CFG is also unnecessary. Priority
flow contol is disabled, so configuring it is useless and should be
removed. This was also submitted as a new, lone patch titled "[PATCH v1 
net] net: mscc: ocelot: remove buggy and useless write to ANA_PFC_PFC_CFG".
This is the rest of what is considered v2 of this patch set.


v3
Identical to v2, but fixes the patch numbering to v3 and submitting the
two changes as a patch set.

v2
Note: I misunderstood and submitted two new "v1" patches instead of a
single "v2" patch set.
- Remove the buggy writes altogher


Colin Foster (2):
  net: mscc: ocelot: remove buggy and useless write to ANA_PFC_PFC_CFG
  net: mscc: ocelot: remove buggy duplicate write to DEV_CLOCK_CFG

 drivers/net/ethernet/mscc/ocelot.c | 10 ----------
 1 file changed, 10 deletions(-)

-- 
2.25.1