Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Hao Chen <chenhaoa@uniontech.com>
CC:     <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
        <kuba@kernel.org>, <intel-wired-lan@lists.osuosl.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20210917141146.5822-1-chenhaoa@uniontech.com>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [net-next,v1] net: e1000e: solve insmod 'Unknown symbol
 mutex_lock' error
Message-ID: <20c47a57-e7d7-d791-5c86-e27310672789@intel.com>
Date:   Fri, 17 Sep 2021 09:01:42 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210917141146.5822-1-chenhaoa@uniontech.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0ZFcUx4QkpRQ1JZUWtSa3NLL2cycUFRaW50QWNzQ2JndkNieUl2VFlNNjl2?=
 =?utf-8?B?NVB2NGl0L2VTRWsrS3N1TkRVcDdmTW1NbGRMdkV6WjNxWEtmKzVYRnRHZ1FY?=
 =?utf-8?B?UzZGSHZJOU0rcGd1TGozZzlBMHpOeURScTFwTk9uTnBjTFhJMzBPbDRNWStK?=
 =?utf-8?B?RXd2QVozTjh1cnV0VjFaVmhja1czUjN5R3BrTE5oSUpKWkg1a1NWYWgrU3Jp?=
 =?utf-8?B?UE9jMkpQNTRWVk9VOGx1aXFaTVJZdWlDUFAxVG5sbkdYeUl1U3hlT0Y3eVpZ?=
 =?utf-8?B?UFR3UjlwU0lZQ1ZQQlNWZk9ZR3Y1MXMvRk94bE40NFpVNk9tT0xrYVN0NWFD?=
 =?utf-8?B?V3ZBTlUzM2ltVnhrY0VIZEd3bnhOdHhKbjNFaUdYMmpQUHowbFJBODdkWFhR?=
 =?utf-8?B?T2hhUFl0elNLN3pacDZsNnFPNVcxV3ZjdU9HQmIrZWFOYkpISExia1lUWlg2?=
 =?utf-8?B?Sk45ZWNtUFlaL2ViakN2ajlMMDJ6bTdnd2pZMFVIbTBKNjRwQkFBSXdWWVpQ?=
 =?utf-8?B?dkdvKzU1WUQvaGpZVUhlUGQ0SjJka2hDSkxqR1o4VEhBWUx6OVdGT01wYnha?=
 =?utf-8?B?amlUT1lucUZ1ODd3TGdadEFIdSszVFZlM0hVM0VJelhWcnJrTWtSTUQxRDl4?=
 =?utf-8?B?ZGRxaklJeWtyenZubk1GM0RPNkJVSFkrTkN6MVFjeVljSWpqT25IaWM3TGlW?=
 =?utf-8?B?ZjlueVJuZXlSREIwMzhDd2VyNWxNTzdmSXg1cHZpYUR2ZHI4UmJHbFpOS1R1?=
 =?utf-8?B?Mlo4OTIveFdNWWphRGY2M3B6Wm0wbUM2RmFjQjN5ZkExcitSNWlsUHdrcURQ?=
 =?utf-8?B?amNuaEkweTVNeEtVRVFVRlBYOTh1RENHTTdXdWcyem85U2p6MDVlYVV0L0pq?=
 =?utf-8?B?R0s4VUxNd0hBc3BONVJtOXlvM3l5aExOaVN3bFhWdGpFS3lCS1VXTTFuL2Mv?=
 =?utf-8?B?RVB3WnFFaGducGJhejlXcjFzT3A4b2RvSEJ1Mjg2eHpCbWRXTmVyWDhlMi9i?=
 =?utf-8?B?T1NGWkZpQWwwT0YzSGVKSHFOOHgxMnBVWlFyOGtZUmxyRWhOSlRoZ2FreWFl?=
 =?utf-8?B?TWYwQ1lRU1ZkWEpJRElHZEhyd1NXQmZWRDJOT1IwQk9QUTRKcG9BVU1YWGFs?=
 =?utf-8?B?SSsvRlgxOWlheDVMREs0bnlqZmxLai9kQUdIT0VlUG13emlIdjNYNWcvMnZH?=
 =?utf-8?B?bjF0QmhOck4rdXFST21HdjlBZmJrTDZCUXZ4OGlZT2hBeFBmQWlDQ3ZKVmxk?=
 =?utf-8?B?NXFNbXpTakpDemVUbFFuUWhDVFV5QWNqT2VaMzh0RE43dlIzc1NPQWRKcEg3?=
 =?utf-8?B?NW04K0RFVFJnK3NxVkhlZEVrbmRDenM4elpyZEc4aHQxNEdMc3Rvcmp2ZHly?=
 =?utf-8?B?YmJBbHArRFdQSWFJekx0WmM2ZmM4dmMxeHg2ZncwdXBDWGxoNmZ2R2l2RHRM?=
 =?utf-8?B?Q0d4NlZvSWk2VVFOVkRQTVhGbzJIUkg5Qml1SXJjSVdZVGxFeVE3QW0zVTNZ?=
 =?utf-8?B?RGlyek84NlpzRWEvR0RvU21sUlp4V0Exc2NELzY4SUhhNVdyV0ZSVzcrTFda?=
 =?utf-8?B?WEVvcnNEQUZzOHMyTmtYNjR6cERLZ2xobUYwRFZGWHZsdEt3ZHY0d0FSM3dq?=
 =?utf-8?B?eVhiTnkyT1lqMkRwRWphVGFVODB2R2YwOTUwU1pDYWFkWGkxRmtzMnd4bHRH?=
 =?utf-8?B?UVZ1WkUxc2JNTVVrZGNqUmZQNXFhQmNzeVJ5aStKRE00SWVBVzU4b3N6WGxP?=
 =?utf-8?Q?ZV/0l6aNmN9stPQ263G5P8q2cW3s4CPvCLcfmA3?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7332d140-7103-424a-83c0-08d979f4724a
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2021 16:01:44.7098
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oWQ85ws2EkM8Xtn/EmBi3+9HHQRQkk4uAdZDV3dzYo1NCxawSpQJutzO62n6i/fTHClRU2O6iuT5SjOYAZoNh7Tm8ZMonVcRPw50QC1VEf8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2317
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/17/2021 7:11 AM, Hao Chen wrote:
> After I turn on the CONFIG_LOCK_STAT=y, insmod e1000e.ko will report:
> [    5.641579] e1000e: Unknown symbol mutex_lock (err -2)
> [   90.775705] e1000e: Unknown symbol mutex_lock (err -2)
> [  132.252339] e1000e: Unknown symbol mutex_lock (err -2)
> 
> This problem fixed after include <linux/mutex.h>.

Thanks for taking the time to send a patch.
Why do you think including a file will fix this? That error is usually
the user's fault for trying to use insmod which doesn't check module
dependencies.

The advice I usually give is to try modprobe instead, does the problem
still occur without this patch and just using modprobe?