Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <3cf9bb7f-618e-4e4b-32d6-4d3c207b9a9a@nvidia.com>
Date:   Fri, 17 Sep 2021 17:30:16 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.0
Subject: Re: [PATCH] mm/debug: sync up latest migrate_reason to
 migrate_reason_names
Content-Language: en-US
To:     Weizhao Ouyang <o451686892@gmail.com>,
        "Huang, Ying" <ying.huang@intel.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Pavel Tatashin <pasha.tatashin@soleen.com>,
        Oscar Salvador <osalvador@suse.de>,
        Yang Shi <shy828301@gmail.com>, Zi Yan <ziy@nvidia.com>,
        Dave Hansen <dave.hansen@linux.intel.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20210917061432.323777-1-o451686892@gmail.com>
 <871r5nptt7.fsf@yhuang6-desk2.ccr.corp.intel.com>
 <89a06743-b37a-b85a-1c04-5d863a1d2cb4@gmail.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <89a06743-b37a-b85a-1c04-5d863a1d2cb4@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RjFrY0tRU09LU3RzSXVMdW9aVzNRK2k5Z1lzYi9ITllGVnRyaDlFb1dDYXVG?=
 =?utf-8?B?QksydkNscncxZkVURDNxVSt0bFovY3ZRMVd2S20rRzkyWDEvU3QwdWcvTWJs?=
 =?utf-8?B?cXVKTDZLSFFnT2ZNdUE5Ymppc2s5VkliU1k2K0FWaDBHaWFqZmtZV1JWLzho?=
 =?utf-8?B?Z00rUDhsRExJTGsrNFZHT2R6L2NUYU5ScEEwRWVhQTFvQTZQLzhhUjRBTnVn?=
 =?utf-8?B?eHRkY21WYkd1ekE1YzBGdXI1Q3N1TURTM01kS3RPbFRDMFpOVUxFY3RsUXNt?=
 =?utf-8?B?Z09uU01kZEdIdnpzbE9SUXJ0RTAyMFBUWksxWFdwOXRiSXlkdTdOQS92OTZi?=
 =?utf-8?B?cG5oRmdVU2NlNytEaTZ3RnJ6RVlVUGQ3bWVBYXR6OW9rWnVUSDc3MkFRelR5?=
 =?utf-8?B?OTBYdThTSSt0dDBTVU55eHhSYWdIdVRvZzVYU1EyTjVaOWVQTlp4OXc1bHhJ?=
 =?utf-8?B?K3IvRFZlQ0UxaEdaR2doSU9KNUtPTE01Y0VILytBNTl5OFE5VDVFMjhpS0tL?=
 =?utf-8?B?dHZxY25SUDYyWGlqRmUvVENwSHhBS3pxQmF0QmNSelhwVmlpdDhZUklod2N4?=
 =?utf-8?B?eGJ2QVdBSXBwdDFvVXFQd2o3K1RNbjdmY2JRVkpFa0psYVorbWpOaTFMUnBF?=
 =?utf-8?B?MldydklacHlUQzk1RVRQeVQ1MHNrSnpjRzN6R242ZXRLZmtPejUyd0dGRmhr?=
 =?utf-8?B?RmpuTlcrREdBVzRlK3BDYUVIVC9iUEFuUFVZa0RpRmJ5bnBqajRNS3FiMVNx?=
 =?utf-8?B?d3VicVRmN2VVQmkvWU9TNDJMY2dITTVBM3VHNHN2dDN5VnpISWRnR2tYUE55?=
 =?utf-8?B?Sk0vRWZDeThLcXB1TjVHeWVHRXVZOWFnQ0J1Sk9OajhIT3RjNTZ2SkUrVkQ0?=
 =?utf-8?B?dFc0anFaeEhnVG5YWGhpTjhJSFdtblZISVZzYjQ5OEM0V0pEZnFKSmkweGVr?=
 =?utf-8?B?bWl1VGJnYUcyNlI0Y2t6Ym1VUXVDbHF6cVlUcWViZ2pzNkNvc2NoUk93NUJr?=
 =?utf-8?B?WnNkVi9UcW5rMGRXUEFOMW00a2Z5dk5Sd2RqSjBmaE90dnp0dWErWW41QS8r?=
 =?utf-8?B?SFJhbWpaMkFxUnFWb09rVm1mZmN5RzdhUzdlZTNXVStGaE1FZFZOZWQ0dms4?=
 =?utf-8?B?d3luWnRwKzdLU0JGT0FhR2hHSm8zakVBK1ltY3ZlMkVTT3hxQUc3RDhrQTZE?=
 =?utf-8?B?QmJzemVkQSt0ZmZhM3JjSnFvRTJEYWZNSTlFcS9KRnpUWWNETmt5MW1YK1Fh?=
 =?utf-8?B?WFk2NVpMUlZMSmtLYjNncUZWdTE5a2piNjdsdjJ2SzluNWF2czNQMkhmcmRK?=
 =?utf-8?B?SE1MSHM2c0daekRrM1lJakZPaUlibmJSaGhwZ29XZGRqL0VUSkZXcktsRE1y?=
 =?utf-8?B?bVRIZUR4NFZ3ZTg3VHBoQ1FQTFpMQzNPczR1QzkwTVMva0NyRGhmT1c2d1E5?=
 =?utf-8?B?MkhMOGgzRjZhNTNaTHNUREo3WlcvbTBJc0NFb1Z1b2gxcVFzWGVJT0R0bm1i?=
 =?utf-8?B?MDgzTU1nMkliTmJ5WldKYVg0Q0J0SlJqSVBMNDlaSDg0cGZIQUZOeVhCSkw3?=
 =?utf-8?B?dFc2MlJlSTZnaUgwWjRHSXlKUkJEQkxGL3BoeStSU0VDL241RW12QW50MWhy?=
 =?utf-8?B?S29RWG9iS0dlMnJJdnRBbDViUUVxTEt2ZHYwUHRCN3NOVE5OYzN6Z3JlYytI?=
 =?utf-8?B?VmpwUi9XU1pwd2tHNktGRE11QXNLaWZvVVpFM1BrVytvelBrY0p0am9jM2Jp?=
 =?utf-8?Q?3Txp6KEJiT4S5/+FgIJohyGH/WRPeJqTJ12ZFu3?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c4e6bad-8bd9-49b9-7663-08d97a3b7d5b
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2021 00:30:17.6631
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fa3DmupUH0mTwL0MD+WYCaZfa6O1xqqXfk6gWZuugO9hbcCWuG0pYuBw/G3LO2lpq/bvR/BtkEEpj6LE4JZ5uw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3141
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/17/21 02:48, Weizhao Ouyang wrote:
...
>>>   const struct trace_print_flags pageflag_names[] = {
>> Good catch!  Thanks!
>>
>> Reviewed-by: "Huang, Ying" <ying.huang@intel.com>
>>
>> It may be better to use BUILD_BUG_ON() to capture similar issue earlier?
> 
> How about move migrate_reason_names into mm/page_owner.c and make it size uninitialized(get rid of MR_TYPES).
> Then use BUILD_BUG_ON(ARRAY_SIZE(migrate_reason_names != MR_TYPES)) to check it?
> 
A couple more thoughts:

1) From a naming and location point of view, migrate_reason_names[]
really doesn't want to be located in page_owner.c.

2) There are actually three places to synchronize, not two. And in fact,
sure enough, the MR_CONTIG_RANGE is already drifting out of synch: it
has a string of "cma" in mm/debug.c, versus "contig_range" in
include/trace/events/migrate.h.

So...is it possible to use the macro and enums in
include/trace/events/migrate.h, to define the connection between
migrate_reason and a string, everywhere?


thanks,
-- 
John Hubbard
NVIDIA