Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 18 Sep 2021 10:26:36 +0800
From:   Cai Huoqing <caihuoqing@baidu.com>
To:     Fabio Estevam <festevam@gmail.com>
CC:     Dong Aisheng <aisheng.dong@nxp.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Stefan Agner <stefan@agner.ch>,
        Linus Walleij <linus.walleij@linaro.org>, open list:
        GPIO SUBSYSTEM <linux-gpio@vger.kernel.org>, ;
        linux-kernel <linux-kernel@vger.kernel.org>
Illegal-Object: Syntax error in CC: address found on vger.kernel.org:
        CC:     ;linux-kernel <linux-kernel@vger.kernel.org>
                        ^-missing semicolon to end mail group, extraneous tokens in mailbox, missing end of mailbox
Subject: Re: [PATCH] pinctrl: freescale: Add helper dependency on COMPILE_TEST
Message-ID: <20210918022636.GA18195@LAPTOP-UKSR4ENP.internal.baidu.com>
References: <20210825082251.2484-1-caihuoqing@baidu.com>
 <CAOMZO5DKGv1GQBpwr0ff0YC1yDmCH2A5Xpq7jzUA2h75bmN6eQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAOMZO5DKGv1GQBpwr0ff0YC1yDmCH2A5Xpq7jzUA2h75bmN6eQ@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On 17 9月 21 08:50:55, Fabio Estevam wrote:
> Hi Cai,
> 
> On Wed, Aug 25, 2021 at 5:23 AM Cai Huoqing <caihuoqing@baidu.com> wrote:
> >
> > it's helpful for complie test in other platform(e.g.X86)
> >
> > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> > ---
> >  drivers/pinctrl/freescale/Kconfig | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
> > index 21fa21c6547b..defc1f38efc7 100644
> > --- a/drivers/pinctrl/freescale/Kconfig
> > +++ b/drivers/pinctrl/freescale/Kconfig
> > @@ -119,28 +119,28 @@ config PINCTRL_IMX7ULP
> >
> >  config PINCTRL_IMX8MM
> >         tristate "IMX8MM pinctrl driver"
> > -       depends on ARCH_MXC
> > +       depends on ARCH_MXC || (COMPILE_TEST && OF)
> >         select PINCTRL_IMX
> 
> I am not sure why you need the && OF, as we have a "select PINCTRL_IMX",
> that already depends on OF.
No, it's just an invalid dependency. PINCTRL_IMX can be selected without OF
opened.
> 
> Also, why was PINCTRL_IMX8DXL not updated?
Ok, I'll update all pinctrl IMX.
> 
> Thanks