Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp372470pxb; Sat, 18 Sep 2021 05:22:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwovt3401F8w1cvvCURnw7Pm2cxL0Mk7f0qRb/kk7L+Njcf06g4tHTpHZ8yQzNwWIdOV3NL X-Received: by 2002:a92:de41:: with SMTP id e1mr11772030ilr.85.1631967729960; Sat, 18 Sep 2021 05:22:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631967729; cv=none; d=google.com; s=arc-20160816; b=TyXayeGUzMCymC74FsnoUKrWwApwnrevlf6VVadZztVxMHOYGFLg9FDbAw8CeH9eE6 Bm1RdD3uaKgAgRaDz4vxLVJUGTIFk0im1tI5A1exdKrqGzrrSp7sxCjdS2HS2C3TmHHB mzJiAIM+CzoM4TIVJ+MaR8wfT+aW3uAT9m2RUqdzDewjz6cwU1PVDB80tP3iSJowBInj P2ldrS5CTSOwLNJpN+6VU6iBf3dwQMgIy1LWtPUSFqd+08xe53iZ/z393nGAEccwwL27 0Y5Nv4y1ytQWuJzCXznkUC4hov9KZsWAYnqPniib3uCnhMgmnT05WQRNGMTTB70tfflV QEXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=tIpz/vQt5m//qlOJB1Vj/w3Nj+YVa8d0qtyjrn/UxR0=; b=FYzm2t3+l0TUhCnhwynkMZcylUnGZYxqThni6Eq825QD+y2Kl119U0Sl8dn5zj2zhB 7s1T75XA0NBBC3/fjFcyPPO3v2xk1Lb6r9jTountZu3ZrK7ebiun+sHCQMygchbgXS6e 1Ty2w78QbnQXTB6T0O9YL+ePoOMPYf54EEJl5o9xDmEzJ6UtN+EG+kFMOBRcGWd6dOa2 HvJjQvUMkbOIaJrHM40AR7ruvxaiP3VA8YQhhEi7W4m1magQdYsHN0TDPc/kGh+tzUap OgFLi8meEyc4U2EEFzjI87+KOujFh5yG8v4SDkpFQ2DGwL29HwWHSrO0yoLKbqxqPXlN qTNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=BTDgERYz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f22si9105049jam.69.2021.09.18.05.21.56; Sat, 18 Sep 2021 05:22:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=BTDgERYz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232201AbhIRFNB (ORCPT + 99 others); Sat, 18 Sep 2021 01:13:01 -0400 Received: from out0.migadu.com ([94.23.1.103]:48041 "EHLO out0.migadu.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229956AbhIRFNB (ORCPT ); Sat, 18 Sep 2021 01:13:01 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1631941896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tIpz/vQt5m//qlOJB1Vj/w3Nj+YVa8d0qtyjrn/UxR0=; b=BTDgERYztcKOq3bzFmCITxI9zZtOajzzJoMmSLz83iIJS2QpG9AXp3MVq1LHghgSrTLrVx pq07bF+u1P7/V1jk3akyTQ73DK+mGjxVVFk3rzYgPI+IXDXxbiK8sWoxSX2kteKJySOvgH vhrji7rxlyBSkQd0U8DkdyZxGXC4ZKY= From: Jackie Liu To: rostedt@goodmis.org, mingo@redhat.com Cc: linux-kernel@vger.kernel.org, bristot@redhat.com, liu.yun@linux.dev Subject: [PATCH] tracing: fix missing osnoise tracer on max_latency Date: Sat, 18 Sep 2021 13:11:18 +0800 Message-Id: <20210918051118.1096575-1-liu.yun@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: liu.yun@linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jackie Liu The compiler warns when the data are actually unused: kernel/trace/trace.c:1712:13: error: ‘trace_create_maxlat_file’ defined but not used [-Werror=unused-function] 1712 | static void trace_create_maxlat_file(struct trace_array *tr, | ^~~~~~~~~~~~~~~~~~~~~~~~ [Why] CONFIG_HWLAT_TRACER=n, CONFIG_TRACER_MAX_TRACE=n, CONFIG_OSNOISE_TRACER=y gcc report warns. [How] Now trace_create_maxlat_file will only take effect when CONFIG_HWLAT_TRACER=y or CONFIG_TRACER_MAX_TRACE=y. In fact, after adding osnoise trace, it also needs to take effect. BTW, Fixed the conflicting defined comment information. Fixes: bce29ac9ce0b ("trace: Add osnoise tracer") Cc: Daniel Bristot de Oliveira Signed-off-by: Jackie Liu --- kernel/trace/trace.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 7896d30d90f7..d7e3ed82fafd 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -1744,11 +1744,7 @@ void latency_fsnotify(struct trace_array *tr) irq_work_queue(&tr->fsnotify_irqwork); } -/* - * (defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER)) && \ - * defined(CONFIG_FSNOTIFY) - */ -#else +#else /* LATENCY_FS_NOTIFY */ #define trace_create_maxlat_file(tr, d_tracer) \ trace_create_file("tracing_max_latency", 0644, d_tracer, \ @@ -9473,7 +9469,8 @@ init_tracer_tracefs(struct trace_array *tr, struct dentry *d_tracer) create_trace_options_dir(tr); -#if defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER) +#if defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER) \ + || defined(CONFIG_OSNOISE_TRACER) trace_create_maxlat_file(tr, d_tracer); #endif -- 2.25.1