Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp449802pxb; Sat, 18 Sep 2021 07:29:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLd6v1DJ+SfT2bJn79I5947jS/K/sflog+WuJXy6fZiajNBQcFlYXDF42PoRbBVv32oNFb X-Received: by 2002:a05:6e02:1d86:: with SMTP id h6mr9406049ila.5.1631975391002; Sat, 18 Sep 2021 07:29:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631975390; cv=none; d=google.com; s=arc-20160816; b=y6somUu9oXbknHXcBnrwiSU6XkzgJ6gFH5ZWXvzTJ7z0CfNA5xb4z4pe5m94On/d1p cIJRKJbJHNcLRKINecLz6b9AYLBk5vsTh1rusosnBbM0rdrTbbR8Vyqknkf645srEupT eUbF+siR3Y8sXiElh7kZu6HVld5h8OJNNvWkVFz1Y/rF+msLo9eiDZsV4v61UadM/v+c CIcERgWNvlqRbeoiKRha7Jy16Gh+Oeg4RBxI8PufUUx1k3kk9W1xZER29J3L6IJX67XQ JDzKbHD4BdSkvhJB73iIrRAN0wT6oor1nNCZJjz9tFQ+KA1+cNwsyCK0ydoR7mxWAoe4 +N/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=gpNR9/8KPrecHc3D9k5DESAhJBWWTEnz6U1deJxRqNU=; b=Jka2fCd8G8dmKqbVJrSquumpQE62FVLCLqLoaNPtTu13J6ksublOokZojh1q220PlA tMrSkdzkp1mZeIw4rG1nVeUQDFvByFHbWPnB0CYFm72L3huiRm6FpP98rCvqFEbpGsAO f4aykGBA9qMFElQAMa/8TW6W5CpeEOYBGOE3DdzzhHVkOdclEV2mVgRHdSqdeT8imTGn O4cnWdUNWFH0t2DcqglArYsga+OlCSdYAuiCNXJbkKMMjI8kf8/ThdyRQXwOrt3oFW78 gs7/SsmcR30i3bVUP9I001d99eNSX3MGJ3nO+YvbhNrdT5zMxvTRTrE4tMuYEwLKn5yQ m8rA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=YzOVL+0c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b7si2550238ilv.56.2021.09.18.07.29.39; Sat, 18 Sep 2021 07:29:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=YzOVL+0c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238008AbhIRJFx (ORCPT + 99 others); Sat, 18 Sep 2021 05:05:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233888AbhIRJFx (ORCPT ); Sat, 18 Sep 2021 05:05:53 -0400 Received: from out1.migadu.com (out1.migadu.com [IPv6:2001:41d0:2:863f::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EA71C061574; Sat, 18 Sep 2021 02:04:30 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1631955868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=gpNR9/8KPrecHc3D9k5DESAhJBWWTEnz6U1deJxRqNU=; b=YzOVL+0c1++sx274jUEo8EWYWi+x4BRWsta6u1HAzAEpLFouD6E4tBIRRgV5nr9rjLwMIh A9RpTJV1H37fNPBujcK/4eB5oJHIIfcfbXgexG+CuP6sb6dluRKblsLxlcWdlfO67Wq32M wS/aRc5c397fdBCIGqh5obPsCDcdng0= From: Yajun Deng To: davem@davemloft.net, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yajun Deng Subject: [PATCH net-next] net: net_namespace: Fix undefined member in key_remove_domain() Date: Sat, 18 Sep 2021 17:04:10 +0800 Message-Id: <20210918090410.29772-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: yajun.deng@linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The key_domain member in struct net only exists if we define CONFIG_KEYS. So we should add the define when we used key_domain. Fixes: 9b242610514f ("keys: Network namespace domain tag") Signed-off-by: Yajun Deng --- net/core/net_namespace.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c index a448a9b5bb2d..202fa5eacd0f 100644 --- a/net/core/net_namespace.c +++ b/net/core/net_namespace.c @@ -473,7 +473,9 @@ struct net *copy_net_ns(unsigned long flags, if (rv < 0) { put_userns: +#ifdef CONFIG_KEYS key_remove_domain(net->key_domain); +#endif put_user_ns(user_ns); net_free(net); dec_ucounts: @@ -605,7 +607,9 @@ static void cleanup_net(struct work_struct *work) list_for_each_entry_safe(net, tmp, &net_exit_list, exit_list) { list_del_init(&net->exit_list); dec_net_namespaces(net->ucounts); +#ifdef CONFIG_KEYS key_remove_domain(net->key_domain); +#endif put_user_ns(net->user_ns); net_free(net); } -- 2.32.0