Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp559926pxb; Sat, 18 Sep 2021 10:29:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwIQ9erfCs9m4Ggs+klvmtGxglS6QZkenZC8y5nnNkP8cueDrS8Iysm1WdtUCDy6MM0YArA X-Received: by 2002:a6b:6603:: with SMTP id a3mr12874512ioc.68.1631986186857; Sat, 18 Sep 2021 10:29:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631986186; cv=none; d=google.com; s=arc-20160816; b=XvcGHyXV8ilAYiIcqvwevbSxbtqreapCCIfNngOsioJWJQEPfE5Q6QnXs2wTN29H6f jPOclqF49yoGhdqDtDcvYCC5PAPvr+WpRFjeWlzMNzhSVe9RXHflcyk7XelpIZPxYAVi xleXRwoq7qKHLZeg1mmiyvJyEk0ndMUkHo9PIv1sU/sWy1CaagJgI+u11CFZNO5auRNj Z6e9soo2FglE1DOXamDre8VIbkZragRCabunU8tQdLJHhxkU4cIXJ9QIUuIFiv7GjVTs GRphic6LsBhMF+SkZSqJtUxc2XUUkqFB/8WPEbMEc6eBziyQJjGxi9flW4MDMs38sp6F xIdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:references :subject:cc:to:mime-version:user-agent:from:date:message-id; bh=Bdm4uiAwM/5jmTLKwVt0i4x9hh1lIqduOHAUTykeLUk=; b=tZKfA3TKlan6mHrtLJeiRN3JYFODn2jbuBdJ2v+66mAKj6LRu52aQEtXw2TIEpVPc5 +PSkxZCDZIpXLXkyVBvUKiQjfDIpPt/roRbMXh2mfTmCKdNiXl6JCZ6UJQJMGMe/jqoz 4A3o3jXtFE5+R7wvkZ9Ootal4xpZ1htvmRASM6U4KCRnqPfZGvtvkgUJMcVgASTfm3S3 kbdlh7FZlI1nvEf7Dp3He5/PbCim5Xw2Fp2NsnU3twxolnPDfr8cZTCtVwGNTG/nxNcy JoLLImVANjLgndsRsMHiaBHOJAWElBy8d/rYpv3xenX9+ccrudV8RoSKPIceTfBaEUtM ARqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=hisilicon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s5si8535383ilv.155.2021.09.18.10.29.35; Sat, 18 Sep 2021 10:29:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=hisilicon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243994AbhIRJ1X (ORCPT + 99 others); Sat, 18 Sep 2021 05:27:23 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:16278 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243891AbhIRJ0u (ORCPT ); Sat, 18 Sep 2021 05:26:50 -0400 Received: from dggeme755-chm.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4HBQQ42Wpqz8t8l; Sat, 18 Sep 2021 17:24:44 +0800 (CST) Received: from [10.40.166.221] (10.40.166.221) by dggeme755-chm.china.huawei.com (10.3.19.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.8; Sat, 18 Sep 2021 17:25:24 +0800 Message-ID: <6145B084.6020803@hisilicon.com> Date: Sat, 18 Sep 2021 17:25:24 +0800 From: Wei Xu User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Michael Walle , , , CC: Rob Herring Subject: Re: [PATCH] arm64: dts: hisilicon: fix arm,sp805 compatible string References: <20210830165113.222867-1-michael@walle.cc> In-Reply-To: <20210830165113.222867-1-michael@walle.cc> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.166.221] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggeme755-chm.china.huawei.com (10.3.19.101) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michael, On 2021/8/31 0:51, Michael Walle wrote: > According to Documentation/devicetree/bindings/watchdog/arm,sp805.yaml > the compatible is: > compatible = "arm,sp805", "arm,primecell"; > > The current compatible string doesn't exist at all. Fix it. > > Signed-off-by: Michael Walle Applied to the HiSilicon arm64 dt tree. Thanks! Best Regards, Wei > --- > There are also the layerscape SoC which are using these compatible > strings. I'm on it to change these, too. > > arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 4 ++-- > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > index 2d5c1a348716..6eabec2602e2 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > @@ -1087,7 +1087,7 @@ dwmmc2: dwmmc2@ff3ff000 { > }; > > watchdog0: watchdog@e8a06000 { > - compatible = "arm,sp805-wdt", "arm,primecell"; > + compatible = "arm,sp805", "arm,primecell"; > reg = <0x0 0xe8a06000 0x0 0x1000>; > interrupts = ; > clocks = <&crg_ctrl HI3660_OSC32K>, > @@ -1096,7 +1096,7 @@ watchdog0: watchdog@e8a06000 { > }; > > watchdog1: watchdog@e8a07000 { > - compatible = "arm,sp805-wdt", "arm,primecell"; > + compatible = "arm,sp805", "arm,primecell"; > reg = <0x0 0xe8a07000 0x0 0x1000>; > interrupts = ; > clocks = <&crg_ctrl HI3660_OSC32K>, > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > index dde9371dc545..e4860b8a638e 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > @@ -840,7 +840,7 @@ dwmmc_2: dwmmc2@f723f000 { > }; > > watchdog0: watchdog@f8005000 { > - compatible = "arm,sp805-wdt", "arm,primecell"; > + compatible = "arm,sp805", "arm,primecell"; > reg = <0x0 0xf8005000 0x0 0x1000>; > interrupts = ; > clocks = <&ao_ctrl HI6220_WDT0_PCLK>, >