Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751795AbWLMXbV (ORCPT ); Wed, 13 Dec 2006 18:31:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751798AbWLMXbU (ORCPT ); Wed, 13 Dec 2006 18:31:20 -0500 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:2568 "HELO mailout.stusta.mhn.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751795AbWLMXbT (ORCPT ); Wed, 13 Dec 2006 18:31:19 -0500 Date: Thu, 14 Dec 2006 00:31:28 +0100 From: Adrian Bunk To: Thomas Graf Cc: Stephen Hemminger , Al Viro , David Miller , jgarzik@pobox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [2.6 patch] drivers/net/loopback.c: convert to module_init() Message-ID: <20061213233128.GD3629@stusta.de> References: <20061212162435.GW28443@stusta.de> <20061212.171756.85408589.davem@davemloft.net> <20061213201213.GK4587@ftp.linux.org.uk> <20061213204933.GW8693@postel.suug.ch> <20061213150143.2672e0b1@dxpl.pdx.osdl.net> <20061213231217.GB3629@stusta.de> <20061213231848.GY8693@postel.suug.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061213231848.GY8693@postel.suug.ch> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1476 Lines: 36 On Thu, Dec 14, 2006 at 12:18:48AM +0100, Thomas Graf wrote: > * Adrian Bunk 2006-12-14 00:12 > > On Wed, Dec 13, 2006 at 03:01:43PM -0800, Stephen Hemminger wrote: > > > Loopback should be there before protocols are started. It makes sense > > > to have a standard startup order. > > > > This actually becomes easier after my patch: > > > > Now that it's untangled from net_olddevs_init(), you can simply change > > the module_init(loopback_init) to a different initcall level. > > Not really, the device management inits as subsys, the ip layer hooks > into fs_initcall() which comes right after. The loopback was actually > registered after the protocol so far. I think Adrian's patch is fine > if the module_init() is changed to device_initcall(). It doesn't matter (and I don't care) since for the non-modular case (that always applies for loopback), there's: #define __initcall(fn) device_initcall(fn) #define module_init(x) __initcall(x); cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/