Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1064417pxb; Sun, 19 Sep 2021 05:08:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmVxrLZninLsm8eGDhG2aoEpx2afoOnAk+nu8axoYUgmNj0evi79buk/SlRX1jKj956eiL X-Received: by 2002:a05:6402:1437:: with SMTP id c23mr18461562edx.247.1632053303534; Sun, 19 Sep 2021 05:08:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632053303; cv=none; d=google.com; s=arc-20160816; b=GedOAZ9dA/0rSNG5VWHWTfxc1/CO63YurJ/bLbhygruuJnwZGufv5J3pvBbGEtrVh6 RhS/mxZ3C57ZEsKCc6hfv6n0vkQIWdmXHMHktGkN4UWN0mxa1X+rHxGL8dJXs7yhwRPe z6EJrzV35RHKAdApFlM7djUlMDn+dQ2rTvt38MpDAp9Uaef/Q/4tRfqoJzX0gdDcJqj5 PZW6dhLxYK05yLldPnJTW88Boz9YZhJNUNH47n8oE4zMZFcMAXiMZiFaYzazDpAirfmk Q7slzNbzQiAxwyh0u1uhqii2ABxsMIOjdrFHbHXb0xJE3kl4vSGL80xN8eQlcGQ7Vh/u g8tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=jL0YyZVYNJH18NhjsKC4FdXboGYe7Tnw5QmBZVOO0WU=; b=uKaz4hVi7RWGH7RsMaWUiCx9cY0wkfsGEeNx9wnXKLULzIrBAVk+C0yWCK54z4zdHJ DMXuAWrS9Ncnd/fH+EDdrNqQCjBRdL5nqA4SUChrsgmH90XtkVcsZS9wPmxgjC3iehEG niFA2Bz7Zbcl6qkzJOFe8NiPZ5czChLrdsZVaxWCY63KnizqMzRfCgETTi5IZx8A9K1y 166LmHSNFlM6uADfzcVXmapFFhcND2KyFWoy94P/XQcOb8S5YmP2+45Djp9ucL/ezWw0 vzEPeHK47PwfwcAYGPX7Ow+D0WWyuIkvPLWl340eypJiIETp/nH5O1XlG/pW5wbaTXEQ b/uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=CE2LVR2Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f25si7959995ejl.8.2021.09.19.05.08.00; Sun, 19 Sep 2021 05:08:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=CE2LVR2Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235779AbhISCoF (ORCPT + 99 others); Sat, 18 Sep 2021 22:44:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234631AbhISCoF (ORCPT ); Sat, 18 Sep 2021 22:44:05 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A26AC061574; Sat, 18 Sep 2021 19:42:40 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id y1so1856588plk.10; Sat, 18 Sep 2021 19:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jL0YyZVYNJH18NhjsKC4FdXboGYe7Tnw5QmBZVOO0WU=; b=CE2LVR2Q5LIFuUVbwlSY3zrM0GK969+BFKkHmnW2ipzwoiTT7sCKT6l4Omebb79Z1H 73EGTduin7EEbQ723Ooo8RJB+hP2laKGPpJQ4mKNgscpSY/Kl5J+V6zxLK1Ho6Wvjqln r0wwmEo8CiuzRrodfJlqiq4THNfpJUkoPDXOz5y6gRgzpO77dWiINPv7fcPTGM/MgK37 oCZ0ohvmTCar+YzHMvRtPDnbUtblDcrD+SZaRByT+zCFDwtkCRLnjZj0qfJXgrwagejv e1SHQfpiGCTKLQKYozuC6xMQE+KZMpxeBlw/i5UMyykxQ9VZuhHaRv/7ONaL7RLMRlnU xIAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jL0YyZVYNJH18NhjsKC4FdXboGYe7Tnw5QmBZVOO0WU=; b=YBoJgb/QAS2NEA2K/7NLJI6oPnXmQjNoJmEO+5KFohl9WcMFzVDRBrKlQJkKloj5II kESxDkxRL0rdomKeECj8sSZCJzAHcRPjOlolcv4X5qX5dox5gnJxCtSgmrB2gx+Ng34M gJbe9/qp2r7U6MWH3UXoX1Pdh+2mJOUOU1/9vjn1a4s0S+tkooT/FiktLDUk+dkSusrj 3EvYQ7rHWHeHo/De87mUfwKjs1PiYh+vFtjbznXsJcbOWNhDmioiPcfTFR5DWpAa/B9e hjXCKELEDIzKH/Aq4+YWkKDSV6jt2EkZ0FO75kTe+65X1SvanxhTLiINkJ1/Ndu+2tKJ kZgQ== X-Gm-Message-State: AOAM5329v7mI6S0DKKDwuNHbwFmNyFBbrT+Gf7Oxu1kPMGLsTV7PqAmd /1L38E5D/9t5lVWx5rKEIFbqd6vxmhWNmQ== X-Received: by 2002:a17:90a:5583:: with SMTP id c3mr21002987pji.133.1632019359514; Sat, 18 Sep 2021 19:42:39 -0700 (PDT) Received: from localhost ([198.11.178.15]) by smtp.gmail.com with ESMTPSA id v197sm2409266pfc.125.2021.09.18.19.42.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Sep 2021 19:42:39 -0700 (PDT) From: Lai Jiangshan To: linux-kernel@vger.kernel.org Cc: Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , kvm@vger.kernel.org, Lai Jiangshan Subject: [PATCH 0/2] KVM: X86: Don't reset mmu context when changing PGE or PCID Date: Sun, 19 Sep 2021 10:42:44 +0800 Message-Id: <20210919024246.89230-1-jiangshanlai@gmail.com> X-Mailer: git-send-email 2.19.1.6.gb485710b MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lai Jiangshan This patchset uses kvm_vcpu_flush_tlb_guest() instead of kvm_mmu_reset_context() when X86_CR4_PGE is changed or X86_CR4_PCIDE is changed 1->0. Neither X86_CR4_PGE nor X86_CR4_PCIDE participates in kvm_mmu_role, so kvm_mmu_reset_context() is not required to be invoked. Only flushing tlb is required as SDM says. The patchset has nothing to do with performance, because the overheads of kvm_mmu_reset_context() and kvm_vcpu_flush_tlb_guest() are the same. And even in the [near] future, kvm_vcpu_flush_tlb_guest() will be optimized, the code is not in the hot path. This patchset makes the code more clear when to reset the mmu context. And it makes KVM_MMU_CR4_ROLE_BITS consistent with kvm_mmu_role. Lai Jiangshan (2): KVM: X86: Don't reset mmu context when X86_CR4_PCIDE 1->0 KVM: X86: Don't reset mmu context when toggling X86_CR4_PGE arch/x86/kvm/mmu.h | 5 ++--- arch/x86/kvm/x86.c | 7 +++++-- 2 files changed, 7 insertions(+), 5 deletions(-) -- 2.19.1.6.gb485710b