Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1104953pxb; Sun, 19 Sep 2021 06:19:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6lSBErsesv7C6SjUQLBo1NoC3rLNZmVjoWCXJh3m2l6z9sAI8e+gpHxhWiUmTkL0pIERu X-Received: by 2002:a92:c64a:: with SMTP id 10mr14090600ill.102.1632057564702; Sun, 19 Sep 2021 06:19:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632057564; cv=none; d=google.com; s=arc-20160816; b=PzC4NaorPTUU6Opw/iDvZaES2p8+eEey3/X7LPS7QoZMpVS+xIaOshECTgiQPRaNDN +qHjBHE61RKaMZhZuQ+8nOr6g5QcS79S29lQAcZseD3a1uAOIDLIvFSuTS35G6YFpPgV kUabSAt48/gkThyKiQuOrsNtHz3pJ+MFvBEskSWsTJNtJlDTBXOQExCrNCk3CFDNfHrO NPI7x3h2d+6CrOBNB/a/r7KzRaBe/o5Vgz4yrIcU7XuoOiJ/hvslEi2To+sw3yKU8rJ7 NUSKypDeRetmzodlkyW5G2nDylAQGVEadfQb9C3rXecLH4HOqnybcBi0xO/w/mvEJqLT 4h8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=w+7TQ53ZfVQhc67n9T7IBt60IE3Av6DuGHOh88aa8wk=; b=FTv0ibaWvTMq2cYgH7wwHbrys3Psnsb4Mn+ywEd5CUmhdnSbT/EZxneuEZIB1TQvqM 62Yc/9tXUdEpIapB6JijdBIJr903QKClf4MG/DHM03i4imm8pRTtWv9Cj7lMIRW4wrFx YrsPz1wAc4Y3vA5/CQzqZ0QhCqDQZwodf4owYlvcF0ojJbli4q+jNTRw2nJhyLKUNyHc tuuoI/2ui8LHx4pL4x1Ibvkz2Ih67eETSx/NnYfn3lpzhuCgmEga1ocMcAQCGqOBZAjV HF76q2rkcN+rpJXt4q8VjTSyA/1MlNp8RpqwP+Zdqdn8LyKYea3CPx+2EbUBsSJyuD2F 4IHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v18si11622188ilc.7.2021.09.19.06.19.11; Sun, 19 Sep 2021 06:19:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234834AbhISMDl (ORCPT + 99 others); Sun, 19 Sep 2021 08:03:41 -0400 Received: from rosenzweig.io ([138.197.143.207]:46618 "EHLO rosenzweig.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235729AbhISMDe (ORCPT ); Sun, 19 Sep 2021 08:03:34 -0400 Date: Sun, 19 Sep 2021 07:47:28 -0400 From: Alyssa Rosenzweig To: Sven Peter Cc: Jassi Brar , Rob Herring , Mark Kettenis , Hector Martin , Mohamed Mediouni , Stan Skowronek , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] Apple Mailbox Controller support Message-ID: References: <20210916154911.3168-1-sven@svenpeter.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210916154911.3168-1-sven@svenpeter.dev> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I've dropped v1 from my tree and cherry-picked "mailbox: apple: Add driver for Apple mailboxes". NVMe and DCP both still work, so this is Tested-by: Alyssa Rosenzweig Thanks! On Thu , Sep 16, 2021 at 05:49:09PM +0200, Sven Peter wrote: > Hi, > > This is the second version of my series which adds support for the mailbox > controllers found on the Apple M1. > > v1: https://lore.kernel.org/lkml/20210907145501.69161-1-sven@svenpeter.dev/ > > Thanks to Jassi, Mark and Alyssa for the initial review. I've addressed > your comments with the following changes: > > - switched to txdone_irq instead of introducing a new mode > - switched to a threaded interrupt handler for receiving messages > - added co-processor examples to the device tree binding > - reformatted the register defines and clarified multiple comments > > Best, > > Sven > > Sven Peter (2): > dt-bindings: mailbox: Add Apple mailbox bindings > mailbox: apple: Add driver for Apple mailboxes > > .../bindings/mailbox/apple,mailbox.yaml | 84 ++++ > MAINTAINERS | 3 + > drivers/mailbox/Kconfig | 12 + > drivers/mailbox/Makefile | 2 + > drivers/mailbox/apple-mailbox.c | 431 ++++++++++++++++++ > include/linux/apple-mailbox.h | 18 + > 6 files changed, 550 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml > create mode 100644 drivers/mailbox/apple-mailbox.c > create mode 100644 include/linux/apple-mailbox.h > > -- > 2.25.1 >