Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Len Baker <len.baker@gmx.com>
To:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc:     Len Baker <len.baker@gmx.com>,
        gushengxian <gushengxian@yulong.com>,
        Kees Cook <keescook@chromium.org>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        alsa-devel@alsa-project.org, linux-hardening@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] ALSA: usx2y: Prefer struct_size over open coded arithmetic
Date:   Sun, 19 Sep 2021 15:37:27 +0200
Message-Id: <20210919133727.44694-1-len.baker@gmx.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

In this case this is not actually dynamic size: all the operands
involved in the calculation are constant values. However it is better to
refactor this anyway, just to keep the open-coded math idiom out of
code.

So, use the struct_size() helper to do the arithmetic instead of the
argument "size + size * count" in the kzalloc() function.

Also, take the opportunity to refactor the declaration variables to make
it more easy to read.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#open-co=
ded-arithmetic-in-allocator-arguments

Signed-off-by: Len Baker <len.baker@gmx.com>
=2D--
 sound/usb/usx2y/usbusx2yaudio.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/sound/usb/usx2y/usbusx2yaudio.c b/sound/usb/usx2y/usbusx2yaud=
io.c
index c39cc6851e2d..cfc1ea53978d 100644
=2D-- a/sound/usb/usx2y/usbusx2yaudio.c
+++ b/sound/usb/usx2y/usbusx2yaudio.c
@@ -668,14 +668,15 @@ static void i_usx2y_04int(struct urb *urb)

 static int usx2y_rate_set(struct usx2ydev *usx2y, int rate)
 {
-	int			err =3D 0, i;
-	struct snd_usx2y_urb_seq	*us =3D NULL;
-	int			*usbdata =3D NULL;
-	const struct s_c2	*ra =3D rate =3D=3D 48000 ? setrate_48000 : setrate_44=
100;
+	int err =3D 0, i;
+	struct snd_usx2y_urb_seq *us =3D NULL;
+	int *usbdata =3D NULL;
+	const struct s_c2 *ra =3D rate =3D=3D 48000 ? setrate_48000 : setrate_44=
100;
 	struct urb *urb;

 	if (usx2y->rate !=3D rate) {
-		us =3D kzalloc(sizeof(*us) + sizeof(struct urb *) * NOOF_SETRATE_URBS, =
GFP_KERNEL);
+		us =3D kzalloc(struct_size(us, urb, NOOF_SETRATE_URBS),
+			     GFP_KERNEL);
 		if (!us) {
 			err =3D -ENOMEM;
 			goto cleanup;
=2D-
2.25.1