Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1268627pxb; Sun, 19 Sep 2021 11:30:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz5bhduwI8JDIhhGPdQrgVDy0qanIDkPRBt4byPY5EY3xc7h7nCFXYtCKtzz5JZI6YOuown X-Received: by 2002:a92:7302:: with SMTP id o2mr14995654ilc.44.1632076203284; Sun, 19 Sep 2021 11:30:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632076203; cv=none; d=google.com; s=arc-20160816; b=R1wuwildoFxm+FuMe270nBm2FvZkNx1onRX8p6CBaHh1vM1DIeVz4rHw5+cyB9Fhkm /kwSw/EHAr4CoEVI45loKiFRFL4gMqtB2QeaRuRmuu/KhwctF3kCtbTT8w6eD2j9a8io ilgq1CzDPW2G8B/nUJwBhyow0vQSlTg8TPpJUKEJvnS1MTIv+Lt9tNZMcphF12lbYcwo ihomGEgtU41iZFulTxmiTahy/RkRyEDmYxSuY43ZET9+U64XF5yrOitYsr1iMFPoE+Lp RNL2RvuK142OCGxzeLht2xHq1OBuY2HCcY7VOHzZEDIDhdridz6IvwMUOzaJlcNkT8dd G/uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=sdmB/wkGpwx96MWwgYMP7hWTDwP53nN+H+iHxNTbU1A=; b=JzwfMAacVrIe0DCu9QQZvQDzBZbzmgbdTjAFGRxqToAFw+YvpdT+aeKUBqiT3/zXYR svC202cVSQiJHQeSUwkwi0Vnn7sjf1haTxC82Nrpxs2u/trBvVXmnTsA3whx/bPDUSFr xLNbv27QNKgo4QK2KVH34fcZIMhQI0XjfExpVIFqWgdZpd170fuoO3Z4hLt/HSqRvUPp vhY1vytx+3q83XuUF6/b3PvknEbDN73mZcj+3kDxQS+SHuKqOaS7YGi0tf2sMTFNkBbN YuY/ZNhBqJ8Ts7HxpQYbSdI2jSrFZpOe9i4EpkVQGx1TmZTap/4i4NHypEImXeRaCqd8 Sf1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=To2lJkyu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z14si11381693ill.35.2021.09.19.11.29.48; Sun, 19 Sep 2021 11:30:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=To2lJkyu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229954AbhISMLe (ORCPT + 99 others); Sun, 19 Sep 2021 08:11:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:42516 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229638AbhISMLd (ORCPT ); Sun, 19 Sep 2021 08:11:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPS id 6374A6127B; Sun, 19 Sep 2021 12:10:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632053408; bh=tJpTymouqGkRGzxlt+rfk0Az13JptJoFnLz5XQqwGTU=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=To2lJkyu0XseE5GxrnKg3izcq/Cr4MTii5vd/ROZG3VEFtvcEfGogTkDPldvdFzmY O9srd4MoigzKd/Kfbi9x4NAg53iVDcploCtyB29UA1PGyjCMkreG5+OYlbJktUNwTQ XRuh78zmDMfFL1Lmgv/DYeQeubBxtWr0jZNGE8k0jmPe0SAAompSFSmacvdtb0ePAm j4NQ9kT6yQdjgSAIWUYNnoBRDiMfXchhQ2SuVnlXM4Mk08hyOEWvZFv8g7WOIPgrnh Mnzfv3afMNHBpMP4YmlkOLpDL/dQVpOt/TKgHXjre857NT7Q0a5KI5Wgt8vz/DgZ5O WioaxXPwp+7Vw== Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id 47EA660A37; Sun, 19 Sep 2021 12:10:08 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v3 net 0/2] ocelot phylink fixes From: patchwork-bot+netdevbpf@kernel.org Message-Id: <163205340828.3254.3027678837058017593.git-patchwork-notify@kernel.org> Date: Sun, 19 Sep 2021 12:10:08 +0000 References: <20210917153905.1173010-1-colin.foster@in-advantage.com> In-Reply-To: <20210917153905.1173010-1-colin.foster@in-advantage.com> To: Colin Foster Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, vladimir.oltean@nxp.com, claudiu.manoil@nxp.com, alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com, davem@davemloft.net, kuba@kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This series was applied to netdev/net.git (refs/heads/master): On Fri, 17 Sep 2021 08:39:03 -0700 you wrote: > When the ocelot driver was migrated to phylink, e6e12df625f2 ("net: > mscc: ocelot: convert to phylink") there were two additional writes to > registers that became stale. One write was to DEV_CLOCK_CFG and one was > to ANA_PFC_PCF_CFG. > > Both of these writes referenced the variable "speed" which originally > was set to OCELOT_SPEED_{10,100,1000,2500}. These macros expand to > values of 3, 2, 1, or 0, respectively. After the update, the variable > speed is set to SPEED_{10,100,1000,2500} which expand to 10, 100, 1000, > and 2500. So invalid values were getting written to the two registers, > which would lead to either a lack of functionality or undefined > funcationality. > > [...] Here is the summary with links: - [v3,net,1/2] net: mscc: ocelot: remove buggy and useless write to ANA_PFC_PFC_CFG https://git.kernel.org/netdev/net/c/163957c43d96 - [v3,net,2/2] net: mscc: ocelot: remove buggy duplicate write to DEV_CLOCK_CFG https://git.kernel.org/netdev/net/c/ba68e9941984 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html