Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 19 Sep 2021 18:33:25 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Cai Huoqing <caihuoqing@baidu.com>, <linux-iio@vger.kernel.org>
Cc:     Lars-Peter Clausen <lars@metafoo.de>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: dac: stm32-dac:  Make use of the helper function
 devm_platform_ioremap_resource()
Message-ID: <20210919183325.7bb5a8d9@jic23-huawei>
In-Reply-To: <20210908105638.1525-1-caihuoqing@baidu.com>
References: <20210908105638.1525-1-caihuoqing@baidu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 8 Sep 2021 18:56:38 +0800
Cai Huoqing <caihuoqing@baidu.com> wrote:

> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>

Applied to the togreg branch of iio.git and pushed out as testing for 0-day
to see if it can find any problems that we missed.

Thanks,

Jonathan

> ---
>  drivers/iio/dac/stm32-dac-core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/dac/stm32-dac-core.c b/drivers/iio/dac/stm32-dac-core.c
> index 906436780347..9a6a68b11b2a 100644
> --- a/drivers/iio/dac/stm32-dac-core.c
> +++ b/drivers/iio/dac/stm32-dac-core.c
> @@ -90,7 +90,6 @@ static int stm32_dac_probe(struct platform_device *pdev)
>  	const struct stm32_dac_cfg *cfg;
>  	struct stm32_dac_priv *priv;
>  	struct regmap *regmap;
> -	struct resource *res;
>  	void __iomem *mmio;
>  	struct reset_control *rst;
>  	int ret;
> @@ -106,8 +105,7 @@ static int stm32_dac_probe(struct platform_device *pdev)
>  	cfg = (const struct stm32_dac_cfg *)
>  		of_match_device(dev->driver->of_match_table, dev)->data;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	mmio = devm_ioremap_resource(dev, res);
> +	mmio = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(mmio))
>  		return PTR_ERR(mmio);
>