Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1407909pxb; Sun, 19 Sep 2021 16:59:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNcofTxN/WVABpQJTrwfiQtwpXJqGQ+wb8YUp/mlpmXg4ooSex5r/Z13E2v+Sj9mHd4Yvi X-Received: by 2002:a17:906:7217:: with SMTP id m23mr25177967ejk.466.1632095943354; Sun, 19 Sep 2021 16:59:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632095943; cv=none; d=google.com; s=arc-20160816; b=Ri12MzPyzILJ6VSNyfxcOhuLGNJAaoKo6AbZgzQY7CpCHww2C2hz8ikW5Za+8fEacW o0qGb0qfS5z9pjnc/Yd1Mg0+C4RfZmVpIDniTT9HH2y3FFcEsdKhvZPpOQGB4AGN+L/2 lQAYoAg7GDPv+98RjR3ZOsNPQD1DO/Y8JuJl+WEDRvEokHY473PIu59UU15LLNCOMwec 2eeF2ONBwgKEt7Y5JEXcXAUmWGBSv7D1iK5rP/woNk9VnNnmTXV4FdRWalC+HsaYJG5k RBmeqS3DnTu/L89J/ap8h1oSvkiTuhg4LQy4pdxPrispHGkKSkC0p3LZ/WNT4A7/Behk igdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=rwG0cyjmLoqo6KWJPkoebUUL/eGcFniLZjCwbXyHXbY=; b=S/wLksHDQGYE/Clnw7LrGN7xtJ8UHA5Y8vOeh3dIsy2hhCnN9MyDQOloTjls9useYV CKTQOmCbs3uuyuyjRnlRlrcALCHX6G/dk39M4f/W/Ui+p81X+lJladLwKKsaXA2t4+ka HdRUI6ChQcygdk9LxCx/AuQiZ544PuQJiX3wSp+QG9HFZ66ZOEiYEwJGBoqm42W32sFo lySoZRkXFRnRBo3O3xblx9XPk7uPZN3Fi1exVny22OXc5XwskKrYpFkia8x7lzCPnEII dpYmSAPT9b3tczGqAHD7+ras68SojfbJcfOrjBX40jRytje05bDaHCvIodlnm4JY3uvW 4yDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QttFeThv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o9si14134422edt.384.2021.09.19.16.58.40; Sun, 19 Sep 2021 16:59:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QttFeThv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231723AbhISTfK (ORCPT + 99 others); Sun, 19 Sep 2021 15:35:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231669AbhISTfI (ORCPT ); Sun, 19 Sep 2021 15:35:08 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B643C061760 for ; Sun, 19 Sep 2021 12:33:42 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id g41so24641554lfv.1 for ; Sun, 19 Sep 2021 12:33:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rwG0cyjmLoqo6KWJPkoebUUL/eGcFniLZjCwbXyHXbY=; b=QttFeThvsBKoZD/JJSZUGcnMxxYovmSAcPaoFut8GAFLHLvS3IsTDF2HdKr15LPN9G dQm8BvfUECw8XeDSv0m1SrsY5DNjsXO5PhGldlbFPGCmZzLQf5f4vh/pFDbjSFvStSof bsHKoK1XDB+jm11SUX3KQZcdBcwrIoJ9zJT7u7lZPKBBvscShFCJI06s8Nc+Cbx5aPk8 FLEsvge3r+dLL5c8eRyGYCib3lpmVuGEyJOQApoo1BXqM0ORTQDvz1f9o1dc6g3fwHqJ sn8PMwx45/tPsdybUcEWbNcsQsIJx3OV8yTmV/E9eKunE7RJcgj2CWzrCIKxFp+jpbCh 0Qnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rwG0cyjmLoqo6KWJPkoebUUL/eGcFniLZjCwbXyHXbY=; b=OV+lvwlz1LCWhmODaSroACrOiCxbH4ctH85i//Uq3Xd62fCrBwnZLdFDvbfZaNH4Lu d6i+0tPbuQskW2fVM3AEktfqme6RNYyryqo3FzMhkIcZrPt5oa9cRgvlVCBADkREKjS7 6paWd6WRzpRG08ShxBn6jRInjctcIUScQQlStH3DW7leS2Ig8ZH5a2i2BZTvYpHVMAcF DFPX/xEKp5fYZSNpvCHcko0Fd1ljoZdHUcmbxIVc/eMDk+aY3fCsPUhDy/Bid2Q13ptl NIMVG/SwSWPxA8ljQHQGFfArx/n5TI4BQMwsMDf7lqjEaWZl0ev4xly11d/UsOUsilEr rgmw== X-Gm-Message-State: AOAM5331N7fmzd0LttMEgo/EKflITmCEfio+RuYG1NElDZUiHm1KlzrB PJOu0T/4G5gHJ6etyMoSLavqBDTQV2zIQmtO8UWmzg== X-Received: by 2002:a05:6512:10cb:: with SMTP id k11mr6357275lfg.72.1632080020480; Sun, 19 Sep 2021 12:33:40 -0700 (PDT) MIME-Version: 1.0 References: <20210830003603.31864-1-zhiyong.tao@mediatek.com> <20210830003603.31864-5-zhiyong.tao@mediatek.com> <74a3a96745e93c5a2392b8a39822c872fd468466.camel@mediatek.com> In-Reply-To: <74a3a96745e93c5a2392b8a39822c872fd468466.camel@mediatek.com> From: Linus Walleij Date: Sun, 19 Sep 2021 21:33:29 +0200 Message-ID: Subject: Re: [PATCH v11 4/4] pinctrl: mediatek: add rsel setting on MT8195 To: "zhiyong.tao" Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , Matthias Brugger , Sean Wang , srv_heupstream , hui.liu@mediatek.com, Eddie Huang , Light Hsieh , Biao Huang , Hongzhou Yang , Sean Wang , Seiya Wang , Devicetree List , LKML , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:ARM/Mediatek SoC support" , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 16, 2021 at 11:31 AM zhiyong.tao wrote: > On Mon, 2021-09-06 at 18:09 +0800, Chen-Yu Tsai wrote: > > > > > + if (!found) { > > > > > + dev_err(hw->dev, "Not support rsel value %d Ohm > > > > > for > > > > > pin = %d (%s)\n", > > > > > + arg, desc->number, desc->name); > > > > > + return -EOPNOTSUPP; > > > > > > > > I believe ENOTSUPP is the correct one. EOPNOTSUPP seems to be > > > > network > > > > related. > > > > > > > > > > if we change it as "ENOTSUPP", it will report warning"ENOTSUPP is > > > not > > > SUSV4 error code, prefer EOPNOTSUP" when checking patch. > > > > The context surrounding this warning seems to be that ENOTSUPP is > > hard > > for userspace to understand. AFAIK the return code here does not get > > passed to userspace? And the pinctrl core does check for EINVAL or > > ENOTSUPP, so I think this is a valid use case. > > > > Linus? > > > > Hi Linus, > > Do you have some suggestion for the warning issue? Ignore the warning. We use this code in the pinctrl subsystem. The pinctrl subsystem has no userspace API so that is certainly not a problem. Yours, Linus Walleij