Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210918090410.29772-1-yajun.deng@linux.dev>
In-Reply-To: <20210918090410.29772-1-yajun.deng@linux.dev>
From:   Cong Wang <xiyou.wangcong@gmail.com>
Date:   Sun, 19 Sep 2021 16:25:00 -0700
Message-ID: <CAM_iQpW8hGBinQKTqKidYfn5sJjAYMUMHyr4U-=dn_CfWVLtMQ@mail.gmail.com>
Subject: Re: [PATCH net-next] net: net_namespace: Fix undefined member in key_remove_domain()
To:     Yajun Deng <yajun.deng@linux.dev>
Cc:     David Miller <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Sep 18, 2021 at 7:28 AM Yajun Deng <yajun.deng@linux.dev> wrote:
>
> The key_domain member in struct net only exists if we define CONFIG_KEYS.
> So we should add the define when we used key_domain.

But key_remove_domain() is just a nop if !CONFIG_KEYS:

#else /* CONFIG_KEYS */
...
#define key_remove_domain(d)            do { } while(0)

So what exactly are you fixing?

Thanks.