Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1672666pxb; Mon, 20 Sep 2021 02:28:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+QrYkJDlKu9WJcYDOoGsn4xbUtoviyif7VbVfVzunIMBO7J4Rs1ybw754q9Ua0MLK1UwY X-Received: by 2002:a05:6e02:1be6:: with SMTP id y6mr17231599ilv.106.1632130125376; Mon, 20 Sep 2021 02:28:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632130125; cv=none; d=google.com; s=arc-20160816; b=Su+jPYQBxhzQr2DWryfFbC/SyFLi3UD+VeKYfsq24qj2JarsuGHITXJPoK5kB5ZeTs RL474mfRJVmZEmnDh6TtGrolGhk55ubR96OxX8rpr3a3CzLNWx4r4a2vbQkZH8pi/2ZN t1r8zq0uqEw0O8NerVJjr3rrJ/M6pzRsIdqK66M7bT5ohKyuJmHsD7A1ykPDldonzLIc vQ1mg8SsVSxPrgaG60UE30jaGvpsyD4YTjxeQXXoUILFRsquy3ziYArL9iHVOZgZJbfC egPMkNX4nluYzayFVjiGFuxmowg1aifPu3qXUgfhn2lnBHt2Cp5V4G6kg4eSAjT5bV3x UZjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=B7/fiP3/Jzm9NVWKcjI0F+BmhnjP3IElkYEbqDTE+Bw=; b=Hnu5ZYp24sfn6kwbpGUydRzW2GSHzD6jAE8lRDW1lY5Ybb50T2QIZcOJjzA/n3jpQp B9kg7y52+IUKdzRwEMlkm0GMKXrQWmUYD0L0bIhj9wRfReEFiUmb4sZkwElkUjydpkSP YBfLpOygsN6MdFKQmwzfD0rNtsiiyPgEN59RlLI2oFt9/C67uWbB0JxtorncuGhZGh67 Yy4iBFQLhlSJZgyeHRJHKHLX1k0YaZXymWOAEJ38gX7FjhLU1N/WY+vC5dtcMA/w4Ey+ eTUVmOzmLclXaXIz9oTtMBgBMFtFo8Tl6yDn7Z4X8Nr42LO3LwMy9e4kohzlqXYkIdA1 SKRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y203si3232258iof.106.2021.09.20.02.28.33; Mon, 20 Sep 2021 02:28:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233724AbhITHYN (ORCPT + 99 others); Mon, 20 Sep 2021 03:24:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229562AbhITHYN (ORCPT ); Mon, 20 Sep 2021 03:24:13 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7E16C061574; Mon, 20 Sep 2021 00:22:46 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1mSDdM-0005la-RP; Mon, 20 Sep 2021 09:22:36 +0200 Date: Mon, 20 Sep 2021 09:22:36 +0200 From: Florian Westphal To: Cole Dishington Cc: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net, kuba@kernel.org, shuah@kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, Anthony Lineham , Scott Parlane , Blair Steven Subject: Re: [PATCH net v5 1/2] net: netfilter: Limit the number of ftp helper port attempts Message-ID: <20210920072236.GH15906@breakpoint.cc> References: <20210920005905.9583-1-Cole.Dishington@alliedtelesis.co.nz> <20210920005905.9583-2-Cole.Dishington@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210920005905.9583-2-Cole.Dishington@alliedtelesis.co.nz> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cole Dishington wrote: > In preparation of fixing the port selection of ftp helper when using > NF_NAT_RANGE_PROTO_SPECIFIED, limit the number of ftp helper port > attempts to 128. > > Looping a large port range takes too long. Instead select a random > offset within [ntohs(exp->saved_proto.tcp.port), 65535] and try 128 > ports. LGTM, please fix the format argument error the kbuild robot reported and resend. You may add Acked-by: Florian Westphal when doing so.