Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] drm/radeon: fix uninitialized bool variable
To:     Zhiwei Yang <yangzhiwei@uniontech.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Alex Deucher <alexander.deucher@amd.com>
Cc:     =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20210918094157.4770-1-yangzhiwei@uniontech.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <ckoenig.leichtzumerken@gmail.com>
Message-ID: <484936f6-86e8-2078-3739-674a04283666@gmail.com>
Date:   Mon, 20 Sep 2021 09:44:01 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20210918094157.4770-1-yangzhiwei@uniontech.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


Am 18.09.21 um 11:41 schrieb Zhiwei Yang:
> The bool variable detected_hpd_without_ddc in struct radeon_connector
> is uninitialized when first used, that may cause unnecessary ddc ops.
> Make it as false when a new connector is alloced.
>
> Signed-off-by: Zhiwei Yang <yangzhiwei@uniontech.com>
> ---
>   drivers/gpu/drm/radeon/radeon_connectors.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/radeon/radeon_connectors.c
> index fe12d9d91d7a..c1987a66373f 100644
> --- a/drivers/gpu/drm/radeon/radeon_connectors.c
> +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
> @@ -1866,6 +1866,7 @@ radeon_add_atom_connector(struct drm_device *dev,
>   	bool shared_ddc = false;
>   	bool is_dp_bridge = false;
>   	bool has_aux = false;
> +	bool detected_hpd_without_ddc = false;

In general good catch, but I don't see the need for a local variable here.

Just initialize the member directly or even better change the allocation 
of the connector into a kzalloc().

Christian.

>   
>   	if (connector_type == DRM_MODE_CONNECTOR_Unknown)
>   		return;
> @@ -1923,6 +1924,7 @@ radeon_add_atom_connector(struct drm_device *dev,
>   	radeon_connector->shared_ddc = shared_ddc;
>   	radeon_connector->connector_object_id = connector_object_id;
>   	radeon_connector->hpd = *hpd;
> +	radeon_connector->detected_hpd_without_ddc = detected_hpd_without_ddc;
>   
>   	radeon_connector->router = *router;
>   	if (router->ddc_valid || router->cd_valid) {
> @@ -2384,6 +2386,7 @@ radeon_add_legacy_connector(struct drm_device *dev,
>   	struct radeon_connector *radeon_connector;
>   	struct i2c_adapter *ddc = NULL;
>   	uint32_t subpixel_order = SubPixelNone;
> +	bool detected_hpd_without_ddc = false;
>   
>   	if (connector_type == DRM_MODE_CONNECTOR_Unknown)
>   		return;
> @@ -2414,6 +2417,7 @@ radeon_add_legacy_connector(struct drm_device *dev,
>   	radeon_connector->devices = supported_device;
>   	radeon_connector->connector_object_id = connector_object_id;
>   	radeon_connector->hpd = *hpd;
> +	radeon_connector->detected_hpd_without_ddc = detected_hpd_without_ddc;
>   
>   	switch (connector_type) {
>   	case DRM_MODE_CONNECTOR_VGA: