Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 20 Sep 2021 11:33:30 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Michael Straube <straube.linux@gmail.com>
Cc:     Larry.Finger@lwfinger.net, Phillip Potter <phil@philpotter.co.uk>,
        Greg KH <gregkh@linuxfoundation.org>,
        "open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: staging: r8188eu: Can odm_DynamicTxPowerNIC() be removed?
Message-ID: <20210920083330.GO2088@kadam>
References: <7f1c135a-d85d-d271-f315-d665a5fe1472@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7f1c135a-d85d-d271-f315-d665a5fe1472@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eRCN+mVXxIMLgWSS04DJDsAozNyDRMLphKKwhGQehhqfi2v8amvTHC0n4zYM?=
 =?us-ascii?Q?V7iXsev6f7MCKizgTcTmwS0gMvQhkiDhP9gbwdQMLmAuFiTqLl8d79m1udDI?=
 =?us-ascii?Q?lord6CxOz+wjG3xGdRMkqWTcT2hSLFStejvW/zH2TYj7P26oz/JaOl22lp2W?=
 =?us-ascii?Q?M/PhB6j6kX2CdVsZ83KWGEtOdZl13N19kNY8UbYy6RfSB7M5d+K2mxTEadGl?=
 =?us-ascii?Q?67OzkpAF0z92PP4m71kAXhocvLMIPy9ju9l23BhK+lX/StpHpmBhVn01N5xR?=
 =?us-ascii?Q?S7S9ySXsxz/w7xfVZc8Cu4JP7j9G1X+E7dEERroIG7ED0kHAuyFSjJ7pN5Y1?=
 =?us-ascii?Q?aU+X81zDu/zxiFTIQkvK+D14jUVB5x4eG/KOCQ9oozMFZt73Vkx4P07JRStb?=
 =?us-ascii?Q?PGdQl1XW9RO/YR2tu1tAcM7Y/AEVy28P8NOdb3njp3IwMVlQm+xHccTt5jYj?=
 =?us-ascii?Q?/K1eUsSCQML8oDscisoi3BrCCWYW68z48N/YkOExH3ayGGudO2tOpZXr52wg?=
 =?us-ascii?Q?drVzrXXDCah3S2oBWqsjQb+tOkDdy1Mpa189deAoI06S4rrX5sDLjz9eMq+o?=
 =?us-ascii?Q?j4aq6n09c4sTj4+9VmxkohlM+nPzecms9Ut7h/Mm+d9k6gpWzVoWtLZXtYBd?=
 =?us-ascii?Q?72oCJncda2KqMZf+wZi4JUZOITuta8s/jqBN1GwLM8ol2NzJ7NKMSTehjWnq?=
 =?us-ascii?Q?PgCBzCKGbgXUObJiGMCSjwYyGZ2QMQjO7O3Gy/UAOVBKnPWJ5iknlv+ZOjVd?=
 =?us-ascii?Q?VwbU3HgE9pGU+hSbRg6x+p1azgslV2pdV+UsQDuEhBE4zvy9zPC74QjO6Q5y?=
 =?us-ascii?Q?RgfIcy4tE6Nb1L8xb2lKLRn3uQwiRefKr86xP6EMS3ahvsLmdCV8sGRH9YZ+?=
 =?us-ascii?Q?KhdiR8WTjvAEoC2S/Rh7sZPU1MRJXiKNsE0NuOfYigmoMr7t2iRUEUbns/Z7?=
 =?us-ascii?Q?5xg3XZDtLVERMnWWWI7EYs93eW8W8VeZKR56aTPowxqtGteIR55QjQHfa3bL?=
 =?us-ascii?Q?ftiRSZfuKPawF4CaN5C3NTPnyvSOexmTtMcQmSjeKxwnR5x6/d1R0O0KEbY2?=
 =?us-ascii?Q?A4i70N4mVxDyoX+JTJnYzJ9Hq2Fbh11caAyXdVLMPwTqjmlu+EokX4iHwro0?=
 =?us-ascii?Q?iLpRzzskHRQmVdKhrI7z8fExqbLTQUfcV5NmVcK6uvprT2q2G+huggDGgVMB?=
 =?us-ascii?Q?yEY6RgHPv7daLvl+UImYfC9hsrkR55WezJsajFDYnhKMrrVjdfvNAnwTg53A?=
 =?us-ascii?Q?B/KIeAgDj15ljLYAPRkJQ1P4QkcqM4lWWe0xPVo7Kixb3MBICNclRM6+Y9Sv?=
 =?us-ascii?Q?Nu9UiRzv2ChA+iwGLJ2v7ypr?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ec7a70a-e45f-4818-a8c7-08d97c1161b6
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2021 08:33:54.8293
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TnakqnFiHBswB6JJGkeA56qKw+U51iiH4YAxeN3z1Hpc7XcKkieTG0juTHNeT6WHrdrF1a2REQ5yGkF/jSQHY5n0AYm7TrXatMIIFqcGhKI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1888
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10112 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=747 adultscore=0
 bulkscore=0 mlxscore=0 suspectscore=0 spamscore=0 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109030001 definitions=main-2109200050
X-Proofpoint-GUID: YRoQwv5L423NXFBZWIo_tabWwPWfBWJ6
X-Proofpoint-ORIG-GUID: YRoQwv5L423NXFBZWIo_tabWwPWfBWJ6
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Sep 18, 2021 at 03:31:48PM +0200, Michael Straube wrote:
> Hi Larry, Phillip and all.
> 
> While removing code that checks for the chip type I stumbled upon this:
> 
> 
> void odm_DynamicTxPowerNIC(struct odm_dm_struct *pDM_Odm)
> {
> 	if (!(pDM_Odm->SupportAbility & ODM_BB_DYNAMIC_TXPWR))
> 		return;
> 
> 	if (pDM_Odm->SupportICType == ODM_RTL8188E) {
> 		/*  ??? */
> 		/*  This part need to be redefined. */
> 	}
> }

Always just delete dead code.  The future is very hard to predict so
don't leave things lying around because of possible futures.  Don't be
a hoarder.

regards,
dan carpenter