Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 20 Sep 2021 09:31:34 +0100
From:   Melissa Wen <mwen@igalia.com>
To:     Cai Huoqing <caihuoqing@baidu.com>
Cc:     Emma Anholt <emma@anholt.net>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/v3d: Make use of the helper function
 devm_platform_ioremap_resource_byname()
Message-ID: <20210920083134.hajvw6kpvfg3qitn@mail.igalia.com>
References: <20210901112941.31320-1-caihuoqing@baidu.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="fg5trcv37os37ajy"
Content-Disposition: inline
In-Reply-To: <20210901112941.31320-1-caihuoqing@baidu.com>
Precedence: bulk


--fg5trcv37os37ajy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 09/01, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource_byname() helper instead of
> calling platform_get_resource_byname() and devm_ioremap_resource()
> separately
>=20
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
>  drivers/gpu/drm/v3d/v3d_drv.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
> index 9403c3b36aca..c1deab2cf38d 100644
> --- a/drivers/gpu/drm/v3d/v3d_drv.c
> +++ b/drivers/gpu/drm/v3d/v3d_drv.c
> @@ -206,10 +206,7 @@ MODULE_DEVICE_TABLE(of, v3d_of_match);
>  static int
>  map_regs(struct v3d_dev *v3d, void __iomem **regs, const char *name)
>  {
> -	struct resource *res =3D
> -		platform_get_resource_byname(v3d_to_pdev(v3d), IORESOURCE_MEM, name);
> -
> -	*regs =3D devm_ioremap_resource(v3d->drm.dev, res);
> +	*regs =3D devm_platform_ioremap_resource_byname(v3d_to_pdev(v3d), name);
>  	return PTR_ERR_OR_ZERO(*regs);
>  }
lgtm.

Reviewed-by: Melissa Wen <mwen@igalia.com>
> =20
> --=20
> 2.25.1
>=20

--fg5trcv37os37ajy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEd8WOo/JViG+Tu+XIwqF3j0dLehwFAmFIRuEACgkQwqF3j0dL
ehwFSQ//Q93Ccx+Thy4bGmUslKbPr5ioKli9qBRNNMjK/9lPxrU3kewaKlH9SDEv
9YbLXcl4ejUBZi8TW0q/vOSp+PpeLIvG8xPdR7QSSXSBorMJ24x2WvjZcrXOu24M
B6ZRo0+IsZqyJqRhfTG1PXBiIygG/kf+LZd1QDEMfqQK9ErvBGpuvym0qaQKwq8I
kltEy/LInB2BXIXhAL/Bedh38dXspsHmAigbbd855YuLDAeYvWraQwlVV6x2jjbl
KJcD5OxF8r/OiA21+vGQiGHToIts5gAwIza4UlhK8XzdJNAQQLDJ5K0uATiDXqto
f0okb/2rUFoClL/UrzDLzPoGMSHNHBFgJKNsBKkGl80M5+h0EFLhzkG2fZadoEHp
z5lpJz5JwxxF1e+JuyAVkaSr2Sp+YiT0me4zphNX7L7kjTWEh1M9WZN5OY334hzB
TemrkzB1oQ7IyO2N3Z085klfsM+cy+hDj8V1v8oIlC8y/zaLH/hEyu43oGq64Yai
ZR7SU0ODAdbKm1+m8yHcHHvQBMBL2CifdRtYpyQS5b4QUYGRW+KMfelyLtASqJO/
lYejUsKetJi1uxddbJNtyQQVY+6CME0SEQISaAxBjj9zLCQu4mY1949t/nDeFNZb
7EfIiGDpQaX90sHTjf81JpsuFnk2VIKChMQ8rLm+VUrQ8CeEEJI=
=g7qr
-----END PGP SIGNATURE-----

--fg5trcv37os37ajy--