Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210918035041.25512-1-liyunlonga@uniontech.com>
In-Reply-To: <20210918035041.25512-1-liyunlonga@uniontech.com>
From:   Robert Foss <robert.foss@linaro.org>
Date:   Mon, 20 Sep 2021 11:47:53 +0200
Message-ID: <CAG3jFysCS2g4QrXgZQ9E9Jzq_-5OnXPPUf0kWMpkx56DFkdD1A@mail.gmail.com>
Subject: Re: [PATCH] drm: bridge: it66121: Added it66121 chip external screen
 status judgment.
To:     Yunlongli <liyunlonga@uniontech.com>
Cc:     Phong LE <ple@baylibre.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Andrzej Hajda <a.hajda@samsung.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hey Yunlongli,

Thanks for submitting this fix.

On Sat, 18 Sept 2021 at 05:51, Yunlongli <liyunlonga@uniontech.com> wrote:

The formatting of this commit message is a bit unusual, let's try to
change it to the normal formatting.

Remove the dot from the commit title:
"drm: bridge: it66121: Added it66121 chip external screen status
judgment." -> "drm: bridge: it66121: Added it66121 chip external
screen status judgment"


>
> fix: Add further confirm if external screens are involved.

The "fix:" tag is not needed. However if this commit fixes a bug
introduced in an earlier commit a machine readable tag like the the
one below could be added after the commit message.

Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver")

>
> log: In the actual tests,  the IT66121 chip sometimes misjudged whether
>      it had an external screen, so, reference the it66121_user_guid.pdf
>      about Audio/Video data is stable or not A typical initialization
>      of HDMI link should be based on interrupt signal and appropriate
>      register probing. Recommended flow is detailed in IT66121
>      Programming Guide. Simply put, the microcontroller should monitor
>      the HPD status first. Upon valid HPD event, move on to check
>      RxSENDetect register to see if the receiver chip is ready for
>      further handshaking. When RxSENDetect is asserted, start reading EDID
>      data through DDC channels and carry on the rest of the handshaking
>      subsequently.If the micro-controller makes no use of the interrupt
>      signal as well as the above-mentioned status  registers, the link
>      establishment might fail. Please do follow the suggested
>      initialization flow recommended in IT66121 Programming Guide.
>      So, I add the IT66121_SYS_STATUS_SENDECTECT register status detection.
>

The "log:" prefix is not needed, and neither is the indentation of the text.

Secondly maybe it would be nice to format the above chunk of text into
paragraphs just to make it easier to read.

> Signed-off-by: Yunlongli <liyunlonga@uniontech.com>
> ---
>  drivers/gpu/drm/bridge/ite-it66121.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
> index 2f2a09adb4bc..9ed4fa298d11 100644
> --- a/drivers/gpu/drm/bridge/ite-it66121.c
> +++ b/drivers/gpu/drm/bridge/ite-it66121.c
> @@ -523,7 +523,7 @@ static bool it66121_is_hpd_detect(struct it66121_ctx *ctx)
>         if (regmap_read(ctx->regmap, IT66121_SYS_STATUS_REG, &val))
>                 return false;
>
> -       return val & IT66121_SYS_STATUS_HPDETECT;
> +       return ((val & IT66121_SYS_STATUS_HPDETECT) && (val & IT66121_SYS_STATUS_SENDECTECT));
>  }
>
>  static int it66121_bridge_attach(struct drm_bridge *bridge,
> --
> 2.20.1
>
>
>

With the above suggestions fixed, feel free to add my r-b and submit a
v2 of this patch.
Reviewed-by: Robert Foss <robert.foss@linaro.org>