Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Alexander Shishkin <alexander.shishkin@linux.intel.com>
To:     cgel.zte@gmail.com, peterz@infradead.org
Cc:     mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com,
        jolsa@redhat.com, namhyung@kernel.org, tglx@linutronix.de,
        bp@alien8.de, x86@kernel.org, hpa@zytor.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        Yang Guang <yang.guang5@zte.com.cn>,
        alexander.shishkin@linux.intel.com
Subject: Re: [PATCH] Add pointer check
In-Reply-To: <20210918030131.236378-1-yang.guang5@zte.com.cn>
References: <20210918030131.236378-1-yang.guang5@zte.com.cn>
Date:   Mon, 20 Sep 2021 13:42:28 +0300
Message-ID: <87mto7il4b.fsf@ashishki-desk.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

cgel.zte@gmail.com writes:

> From: Yang Guang <yang.guang5@zte.com.cn>
>
> The buf->stop_te pointer may be NULL.

[...]

> --- a/arch/x86/events/intel/pt.c
> +++ b/arch/x86/events/intel/pt.c
> @@ -1118,9 +1118,12 @@ static int pt_buffer_reset_markers(struct pt_buffer *buf,
>  		buf->intr_te = pt_topa_prev_entry(buf, buf->intr_te);
>  	}
>  
> -	buf->stop_te->stop = 1;
> -	buf->stop_te->intr = 1;
> -	buf->intr_te->intr = 1;
> +	if (buf->stop_te) {

It really can't be NULL at this point.

Regards,
--
Alex