Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Csk60ls+nnw7rc+ZKRkY/w42ottl8Twp14ACK3/xjuCG18mOOBaNB3BG02M2CtmeTfgs2GTyGu
 U1i/tdYpAlCoDOEluWVRK98uQKbu4mslxVB7Xn6kvm9F2R2NENZiiZnVJJdPSjDra1h8nOL+EC
 kUKvRLZXsC4mXl5g377AXlP5o2/1/zYQmyIP00MFWBh5BOjdmx3gLlXAUcElvwtGvrSXdLljVK
 1CURgnlm/yVzIt1UG/ULm+D277j1S7bAF1AAOyG5hjPU/fGyAPB5fYmlWgslZ4DpWb/gjfrVLb
 1cyCJZ/+2WInDvczg4e1ZJqT
From:   <Kavyasree.Kotagiri@microchip.com>
To:     <alexandre.belloni@bootlin.com>
CC:     <Ludovic.Desroches@microchip.com>, <linux@armlinux.org.uk>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <Manohar.Puri@microchip.com>,
        <Madhuri.Sripada@microchip.com>, <Nicolas.Ferre@microchip.com>
Subject: RE: [PATCH v2] ARM: at91: add basic support for new SoC lan966x
Thread-Topic: [PATCH v2] ARM: at91: add basic support for new SoC lan966x
Thread-Index: AQHXnlICK4tJGF9um0OyzDxKZPeipauoVqqAgAAOjICABGRUEA==
Date:   Mon, 20 Sep 2021 10:47:14 +0000
Message-ID: <CO1PR11MB4865E29F8FDB5C87CCF5649992A09@CO1PR11MB4865.namprd11.prod.outlook.com>
References: <20210831102138.2476-1-kavyasree.kotagiri@microchip.com>
 <8610dd7a-a6eb-0c65-f66e-b4f9fdbce854@microchip.com>
 <YUSnIfzWpQ+YGWkB@piout.net>
In-Reply-To: <YUSnIfzWpQ+YGWkB@piout.net>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aKKVA0CpHW2PGzDGRtMSiISCPpRPqPAKtD8R9XyzkyQjxHqBTM33VcrHMkQm?=
 =?us-ascii?Q?Md6u8AJOsW2qfWey1VoTxo8n1CMHN+mWdz8w/B8uHJeP+gbcNIezenJx6xhG?=
 =?us-ascii?Q?p7jHdcAS0gILh3bn5lxlIcylVpo+eBd9SXk6Jb9BbwE4V+sUflNngpYIBSmn?=
 =?us-ascii?Q?ExGQ5zKTgbotmfwSFbSvpTrxolzib3ftSYkXZ+WBYKhn/D3RDp4igtIBfWkD?=
 =?us-ascii?Q?tG4HXC8j9fwb65ln/K9Zj1R2BNtb1XqW1qNSwSDa0hOduqTb1nHS+2TLsOq3?=
 =?us-ascii?Q?nnVu115XcJqdfCXVXrcM6OkaY/MMATBztsaAf8kf6wVI9U32mZCPKinF717q?=
 =?us-ascii?Q?P/yTpFZ/LOpUBQj5udEskPrOJLCpZrSM0c6MtAmDNbTxbeX2rStFDbULYO4D?=
 =?us-ascii?Q?5sVox6D6hVBAmdWWMFrio2UUfnBk0gucry6/pX+ReQe1FlS33itAQOjoEC0d?=
 =?us-ascii?Q?C+owfNXeb6nRuZPjcPouNJuJe2ZH7JEeiB79g6rQe1NPhDqqILTKcojLF9pI?=
 =?us-ascii?Q?S+dXujNI+v67/xWGaRmneXW54ynRnPoiNFxGJO0J4X4AIGQzB6FUVyO3Djhc?=
 =?us-ascii?Q?7vhJEuvYQ2mXa+B6TvlyrpePrAG/bWd4NU0P6lWlqVv5fc7aSmag2t5Urvgs?=
 =?us-ascii?Q?Vxwhi5lK5lO6ddElh7atAia3RXcdJQgR4UJZ/jBxblox7MyoiQ2eAy5lc+Gp?=
 =?us-ascii?Q?jxTTi3AysaNvVLlq4ALlDMxmJSj4vlb+16e06IyrboyQT2R6j8FuOrEj1z/X?=
 =?us-ascii?Q?iN4hpg655DTjQnPFVki9i5U4iBG/RIHh9hPx8c+2s2yc6+utyW/bqTyZ4Gd2?=
 =?us-ascii?Q?74LQL/WQyFx2QwAqkWQItNQc6hOouoBed7rBjjW8huvueAGxIj+iQBW8KGHH?=
 =?us-ascii?Q?oV/YwTyDEuNZ5L+lra26ymyIAhogHRGEZWKZN8falNW6wBGBEaoWiTs3Tnqa?=
 =?us-ascii?Q?dbfXXNP+0+6eimaBpMCXW8KDIUNrkouZe/95XJOgjD3HI8uLDTnsTtbzPmAG?=
 =?us-ascii?Q?37ce9n7Pm6K0gdJUC1j4BHDH22ZZ4AcXGAIT9a5ybhkYkza3K9tVuBxzPqha?=
 =?us-ascii?Q?P9FoFQpZ891UeXHJoZzpdomJpts4dXD+l0dApk+OnxMKnb6z8/9gU1lgfkEl?=
 =?us-ascii?Q?Kb1KxI/YsGKVzg+UndILiicF9ictYSEegUx9Ipv/yE4tvbecptFB54gR3dT9?=
 =?us-ascii?Q?EZ/sE7U4wWdh3pBVkY9/+8dRLwMLJbtSU5VKQUu3Si2MwoHjHAZWHyeeswQx?=
 =?us-ascii?Q?AqPz/6+h0zD+RnN0+9bX7RG+8bRTAcRnIXuW0AdldtG0B2iJOqYlRdyTud63?=
 =?us-ascii?Q?+0M=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4865.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5795a19f-a09c-4236-d6ed-08d97c240202
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2021 10:47:14.2619
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WocsQ9dBBjQmRoQb6SHn34GeYgoxJpBBl6S2pYbNjLbGMFdaPo8nIDDE7DEV3f0DdncosnlUo5R171Fz3zO3i6mU58d33OrPzNDST22MJYv8JHRsjKhnxfiyzrH4Tzc+
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5043
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Alexandre Belloni [mailto:alexandre.belloni@bootlin.com]
> Sent: Friday, September 17, 2021 8:03 PM
> To: Nicolas Ferre - M43238 <Nicolas.Ferre@microchip.com>
> Cc: Kavyasree Kotagiri - I30978 <Kavyasree.Kotagiri@microchip.com>; Ludov=
ic
> Desroches - M43218 <Ludovic.Desroches@microchip.com>;
> linux@armlinux.org.uk; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; Manohar Puri - I30488
> <Manohar.Puri@microchip.com>; Madhuri Sripada - I34878
> <Madhuri.Sripada@microchip.com>
> Subject: Re: [PATCH v2] ARM: at91: add basic support for new SoC lan966x
>=20
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> Hello,
>=20
> I wanted to reply earlier but I still have a few comments...
>=20
> On 17/09/2021 15:41:01+0200, Nicolas Ferre wrote:
> > On 31/08/2021 at 12:21, kavyasree.kotagiri@microchip.com wrote:
> > > From: Kavyasree Kotagiri <Kavyasree.Kotagiri@microchip.com>
> > >
> > > This patch introduces Microchip LAN966X ARMv7 based SoC family
> > > of multiport gigabit AVB/TSN-capable ethernet switches.
> > > It supports two SKUs: 4-port LAN9662 with multiprotocol
> > > processing support and 8-port LAN9668 switch.
> > >
> > > LAN966X includes copper and serial ethernet interfaces,
> > > peripheral interfaces such as PCIe, USB, TWI, SPI, UART, QSPI,
> > > SD/eMMC, Parallel Interface (PI) as well as synchronization
> > > and trigger inputs/outputs.
> > >
> > > Signed-off-by: Kavya Sree Kotagiri <kavyasree.kotagiri@microchip.com>
> >
> > Your name fixed with your permission and as Rob suggested in a previous
> > series.
> >
> > > ---
> > > v1 -> v2:
> > > - Removed lan966x_dt_device_init().
> > >    System boots fine without this function.
> > >
> > >   arch/arm/mach-at91/Kconfig   | 13 +++++++++++++
> > >   arch/arm/mach-at91/Makefile  |  1 +
> >
> > Kconfig and Makefile files updated to avoid merge conflict with SAMA7G5
> that
> > was integrated in 5.15-rc1.
> >
> > >   arch/arm/mach-at91/lan966x.c | 25 +++++++++++++++++++++++++
> >
> >
> > >   3 files changed, 39 insertions(+)
> > >   create mode 100644 arch/arm/mach-at91/lan966x.c
> > >
> > > diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
> > > index ccd7e80ce943..06cb425af761 100644
> > > --- a/arch/arm/mach-at91/Kconfig
> > > +++ b/arch/arm/mach-at91/Kconfig
> > > @@ -122,6 +122,14 @@ config SOC_SAM9X60
> > >     help
> > >       Select this if you are using Microchip's SAM9X60 SoC
> > > +config SOC_LAN966X
> > > +   bool "ARMv7 based Microchip LAN966X SoC family"
> > > +   depends on ARCH_MULTI_V7
> > > +   select SOC_LAN966
> > > +   select DW_APB_TIMER_OF
> > > +   help
> > > +     This enables support for ARMv7 based Microchip LAN966X SoC
> family.
> > > +
>=20
> I don't think SOC_LAN966X is a good name or said differently as it is
> not part specific, I don't get why this isn't merged with SOC_LAN966. I
> would have one or the other.
>=20
I am using two different names to represent LAN966 as a new SoC family and=
=20
LAN966X as its SKU's - LAN9662 and LAN9668

> > >   comment "Clocksource driver selection"
> > >   config ATMEL_CLOCKSOURCE_PIT
> > > @@ -188,6 +196,11 @@ config SOC_SAMA5
> > >     select SOC_SAM_V7
> > >     select SRAM if PM
> > > +config SOC_LAN966
> > > +   bool
> > > +   select ARM_GIC
> > > +   select MEMORY
> > > +
> > >   config ATMEL_PM
> > >     bool
> > > diff --git a/arch/arm/mach-at91/Makefile b/arch/arm/mach-
> at91/Makefile
> > > index f565490f1b70..93cfd5b4e6d4 100644
> > > --- a/arch/arm/mach-at91/Makefile
> > > +++ b/arch/arm/mach-at91/Makefile
> > > @@ -6,6 +6,7 @@
> > >   # CPU-specific support
> > >   obj-$(CONFIG_SOC_AT91RM9200)      +=3D at91rm9200.o
> > >   obj-$(CONFIG_SOC_AT91SAM9)        +=3D at91sam9.o
> > > +obj-$(CONFIG_SOC_LAN966X)  +=3D lan966x.o
> > >   obj-$(CONFIG_SOC_SAM9X60) +=3D sam9x60.o
> > >   obj-$(CONFIG_SOC_SAMA5)           +=3D sama5.o
> > >   obj-$(CONFIG_SOC_SAMV7)           +=3D samv7.o
> > > diff --git a/arch/arm/mach-at91/lan966x.c b/arch/arm/mach-
> at91/lan966x.c
> > > new file mode 100644
> > > index 000000000000..154d616569ae
> > > --- /dev/null
> > > +++ b/arch/arm/mach-at91/lan966x.c
> > > @@ -0,0 +1,25 @@
> > > +// SPDX-License-Identifier: GPL-2.0-or-later
> > > +/*
> > > + * Setup code for LAN966X
> > > + *
> > > + * Copyright (C) 2021 Microchip Technology, Inc. and its subsidiarie=
s
> > > + *
> > > + */
> > > +
> > > +#include <linux/of.h>
> > > +#include <linux/of_platform.h>
> > > +
> > > +#include <asm/mach/arch.h>
> > > +#include <asm/system_misc.h>
> > > +
>=20
> I'm not sure all those include are actually used.
>=20
> > > +#include "generic.h"
> > > +
> > > +static const char *const lan966x_dt_board_compat[] __initconst =3D {
> > > +   "microchip,lan966x",
> >
> > This compatibility string will need to be documented in
> > Documentation/arm/microchip.rst
> > and
> > Documentation/devicetree/bindings/arm/atmel-at91.yaml (or a similar fil=
e,
> as
> > you wish).
> >
> > You'll add it to your DT patches.
> >
>=20
> Yes and you'll have to document lan9662 and lan9668. Really, wildcards
> in the compatible strings are usually not a good idea.
>=20
> > > +   NULL
> > > +};
> > > +
> > > +DT_MACHINE_START(lan966x_dt, "Microchip LAN966X")
> > > +   /* Maintainer: Microchip */
> > > +   .dt_compat      =3D lan966x_dt_board_compat,
> > > +MACHINE_END
> > >
> >
> > All the rest looks good to me: no need to resend. It's queued in at91-s=
oc
> > branch targeting 5.16.
> > You'll see it appearing in linux-next in the next few days.
> >
>=20
> Well, I'm still wondering one thing, is arch/arm/mach-at91/lan966x.c
> necessary at all to boot the platform?
>=20
Yes, it is needed as it introduces new compatible string for new SoC LAN966=
X.
Could you please let me know if there is a different way to do this?

> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com