Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210904064044.125549-1-yan2228598786@gmail.com>
 <CAM_iQpWCRYXc1PAOTehgMztfbmSVF=RqudOjhZhGeP_huaKjZw@mail.gmail.com> <CALcyL7h=vS_Nmg4GfRe-SD9ZSZopCM5p6U1mojn1gncw1Nds6g@mail.gmail.com>
In-Reply-To: <CALcyL7h=vS_Nmg4GfRe-SD9ZSZopCM5p6U1mojn1gncw1Nds6g@mail.gmail.com>
From:   Cong Wang <xiyou.wangcong@gmail.com>
Date:   Mon, 20 Sep 2021 09:58:50 -0700
Message-ID: <CAM_iQpVB97-t+J+zEF5xzLi07+YPK6O+Ph-NyTxAHV-2=cY93Q@mail.gmail.com>
Subject: Re: [PATCH] net: tcp_drop adds `reason` and SNMP parameters for
 tracing v4
To:     Zhongya Yan <yan2228598786@gmail.com>
Cc:     Eric Dumazet <edumazet@google.com>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>,
        David Miller <davem@davemloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        David Ahern <dsahern@kernel.org>, hengqi.chen@gmail.com,
        Yonghong Song <yhs@fb.com>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        Zhongya Yan <2228598786@qq.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Sep 4, 2021 at 7:51 PM Zhongya Yan <yan2228598786@gmail.com> wrote:
> Thanks for the tip!
> See reason:https://github.com/iovisor/bcc/issues/3533

This link only explains why TCP needs it, my question is why not
do it for other protocols too, therefore neither this link nor you
answers it.

BTW, net/core/drop_monitor.c is based on kfree_skb() tracepoint
too, in case you are only interested in tracepoints not other things.

Thanks.