Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 20 Sep 2021 15:39:10 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc:     Saurav Girepunje <saurav.girepunje@gmail.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        saurav.girepunje@hotmail.com, Larry.Finger@lwfinger.net,
        phil@philpotter.co.uk, straube.linux@gmail.com,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: core: remove the function
 power_saving_wk_hdl
Message-ID: <20210920123910.GQ2088@kadam>
References: <YTub30ZRG3oLbxQW@user>
 <1651026.4NJzAxWbHA@localhost.localdomain>
 <20210920113221.GP2088@kadam>
 <2311011.CixZWWR6MO@localhost.localdomain>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2311011.CixZWWR6MO@localhost.localdomain>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zwCYRm6jru2zKzrAwxs7rYUcq2OxseR5UDDkgWNRO+1n0muMb1R7G8H7MJ4j?=
 =?us-ascii?Q?HBRAfPtLKWM059t1p9JB70Q0yPpYaLXGvv8yCTPczJ/+GP7q7DjkamHl+imR?=
 =?us-ascii?Q?8JY8uI4P+cG98ssHIAswki9GHpe/so0hCL+y/yYsSx9Go8fiZGuYUs/cCkr2?=
 =?us-ascii?Q?sORHot4xGtF1zzt2QZa+j7pdDZe+sCK2dvXOoZCXz5s95f5xqQWrlu8kmtkV?=
 =?us-ascii?Q?2bXQDVPT4LS+NAntmqHh2ocZkrxxkhmqgHcMwuEjxfrCftQ3WQtKEofKlAb4?=
 =?us-ascii?Q?D6xFozaKZrIgNbIYSqvMFoIsamk+fWuviQg23hK+JO0VDalCZZeg/6N4ha3q?=
 =?us-ascii?Q?JhChjgE/0reUQWty43Fax2FhEQ2XOufL6sNgqpcK3+H4+qltVBOtjvrPZU5a?=
 =?us-ascii?Q?TfNLrooM0Ai7+ikxP47VuOMqI7650+SJdBVbPHjcJZ0iUarIT4F+lOr0nL4X?=
 =?us-ascii?Q?a3qKv68FfysOOv7SseCPfEQyDWD25Z85ZWIPPvJ9ieHE2h1PWJL5yVMS1H+k?=
 =?us-ascii?Q?ajPdM8JNQCqkoYrda+j09CWluvvfKOlMVW2qBoDOA2NZnQzzhBJCkfFYd/tJ?=
 =?us-ascii?Q?JivS79SerqXzKIY3J1YfTV6McDPlPRpRZkZLdrGyfSntXhA3cgTF7InnEx+Y?=
 =?us-ascii?Q?aHRpA7vEC9XXGzy1g4Wv/agFjjqSC7855y+cnKBpDMzsNaP6wkOdjzmAs7mz?=
 =?us-ascii?Q?7nSORkLyc0BaHFP3gQypJO9ED3eBOmds6RSu05X4B5sM0DwO5fSdPBjEc6IH?=
 =?us-ascii?Q?ptq3ttMgTjnfqk6t7GtpM8zokA04LJixl6b6D2sqSZ9ShVkHSkis0ktLbjc6?=
 =?us-ascii?Q?JQBCyDIghpdt/P5g9PYdDC4edWcm8+zRemnmqURE9C+kIzRh40gvsBLwEKc/?=
 =?us-ascii?Q?QYN5Ng4a+hjpp23KSsoN3lCXY6MHBOqU/lZnHZtp20GKXuxOrxk553Sq101L?=
 =?us-ascii?Q?s9R/ihfF9c5UJHahSjj6IaE+fNvrEQYgJO5crxHxRVC1DAMukkXcEgXRSkU4?=
 =?us-ascii?Q?5ZSv9gNQ5r4TntLni1uPc4kCOmPuInJGFvOeoxXZk9GVIWBKcVZNuoEbPfqk?=
 =?us-ascii?Q?4ERzcFXHNczWHQEbFn6NVdx1QlFlfsknXyMMg/9sgo/RQoO6xMr5lnGgTPop?=
 =?us-ascii?Q?HxjGQhaeCsFm+DcFiysz6atzM92/1ppWypFuJxfBTlajXdA90xF5PCjf3JQz?=
 =?us-ascii?Q?uRhX5epO23tjHeMOoKJTNCMw3jvsQa9Qww2Sv0+VFwl0TAC8/LKEuJdI6u1i?=
 =?us-ascii?Q?IyV/xBvxmAguJl6jxWB55xSEC5U5Zxinm68HTg+r54IEz3xeUl9ZZr1j1dIi?=
 =?us-ascii?Q?iNGiayWviYGk0k2NyZ2ShXjl?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cdb77d74-b0a0-464e-658b-08d97c33af92
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2021 12:39:28.1938
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ym/rSAPZzKR2cFldU3FxW8LRGTCSGdIA6MONh8t5U2t2+9d4nMQpP073r+3O8WX0DDOHS+XR3qolyCrbB1RaXSH+VDR3QpsaJqMYzamE/9Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4483
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10112 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 spamscore=0
 bulkscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001
 definitions=main-2109200080
X-Proofpoint-GUID: I5OevqWM81PK5YHZEf8in8PCoisctMfY
X-Proofpoint-ORIG-GUID: I5OevqWM81PK5YHZEf8in8PCoisctMfY
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 20, 2021 at 02:31:28PM +0200, Fabio M. De Francesco wrote:
> On Monday, September 20, 2021 1:32:21 PM CEST Dan Carpenter wrote:
> > On Mon, Sep 20, 2021 at 01:13:54PM +0200, Fabio M. De Francesco wrote:
> > > On Monday, September 20, 2021 12:36:06 PM CEST Greg KH wrote:
> > > > On Sat, Sep 18, 2021 at 10:52:50PM +0530, Saurav Girepunje wrote:
> > > > > 
> > > > > 
> > > > > On 13/09/21 9:48 pm, Greg KH wrote:
> > > > > > On Fri, Sep 10, 2021 at 11:24:39PM +0530, Saurav Girepunje wrote:
> > > > > > > Remove the function power_saving_wk_hdl() as it just calling
> > > > > > > the rtw_ps_processor().Instead of power_saving_wk_hdl() call 
> directly
> > > > > > > rtw_ps_processor().
> > > > > > > 
> > > > > > > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> > > > > >
> > > > > > []
> > > > > > 
> > > > > > Also does not apply to my tree.  Please rebase against my staging-
> next
> > > > > > branch and resend.
> > > > > > 
> > > > > > thanks,
> > > > > > 
> > > > > > greg k-h
> > > > > > 
> > > > > 
> > > > > Hi Greg,
> > > > > 
> > > > > I always do rebase against your staging-testing branch. Can you help 
> me 
> > > to
> > > > > understand.When we need to rebase on staging-next. Do we always need 
> to
> > > > > rebase against staging-next..!
> > > > 
> > > > Yes, you should.  When you are working on code that lots of other 
> people
> > > > are working on, there will be conflicts like this, and you just need to
> > > > stay on top of it.
> > > > 
> > > > thanks,
> > > > 
> > > > greg k-h
> > > > 
> > > 
> > > Sorry, Greg. I'm confused... :(
> > > 
> > > As far as I know, everyone here make patches for staging-testing.
> > 
> > Nope.  It's only you.
> 
> And Saurav (at least) :)
> 

Nope.  Saurav is working against something old.  You can see the
#ifdef CONFIG_88EU_P2P stuff that was removed in commit 102243f893ec
("staging: r8188eu: Remove conditionals CONFIG_88EU_{AP_MODE,P2P}") was
applied.

> I've been misled and in turn I misled Pavel. This is due to a guide in 
> kernelnewbies.org that explicitly says to use staging-testing:
> 
> https://kernelnewbies.org/OutreachyfirstpatchSetup
> 
> In that page the is a section ("Set up your Linux kernel code repository") 
> which says: "[] Then use the revision control system called git to clone Greg 
> Kroah-Hartman's staging tree repository: git clone -b staging-testing git://
> git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git".
> 

Huh...

Those aren't *bad* instructions.  Working against testing-next is fine,
but just be aware that it can rebase.

regards,
dan carpenter