Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/4] ARM: dts: dra7: add entry for bb2d module
To:     Tony Lindgren <tony@atomide.com>
Cc:     linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Gowtham Tammana <g-tammana@ti.com>,
        Jyri Sarha <jsarha@ti.com>
References: <20210920125306.12347-1-narmstrong@baylibre.com>
 <20210920125306.12347-2-narmstrong@baylibre.com>
 <YUiOixF5/op1hXLf@atomide.com>
From:   Neil Armstrong <narmstrong@baylibre.com>
Organization: Baylibre
Message-ID: <e0f0d78b-0678-7acf-32f4-3e40af918d1f@baylibre.com>
Date:   Mon, 20 Sep 2021 16:13:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <YUiOixF5/op1hXLf@atomide.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 20/09/2021 15:37, Tony Lindgren wrote:
> Hi,
> 
> * Neil Armstrong <narmstrong@baylibre.com> [210920 12:53]:
>> --- a/arch/arm/boot/dts/dra7.dtsi
>> +++ b/arch/arm/boot/dts/dra7.dtsi
>> @@ -965,6 +965,26 @@ hdmi: encoder@0 {
>>  			};
>>  		};
>>  
>> +		target-module@59000000 {
>> +			compatible = "ti,sysc-omap4", "ti,sysc";
>> +			reg = <0x59000020 0x4>;
>> +			reg-names = "rev";
>> +			clocks = <&dss_clkctrl DRA7_DSS_BB2D_CLKCTRL 0>;
>> +			clock-names = "fck";
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +			ranges = <0x0 0x59000000 0x1000>;
>> +
>> +			bb2d: gpu@0 {
>> +				compatible = "vivante,gc";
>> +				reg = <0x0 0x0700>;
>> +				interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
>> +				clocks = <&dss_clkctrl DRA7_BB2D_CLKCTRL 0>;
>> +				clock-names = "core";
>> +				status = "disabled";
>> +			};
>> +		};
>> +
>>  		aes1_target: target-module@4b500000 {
>>  			compatible = "ti,sysc-omap2", "ti,sysc";
>>  			reg = <0x4b500080 0x4>,
> 
> How about just use the default for the bb2d node with is "okay"?
> That way there's no need set status = "okay" for each board file.
> 
> If there is no driver loaded, we idle the target-module anyways.

Yes you're right, I'll resend only this patch with no status property on bb2d node.

thanks,
Neil

> 
> Regards,
> 
> Tony
>