Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 20 Sep 2021 16:37:15 +0300
From:   Tony Lindgren <tony@atomide.com>
To:     Neil Armstrong <narmstrong@baylibre.com>
Cc:     linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Gowtham Tammana <g-tammana@ti.com>,
        Jyri Sarha <jsarha@ti.com>
Subject: Re: [PATCH 1/4] ARM: dts: dra7: add entry for bb2d module
Message-ID: <YUiOixF5/op1hXLf@atomide.com>
References: <20210920125306.12347-1-narmstrong@baylibre.com>
 <20210920125306.12347-2-narmstrong@baylibre.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210920125306.12347-2-narmstrong@baylibre.com>
Precedence: bulk

Hi,

* Neil Armstrong <narmstrong@baylibre.com> [210920 12:53]:
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -965,6 +965,26 @@ hdmi: encoder@0 {
>  			};
>  		};
>  
> +		target-module@59000000 {
> +			compatible = "ti,sysc-omap4", "ti,sysc";
> +			reg = <0x59000020 0x4>;
> +			reg-names = "rev";
> +			clocks = <&dss_clkctrl DRA7_DSS_BB2D_CLKCTRL 0>;
> +			clock-names = "fck";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges = <0x0 0x59000000 0x1000>;
> +
> +			bb2d: gpu@0 {
> +				compatible = "vivante,gc";
> +				reg = <0x0 0x0700>;
> +				interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&dss_clkctrl DRA7_BB2D_CLKCTRL 0>;
> +				clock-names = "core";
> +				status = "disabled";
> +			};
> +		};
> +
>  		aes1_target: target-module@4b500000 {
>  			compatible = "ti,sysc-omap2", "ti,sysc";
>  			reg = <0x4b500080 0x4>,

How about just use the default for the bb2d node with is "okay"?
That way there's no need set status = "okay" for each board file.

If there is no driver loaded, we idle the target-module anyways.

Regards,

Tony