Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Min Li <min.li.xe@renesas.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "richardcochran@gmail.com" <richardcochran@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "andrew@lunn.ch" <andrew@lunn.ch>
Subject: RE: [PATCH net v2 2/2] ptp: idt82p33: implement double dco time
 correction
Thread-Topic: [PATCH net v2 2/2] ptp: idt82p33: implement double dco time
 correction
Thread-Index: AQHXq9Hw5KOUR0ss3UKvyfLSiPV3fKuoo+GAgAAE1HCAAA9tgIAENlNw
Date:   Mon, 20 Sep 2021 14:08:37 +0000
Message-ID: <OS3PR01MB65935EC20F350036340F3348BAA09@OS3PR01MB6593.jpnprd01.prod.outlook.com>
References: <1631889589-26941-1-git-send-email-min.li.xe@renesas.com>
        <1631889589-26941-2-git-send-email-min.li.xe@renesas.com>
        <20210917125401.6e22ae13@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <OS3PR01MB65936ADCEF63D966B44C5FEFBADD9@OS3PR01MB6593.jpnprd01.prod.outlook.com>
 <20210917140631.696aadc9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20210917140631.696aadc9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Accept-Language: en-CA, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?38bxnzEhYNrpxt8cD2TPFxuNtbfPDURuDOEMP9p/g8W2IKG2WF+MGARpLgfH?=
 =?us-ascii?Q?jH9rZ0/eoIJQLZbK3R8j1ZU+R0rww+UIQpLcrA7TWhuhS6RIkRhk4+ozuMSt?=
 =?us-ascii?Q?6zKBHEcKOFAbZBDMps15m/IK2qCKnUT2d8YpHbIRCvGF+GZT8wi00hS50KZQ?=
 =?us-ascii?Q?iExOxdozzWamgNQp+RePJ1kV9wcHJXC8Gp9TshlGoyuQ/uVvXVG4m1izG4ZC?=
 =?us-ascii?Q?R8oY4pxb0SDTQphgEZnfa9lUtyMCX/7e77XvQYYUISAf0J9BiNhY8Nszv9Y7?=
 =?us-ascii?Q?SHrCFVYWl+HOMgaAJhzq0bSILP3ESvzY/jnd+B89fg3SKaH76L0/ypbOwisl?=
 =?us-ascii?Q?BdR4gcbVpB1Glt3672Ed97MD6aNs1tCuZPJ4CuhyWAjfVrSN4T8z/ti1qdY5?=
 =?us-ascii?Q?O1l9iGFnH3XHj3AW5Jr4ESh/AlZGo9JVItcg2AafBesiwhuwSAE3RrR/h5Kh?=
 =?us-ascii?Q?BIIls5rOMS72W6dLjyZw2HwLjh7OqrTIa7dTyxEuvY2xe5u2Uhz4/DeHMaWl?=
 =?us-ascii?Q?NK7hvvXVKskchjQsBSd5/TFEc9Ik72aNIhVUFDQuzCqBE6DRfFl6Qb3qWFE6?=
 =?us-ascii?Q?Tjiz+hx6YOGII+PFI54BMBaeiq2WoD1KydqZayjxC03PH6cVQIUXyRMzoKjX?=
 =?us-ascii?Q?0FtLknnhNwswONX8kq7HuyifKeZR+ScBeTXfyuCCttNMXt+7Jp0IM/cMlafY?=
 =?us-ascii?Q?ePhzoUA/akK2Ow8tfITq7gBYTNHslc19DRiq2DT4dEguxse5twPXY1REmIXA?=
 =?us-ascii?Q?Zn4H+pJm3NrZlekGTw/9sCsU7pYWtxOq2E8PA2C17WrTMSXQ74v94tCFVNbU?=
 =?us-ascii?Q?dJ0dhIIsVvkZPq5QUo7Zejg1IfNIwxrnmt5N04JXJe+cz/TJM92VmXcihnnP?=
 =?us-ascii?Q?poXWVeG7+KIEWKwFOBTFlj72ZgmLyTFTeFIMAkap3XDSN8J6npkXQ0syWv6o?=
 =?us-ascii?Q?CWNc/f+126Xd2M2JS6biTNusYEnX34GXemKIP0PJmUvULftZKMAhNk9Ci6Lc?=
 =?us-ascii?Q?MfZfG+ENMvJ0ZDXltZOE5aTPEa8G72n6MR67yBr/+H8PUgTguYj/4/RQs6p+?=
 =?us-ascii?Q?2m+SxlHqxYIb4tSMlugL1B+fEF5OPWlgt8tCV+BNpcf6GBDFSFRBumRWAdN6?=
 =?us-ascii?Q?jkskUqj4Y+Xa/g31rB43EHkdEvNeDF20nOJj0ke1cGQy+BEBZUW+TGap8vXc?=
 =?us-ascii?Q?eQesm8gPPgi7w8yQWqgSnP3vgua623C3gnR/2DoYgzOLBW7R4IUGm4AEZuRz?=
 =?us-ascii?Q?B55x9waSC2IoGiZ07Q4UT6Hb8uCGAaumyGSVRALxaGvCYL5nb+lPskqPmucf?=
 =?us-ascii?Q?tKYZqddD6SHXwbbwe3qaY/GC?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB6593.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9037e0b2-6a69-46da-8478-08d97c402434
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2021 14:08:37.5414
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3Z1Zsh+EsDT9sWnJmsLUa0wVDhsGLlJPmWo02mMrB59VrjMHYvOtCHh8wdykTJoZ17Jt21HXSlrxrpgvzI3Krw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSYPR01MB5301
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>   > On Fri, Jun 25, 2021 at 02:24:24PM +0000, Min Li wrote:
>   > > How would you suggest to implement the change that make the new
> driver behavior optional?
>   > I would say, module parameter or debugfs knob.
>=20
> Aright, in which case devlink or debugfs, please.
>=20
> > > What's the point of this? Just rename the file in the filesystem.
> >
> > We use this parameter to specify firmware so that module can be
> > autoloaded /etc/modprobe.d/modname.conf
>=20
> Sorry, I don't understand. The firmware is in /lib/firmware.
> Previously you used a card coded name (whatever FW_FILENAME is,
> "idt82p33xxx.bin"?). This patch adds the ability to change the firmware f=
ile
> name by a module param.
>=20
> Now let me repeat the question - what's the point of user changing the
> requested firmware name if they can simply rename the file?

We have different firmware named after different 1588 profiles. If we renam=
e firmware, it would make
every profile  look same and confusing. On the other hand, with this module=
 parameter, we can have phc
module auto start with correct firmware.

Thanks

Min