Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp2308381pxb; Mon, 20 Sep 2021 18:21:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9kMbICgKQHdKCA5m+O5a7h8kTUElM55YbTVRBOakFOEnMVqKH4JHsc9Zd8PmAvv0rdkR/ X-Received: by 2002:a17:906:c246:: with SMTP id bl6mr31577205ejb.80.1632187310197; Mon, 20 Sep 2021 18:21:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632187310; cv=none; d=google.com; s=arc-20160816; b=QjNSCMF8cYugB1JwJuXY782Oq/x+LASiQtYMoGbqPrg9VMXVStxs5lyu6dmWUqvENc +9OQuw80zOVK08k2BK7VYcGEFI6nxbXsee7dDJZDpzCWFD3d9zfsXG2B61wFGb/vVrgS 27Ub/zl1Yvx8JWyrSWafaJ7QS4ZYeLJ1c59ksFXrqUFonHDQWiSnHAtyM7MPSEUvPOUa tdwIZT33LwlwOTKxgAGg+fkXWtW6u8rWTk2PocINdC5A+2iBEFJXw9NKiE3QYAPOFCFC ek6i3EOQI3qUZMi+FkDccFw3TCpf+OBYKfAsLOclDR0Ov6+h2vtF5PN3xmPpl+Kiv9RE eK2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=wc0pe1S5lL8oozeCqYrTcgBbDkFdXgdpaDhf7J6imA0=; b=GgN5o1386lHDI2bj0fUDNDgTE74trMm+qd11bG87BlDSDpXKJy4LBmx+WW4bL35m57 ujoOrtnfF5mp1nlbH69MJP9eVU/RmHimubhFWKsqDg4zpoHAbOuGv3sAocOqXco3nHIC WwL4F05BWZKqA+XZm1YTJGRxsXz+ViHqR/SY9GUZ0oH8lJHK0wEVjfjqrSl85rOnUgeO wjqHrTgPxt7ERbHGacKEOoD3PrWg1JKiSrFH0mOogcz4F2tRRUGI0rcdhlUxV+xRWLcE pMNtbdWAdC8FQs9lYHBiGUvIoVuXok8Dox/thbsZGSUEvGrJmATytPcW6l94YRIa4nYG Zoww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s26si4088003ejz.239.2021.09.20.18.21.26; Mon, 20 Sep 2021 18:21:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237447AbhITO2D (ORCPT + 99 others); Mon, 20 Sep 2021 10:28:03 -0400 Received: from outbound-smtp15.blacknight.com ([46.22.139.232]:39005 "EHLO outbound-smtp15.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237408AbhITO2C (ORCPT ); Mon, 20 Sep 2021 10:28:02 -0400 Received: from mail.blacknight.com (pemlinmail02.blacknight.ie [81.17.254.11]) by outbound-smtp15.blacknight.com (Postfix) with ESMTPS id 269E01C57BF for ; Mon, 20 Sep 2021 15:26:35 +0100 (IST) Received: (qmail 4987 invoked from network); 20 Sep 2021 14:26:34 -0000 Received: from unknown (HELO stampy.112glenside.lan) (mgorman@techsingularity.net@[84.203.17.29]) by 81.17.254.9 with ESMTPA; 20 Sep 2021 14:26:34 -0000 From: Mel Gorman To: Peter Zijlstra Cc: Ingo Molnar , Vincent Guittot , Valentin Schneider , Aubrey Li , Barry Song , Srikar Dronamraju , LKML , Mel Gorman Subject: [PATCH 1/2] sched/fair: Remove redundant lookup of rq in check_preempt_wakeup Date: Mon, 20 Sep 2021 15:26:13 +0100 Message-Id: <20210920142614.4891-2-mgorman@techsingularity.net> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210920142614.4891-1-mgorman@techsingularity.net> References: <20210920142614.4891-1-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The rq for curr is read during the function preamble, remove the redundant lookup. Signed-off-by: Mel Gorman --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index ff69f245b939..038edfaaae9e 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -7190,7 +7190,7 @@ static void check_preempt_wakeup(struct rq *rq, struct task_struct *p, int wake_ if (cse_is_idle != pse_is_idle) return; - update_curr(cfs_rq_of(se)); + update_curr(cfs_rq); if (wakeup_preempt_entity(se, pse) == 1) { /* * Bias pick_next to pick the sched entity that is -- 2.31.1