Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <b2d4183c-6867-6725-52ea-f48dd772e765@oracle.com>
Date:   Mon, 20 Sep 2021 09:57:02 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.1
Subject: Re: Fw: [syzbot] KASAN: use-after-free Read in
 copy_page_from_iter_atomic
Content-Language: en-US
To:     Andrew Morton <akpm@linux-foundation.org>
References: <20210919161900.ea7a5a46dad30cac229d1ff4@linux-foundation.org>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        syzkaller-bugs@googlegroups.com
From:   Dave Kleikamp <dave.kleikamp@oracle.com>
In-Reply-To: <20210919161900.ea7a5a46dad30cac229d1ff4@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2dKamdjZEJKK3pzNldnMTdndkxjV3RUTVFWMzQ2QjloNHpXSHg5N3d4akt2?=
 =?utf-8?B?aWw3cjZaSXQ2V1gybU5YZmxDam8xWktub1VQRUNCNmk0dXM5M0RpRlkvQmxh?=
 =?utf-8?B?bVNxL3hjY0l1eFFZM29uR3VaVzhkcjE4NExKMktnTm5aazlRTE1DSjlRRld1?=
 =?utf-8?B?VUYvRy9PUUV3MnVUYm0yM1o3M3RGTEpqWUVCR3R3eWV4cnc2NXZYQ3gvbmM2?=
 =?utf-8?B?cktmOWt1QlFPOG52VVdLaSs0Qm9sSjZWRlROTjYrNWgzZVlEdmtjYXBHOGtY?=
 =?utf-8?B?a2FMd2VhVEd1cVFaY1VnOHhMNVV5QlU0a2pOUkk5WnhJUm96Z1cxbjIwaVVy?=
 =?utf-8?B?L0VJVnN1Qm8vTDZObFI0c1BrMWsvTEtzbm9oRVcyTHlOWDhRMW5YWHRJOEJs?=
 =?utf-8?B?ZE1aS1cyT2l2cy9Bd0c5eUY5VlI1U3ArRFFYZ3Evd0ZaNFB5QUZ1a0tFbDNU?=
 =?utf-8?B?YlJtbUg5OGErd0NrSVVvdnZwZkw0NnBPaGd5SGJGSXB3QU1laElacEhkYk5s?=
 =?utf-8?B?c1k3S1NMMjAyVmUyczZLUUVaNWtFazl4bUFEdGI2V05USGliUE9JMk4wdU93?=
 =?utf-8?B?bzdkUkw2cklzbE03cXJ3bXJkQUptT0JtNEsxL2JHUzlqcGdKdG5Uc2ZET0Z3?=
 =?utf-8?B?TTc0RFJWN3hZTGhZWkpYUk4zVFQ5RXMyTktNSVQwUGt2S25xTGFEODBDOXI3?=
 =?utf-8?B?SGZhWTh2OEx5U0tiK0I4Q2w5L0JxN29Qc2dOU1RFejVvYS96WHFOUWpXdlZp?=
 =?utf-8?B?V1VKT1dqZ0Y3ZGtKTHpHUXhPSHpBWVFxcW5qa2svUEx5c3VOOTVvTEIwLzZR?=
 =?utf-8?B?QjFQak8vOGhVRUpJZUhYaFVhb1Fzc3p3OWZiMjlqTVhYaFd3aHBZOUtEQkVK?=
 =?utf-8?B?R2xCNm5yenJYR2UwNlAzSUc2V20zNEhCdGZiT2RmOWZyeTVPcjdPYVhvWUh2?=
 =?utf-8?B?bVpRekoyNVdIU2dSVW0vb0JRRmJPOGNxTzlwbG5UYnlBa2dXNERobStQbGlO?=
 =?utf-8?B?SGtaZC81c1Q2V0JkUWgwTWptK1M4NTdvNWVHWVFmMVc2Y040bTZhMHV0QTdF?=
 =?utf-8?B?WjBqZU9WY1hYaFJIaHR2d2puU1pjbUIwdXQ5VEtYbCtCcC9Rd2diY29xZURG?=
 =?utf-8?B?NE52QkdNL1hGbC9ZNWptL0xZV3lQSzlFRWczSU1xdzFQWWRlQXZJcHpGc3cy?=
 =?utf-8?B?WlN5Vjhud24xK3R5UTFKMG0wdzFOV25JQ1RlbUJCSTYybFNYVDR3TnhhUEVi?=
 =?utf-8?B?S0pYVVFzekovUmxlaVNSbEs0ZlpvNDR1cVFDcVlNR2tvaVpnQVNabnZsbVVM?=
 =?utf-8?B?dmpoYy9BUStTUU5KdUYydVlWZ01rWlkwT0QyazNlN3hHZXBKRkhKd1p4VGJr?=
 =?utf-8?B?QVVZdmZsNXVWVStuNjhuanZlSWdTT08zZ3l2TnpIc2lKcU14TFpDYkVNTVVK?=
 =?utf-8?B?c3J5elNFTzZLVzZOOUJ4YnBLM0hHTy9QN0k3TzM5WWZmdmxlT1NKR0ZFMDJ2?=
 =?utf-8?B?cHUwbEZEaEpJWVJIdFlwSXFqbTEzVE5tZVVBK29zdjRiaGRsK0lsczRCYUlU?=
 =?utf-8?B?ajZ4Y0RyWlVPcVllaVhRL0ZVOW5xbkRNK0svN3pyT3h3K2R0cWFEbW5zT1Nh?=
 =?utf-8?B?cFhFN1FCZGJkaFgyL0duUDN3VUdzbkROYkJVL0hwS095ZEFXNE5hOU5KcWEr?=
 =?utf-8?B?WmxaaDIyTmhxY20xNk1SZCtKbjhqNXg0bER2MW9NZkZ1N3dhTUtYSWc2cGlV?=
 =?utf-8?Q?G/mkOlQ/7N02vtNnVfXqzjc1dhhCQXJQ0V7SbS0?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c35915d-722f-4335-74ce-08d97c46e290
X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4665.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2021 14:56:54.2150
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yNFOLY8DiSCOCtT2Km56+BCvDQjpqOIehBoiiXv4LX6gvPtLNUBUOP9mg7JXlIyB/Qc6ao9xptsihTfswHcOrzPsbGHkmxMkBc4iXHJcDko=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2944
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10113 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 malwarescore=0
 mlxscore=0 suspectscore=0 spamscore=0 adultscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001
 definitions=main-2109200096
X-Proofpoint-ORIG-GUID: XOQ149qtohdHGK2wNKSmdUnLJuF_4slG
X-Proofpoint-GUID: XOQ149qtohdHGK2wNKSmdUnLJuF_4slG
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/19/21 18:19, Andrew Morton wrote:
> might be a loop-vs-jfs thing?

It may be just a buggy, rarely-taken error path in jfs_fill_super that 
happened to get caught in the loop code. I'll have to dig through this.

Shaggy

> 
> Begin forwarded message:
> 
> Date: Fri, 17 Sep 2021 09:33:28 -0700
> From: syzbot <syzbot+ffc4eceb22dfcf9fd6a0@syzkaller.appspotmail.com>
> To: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com
> Subject: [syzbot] KASAN: use-after-free Read in copy_page_from_iter_atomic
> 
> 
> Hello,
> 
> syzbot found the following issue on:
> 
> HEAD commit:    7d2a07b76933 Linux 5.14
> git tree:       upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=12fe8af5300000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=113c5df900d8cf12
> dashboard link: https://syzkaller.appspot.com/bug?extid=ffc4eceb22dfcf9fd6a0
> compiler:       Debian clang version 11.0.1-2, GNU ld (GNU Binutils for Debian) 2.35.1
> 
> Unfortunately, I don't have any reproducer for this issue yet.
> 
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+ffc4eceb22dfcf9fd6a0@syzkaller.appspotmail.com
> 
> ==================================================================
> BUG: KASAN: use-after-free in copy_page_from_iter_atomic+0x9c7/0x1520 lib/iov_iter.c:918
> Read of size 4096 at addr ffff8880298b0000 by task kworker/u4:8/11701
> 
> CPU: 0 PID: 11701 Comm: kworker/u4:8 Not tainted 5.14.0-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> Workqueue: loop5 loop_rootcg_workfn
> Call Trace:
>   __dump_stack lib/dump_stack.c:88 [inline]
>   dump_stack_lvl+0x1ae/0x29f lib/dump_stack.c:105
>   print_address_description+0x66/0x3b0 mm/kasan/report.c:233
>   __kasan_report mm/kasan/report.c:419 [inline]
>   kasan_report+0x163/0x210 mm/kasan/report.c:436
>   check_region_inline mm/kasan/generic.c:135 [inline]
>   kasan_check_range+0x2b5/0x2f0 mm/kasan/generic.c:189
>   memcpy+0x25/0x60 mm/kasan/shadow.c:65
>   copy_page_from_iter_atomic+0x9c7/0x1520 lib/iov_iter.c:918
>   generic_perform_write+0x2dd/0x580 mm/filemap.c:3664
>   __generic_file_write_iter+0x225/0x5a0 mm/filemap.c:3783
>   generic_file_write_iter+0xa7/0x1b0 mm/filemap.c:3815
>   do_iter_readv_writev+0x566/0x770 include/linux/fs.h:2108
>   do_iter_write+0x16c/0x5f0 fs/read_write.c:866
>   lo_write_bvec+0x267/0x6f0 drivers/block/loop.c:328
>   lo_write_simple drivers/block/loop.c:350 [inline]
>   do_req_filebacked drivers/block/loop.c:668 [inline]
>   loop_handle_cmd drivers/block/loop.c:2204 [inline]
>   loop_process_work+0x21c2/0x2cc0 drivers/block/loop.c:2244
>   process_one_work+0x833/0x10c0 kernel/workqueue.c:2276
>   worker_thread+0xac1/0x1320 kernel/workqueue.c:2422
>   kthread+0x453/0x480 kernel/kthread.c:319
>   ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295
> 
> The buggy address belongs to the page:
> page:ffffea0000a62c00 refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x298b0
> flags: 0xfff00000000000(node=0|zone=1|lastcpupid=0x7ff)
> raw: 00fff00000000000 ffffea0000bb3348 ffffea0000d492c8 0000000000000000
> raw: 0000000000000000 0000000000000000 00000000ffffffff 0000000000000000
> page dumped because: kasan: bad access detected
> page_owner tracks the page as freed
> page last allocated via order 0, migratetype Unmovable, gfp_mask 0xdc0(GFP_KERNEL|__GFP_ZERO), pid 20552, ts 462739681694, free_ts 462770335978
>   prep_new_page mm/page_alloc.c:2436 [inline]
>   get_page_from_freelist+0x779/0xa30 mm/page_alloc.c:4168
>   __alloc_pages+0x26c/0x5f0 mm/page_alloc.c:5390
>   lbmLogInit fs/jfs/jfs_logmgr.c:1824 [inline]
>   lmLogInit+0x2fc/0x1e90 fs/jfs/jfs_logmgr.c:1278
>   open_inline_log fs/jfs/jfs_logmgr.c:1183 [inline]
>   lmLogOpen+0x505/0x1190 fs/jfs/jfs_logmgr.c:1077
>   jfs_mount_rw+0xe7/0x710 fs/jfs/jfs_mount.c:260
>   jfs_fill_super+0x64c/0xc20 fs/jfs/super.c:570
>   mount_bdev+0x26c/0x3a0 fs/super.c:1368
>   legacy_get_tree+0xea/0x180 fs/fs_context.c:610
>   vfs_get_tree+0x86/0x270 fs/super.c:1498
>   do_new_mount fs/namespace.c:2923 [inline]
>   path_mount+0x1981/0x2c10 fs/namespace.c:3253
>   do_mount fs/namespace.c:3266 [inline]
>   __do_sys_mount fs/namespace.c:3474 [inline]
>   __se_sys_mount+0x2f9/0x3b0 fs/namespace.c:3451
>   do_syscall_x64 arch/x86/entry/common.c:50 [inline]
>   do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
>   entry_SYSCALL_64_after_hwframe+0x44/0xae
> page last free stack trace:
>   reset_page_owner include/linux/page_owner.h:24 [inline]
>   free_pages_prepare mm/page_alloc.c:1346 [inline]
>   free_pcp_prepare+0xc29/0xd20 mm/page_alloc.c:1397
>   free_unref_page_prepare mm/page_alloc.c:3332 [inline]
>   free_unref_page+0x7e/0x550 mm/page_alloc.c:3411
>   lbmLogShutdown fs/jfs/jfs_logmgr.c:1872 [inline]
>   lmLogShutdown+0x4ad/0x920 fs/jfs/jfs_logmgr.c:1692
>   lmLogClose+0x2c2/0x560 fs/jfs/jfs_logmgr.c:1468
>   jfs_umount+0x297/0x370 fs/jfs/jfs_umount.c:116
>   jfs_fill_super+0x8e5/0xc20 fs/jfs/super.c:605
>   mount_bdev+0x26c/0x3a0 fs/super.c:1368
>   legacy_get_tree+0xea/0x180 fs/fs_context.c:610
>   vfs_get_tree+0x86/0x270 fs/super.c:1498
>   do_new_mount fs/namespace.c:2923 [inline]
>   path_mount+0x1981/0x2c10 fs/namespace.c:3253
>   do_mount fs/namespace.c:3266 [inline]
>   __do_sys_mount fs/namespace.c:3474 [inline]
>   __se_sys_mount+0x2f9/0x3b0 fs/namespace.c:3451
>   do_syscall_x64 arch/x86/entry/common.c:50 [inline]
>   do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
>   entry_SYSCALL_64_after_hwframe+0x44/0xae
> 
> Memory state around the buggy address:
>   ffff8880298aff00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>   ffff8880298aff80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>> ffff8880298b0000: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
>                     ^
>   ffff8880298b0080: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
>   ffff8880298b0100: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> ==================================================================
> 
> 
> ---
> This report is generated by a bot. It may contain errors.
> See https://goo.gl/tpsmEJ for more information about syzbot.
> syzbot engineers can be reached at syzkaller@googlegroups.com.
> 
> syzbot will keep track of this issue. See:
> https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
>