Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210918094157.4770-1-yangzhiwei@uniontech.com> <484936f6-86e8-2078-3739-674a04283666@gmail.com>
In-Reply-To: <484936f6-86e8-2078-3739-674a04283666@gmail.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 20 Sep 2021 12:00:50 -0400
Message-ID: <CADnq5_PwkRb=2z2ak5f8gnAwzQLdE_6ACjtNvpe+6hECxxsCpA@mail.gmail.com>
Subject: Re: [PATCH] drm/radeon: fix uninitialized bool variable
To:     =?UTF-8?Q?Christian_K=C3=B6nig?= <ckoenig.leichtzumerken@gmail.com>
Cc:     Zhiwei Yang <yangzhiwei@uniontech.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Sep 20, 2021 at 3:44 AM Christian K=C3=B6nig
<ckoenig.leichtzumerken@gmail.com> wrote:
>
>
>
> Am 18.09.21 um 11:41 schrieb Zhiwei Yang:
> > The bool variable detected_hpd_without_ddc in struct radeon_connector
> > is uninitialized when first used, that may cause unnecessary ddc ops.
> > Make it as false when a new connector is alloced.
> >
> > Signed-off-by: Zhiwei Yang <yangzhiwei@uniontech.com>
> > ---
> >   drivers/gpu/drm/radeon/radeon_connectors.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/d=
rm/radeon/radeon_connectors.c
> > index fe12d9d91d7a..c1987a66373f 100644
> > --- a/drivers/gpu/drm/radeon/radeon_connectors.c
> > +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
> > @@ -1866,6 +1866,7 @@ radeon_add_atom_connector(struct drm_device *dev,
> >       bool shared_ddc =3D false;
> >       bool is_dp_bridge =3D false;
> >       bool has_aux =3D false;
> > +     bool detected_hpd_without_ddc =3D false;
>
> In general good catch, but I don't see the need for a local variable here=
.
>
> Just initialize the member directly or even better change the allocation
> of the connector into a kzalloc().

This is already the case:
        radeon_connector =3D kzalloc(sizeof(struct radeon_connector), GFP_K=
ERNEL);
So I don't think this patch is necessary.

Alex

>
> Christian.
>
> >
> >       if (connector_type =3D=3D DRM_MODE_CONNECTOR_Unknown)
> >               return;
> > @@ -1923,6 +1924,7 @@ radeon_add_atom_connector(struct drm_device *dev,
> >       radeon_connector->shared_ddc =3D shared_ddc;
> >       radeon_connector->connector_object_id =3D connector_object_id;
> >       radeon_connector->hpd =3D *hpd;
> > +     radeon_connector->detected_hpd_without_ddc =3D detected_hpd_witho=
ut_ddc;
> >
> >       radeon_connector->router =3D *router;
> >       if (router->ddc_valid || router->cd_valid) {
> > @@ -2384,6 +2386,7 @@ radeon_add_legacy_connector(struct drm_device *de=
v,
> >       struct radeon_connector *radeon_connector;
> >       struct i2c_adapter *ddc =3D NULL;
> >       uint32_t subpixel_order =3D SubPixelNone;
> > +     bool detected_hpd_without_ddc =3D false;
> >
> >       if (connector_type =3D=3D DRM_MODE_CONNECTOR_Unknown)
> >               return;
> > @@ -2414,6 +2417,7 @@ radeon_add_legacy_connector(struct drm_device *de=
v,
> >       radeon_connector->devices =3D supported_device;
> >       radeon_connector->connector_object_id =3D connector_object_id;
> >       radeon_connector->hpd =3D *hpd;
> > +     radeon_connector->detected_hpd_without_ddc =3D detected_hpd_witho=
ut_ddc;
> >
> >       switch (connector_type) {
> >       case DRM_MODE_CONNECTOR_VGA:
>