Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 20 Sep 2021 19:28:01 +0300
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Hyun Kwon <hyun.kwon@xilinx.com>, Vinod Koul <vkoul@kernel.org>,
        Michal Simek <michal.simek@xilinx.com>,
        Sanjay R Mehta <sanju.mehta@amd.com>,
        Peter Ujfalusi <peter.ujfalusi@ti.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Jianqiang Chen <jianqiang.chen@xilinx.com>,
        Quanyang Wang <quanyang.wang@windriver.com>,
        Yang Li <yang.lee@linux.alibaba.com>,
        Allen Pais <apais@linux.microsoft.com>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Biju Das <biju.das.jz@bp.renesas.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        dmaengine@vger.kernel.org,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: remove debugfs #ifdef
Message-ID: <YUi2kQqNVLSeA87X@pendragon.ideasonboard.com>
References: <20210920122017.205975-1-arnd@kernel.org>
 <YUiCy7A9cXTDGx6s@pendragon.ideasonboard.com>
 <CAK8P3a1fcmCWsOuqF8qy4ko9MC8nCd4gyt2K6Rk5K-Zs7yCbJA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAK8P3a1fcmCWsOuqF8qy4ko9MC8nCd4gyt2K6Rk5K-Zs7yCbJA@mail.gmail.com>
Precedence: bulk

Hi Arnd,

On Mon, Sep 20, 2021 at 02:50:52PM +0200, Arnd Bergmann wrote:
> On Mon, Sep 20, 2021 at 2:47 PM Laurent Pinchart wrote:
> >
> > It's only a few bytes of data in struct dma_device, but a bit more in
> > .text here. Is the simplification really required in this driver ?
> 
> The intention was to not change the resulting object code in this driver,
> and I still don't see where it would grow after dead-code-elimination removes
> all the unused static functions. What am I missing?

Indeed, gcc does a fairly good job there. The .text section doesn't
grow. Interestingly, there's an increase in size in the .data and
.rodata sections in the xilinx-dpdma module:

-  8 .rodata.str1.8 0000029f  0000000000000000  0000000000000000  00003660  2**3
+  8 .rodata.str1.8 000002a7  0000000000000000  0000000000000000  00003660  2**3

- 10 .rodata       00001080  0000000000000000  0000000000000000  00003960  2**5
+ 10 .rodata       000010e0  0000000000000000  0000000000000000  00003960  2**5

- 15 .data         00001050  0000000000000000  0000000000000000  00004e40  2**5
+ 15 .data         00001090  0000000000000000  0000000000000000  00004ea0  2**5

I'm not entirely sure where it comes from, it may be related to
instrumentation caused by debugging options.

For your patch,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

-- 
Regards,

Laurent Pinchart